* [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c.
@ 2010-04-19 9:50 Rami Rosen
2010-04-21 2:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2010-04-19 9:50 UTC (permalink / raw)
To: davem, netdev
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
Hi,
There is no need to export skb_under_panic() and skb_over_panic() in
skbuff.c, since these methods are used only in
skbuff.c ; this patch removes these two exports.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 666 bytes --]
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 93c4e06..799b89d 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -126,7 +126,6 @@ void skb_over_panic(struct sk_buff *skb, int sz, void *here)
skb->dev ? skb->dev->name : "<NULL>");
BUG();
}
-EXPORT_SYMBOL(skb_over_panic);
/**
* skb_under_panic - private function
@@ -146,7 +145,6 @@ void skb_under_panic(struct sk_buff *skb, int sz, void *here)
skb->dev ? skb->dev->name : "<NULL>");
BUG();
}
-EXPORT_SYMBOL(skb_under_panic);
/* Allocate a new skbuff. We do this ourselves so we can fill in a few
* 'private' fields and also do memory statistics to find all the
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c.
2010-04-19 9:50 [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c Rami Rosen
@ 2010-04-21 2:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-21 2:26 UTC (permalink / raw)
To: ramirose; +Cc: netdev
From: Rami Rosen <ramirose@gmail.com>
Date: Mon, 19 Apr 2010 12:50:19 +0300
> There is no need to export skb_under_panic() and skb_over_panic() in
> skbuff.c, since these methods are used only in
> skbuff.c ; this patch removes these two exports.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
If this is indeed the case, you should also mark these functions
'static' and remove the extern declarations of them from
include/linux/skbuff.h
Please make those changes and resubmit your patch (against
net-next-2.6 since that's where it belongs at this point).
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-21 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-19 9:50 [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c Rami Rosen
2010-04-21 2:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.