All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan.hovold@lundinova.se>
To: Ranga Rao Ravuri <ranga.ravuri@atheros.com>
Cc: Johan Hovold <johan.hovold@lundinova.se>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] ath9k: corrupt frames forwarded to mac80211 as decrypted
Date: Tue, 20 Apr 2010 13:06:57 +0200	[thread overview]
Message-ID: <20100420110657.GH5288@lundinova.se> (raw)
In-Reply-To: <1271754651.14253.112.camel@ranga-desktop>

On Tue, Apr 20, 2010 at 02:40:51PM +0530, Ranga Rao Ravuri wrote:
> Can you please tell us more about your test, 
> what exactly is your test is ? 
> What kind of traffic are you running 
> what is your AP ?. 

I have a powerpc-based platform running AR9280 in AP mode. My STA is an
Intel 5300 (but I have been able to reproduce it also with an STA using
AR5008).

After connecting I run iperf in client mode on the STA thus sending data
to the STA. After a short while the AP stops receiving any data
(including TCP-acks) and the transfer stalls.

I've verified that frames that look ok in the air can still be corrupt
in ath9k. In particular, the status field is trashed so that frames are
incorrectly forwarded to mac80211 marked as decrypted which can trigger
countermeasures or update CCMP PN incorrectly (thereby dropping later,
correct frames).

Discarding frames which appear to have trashed status makes 802.11n
work.

> Are you testing with aggregated traffic or non-aggregate legacy
> traffic ?

Aggregated.

> Are you seeing only when CCMP is enabled or in WEP/TKIP also ?

Only with 802.11n (CCMP). Everything works perfectly with 802.11g and
WEP/TKIP/CCMP and I never see any corrupt frame status.

> Can you please set register 0x8120 bit 28 to 1 and test this again to
> see that helps ?

I'll try that.

Thanks,
Johan


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan.hovold@lundinova.se>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: corrupt frames forwarded to mac80211 as decrypted
Date: Tue, 20 Apr 2010 13:06:57 +0200	[thread overview]
Message-ID: <20100420110657.GH5288@lundinova.se> (raw)
In-Reply-To: <1271754651.14253.112.camel@ranga-desktop>

On Tue, Apr 20, 2010 at 02:40:51PM +0530, Ranga Rao Ravuri wrote:
> Can you please tell us more about your test, 
> what exactly is your test is ? 
> What kind of traffic are you running 
> what is your AP ?. 

I have a powerpc-based platform running AR9280 in AP mode. My STA is an
Intel 5300 (but I have been able to reproduce it also with an STA using
AR5008).

After connecting I run iperf in client mode on the STA thus sending data
to the STA. After a short while the AP stops receiving any data
(including TCP-acks) and the transfer stalls.

I've verified that frames that look ok in the air can still be corrupt
in ath9k. In particular, the status field is trashed so that frames are
incorrectly forwarded to mac80211 marked as decrypted which can trigger
countermeasures or update CCMP PN incorrectly (thereby dropping later,
correct frames).

Discarding frames which appear to have trashed status makes 802.11n
work.

> Are you testing with aggregated traffic or non-aggregate legacy
> traffic ?

Aggregated.

> Are you seeing only when CCMP is enabled or in WEP/TKIP also ?

Only with 802.11n (CCMP). Everything works perfectly with 802.11g and
WEP/TKIP/CCMP and I never see any corrupt frame status.

> Can you please set register 0x8120 bit 28 to 1 and test this again to
> see that helps ?

I'll try that.

Thanks,
Johan

  reply	other threads:[~2010-04-20 11:06 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 19:10 ath9k: receive stops working in AP-mode and 802.11n Johan Hovold
2010-03-31 19:10 ` [ath9k-devel] " Johan Hovold
2010-04-16 10:48 ` ath9k: corrupt frames forwarded to mac80211 as decrypted (was: ath9k: receive stops working in AP-mode and 802.11n) Johan Hovold
2010-04-16 10:48   ` [ath9k-devel] " Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 1/6] ath9k: clean up rx skb post-process logic Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 2/6] ath9k: do not mark frames with RXKEY_IX_INVALID as decrypted Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-16 11:32     ` Jouni Malinen
2010-04-16 11:32       ` Jouni Malinen
2010-04-20  8:35       ` Johan Hovold
2010-04-20  8:35         ` Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 3/6] ath9k: do not mark frames with RX_DECRYPT_BUSY " Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 4/6] ath9k: do not mark frames with RX_KEY_MISS " Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 5/6] ath9k: check error flags even if rx frame is marked ok Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-16 10:52   ` [RFC][PATCH 6/6] ath9k: clear mic error flag on encrypted frames Johan Hovold
2010-04-16 10:52     ` [ath9k-devel] " Johan Hovold
2010-04-20  8:25   ` [ath9k-devel] ath9k: corrupt frames forwarded to mac80211 as decrypted Johan Hovold
2010-04-20  8:25     ` Johan Hovold
2010-04-20  8:28     ` [RFC][PATCH 1/2] ath9k: fix corrupt frames being forwarded to mac80211 Johan Hovold
2010-04-20  8:28       ` [ath9k-devel] " Johan Hovold
2010-04-20  8:38       ` Johan Hovold
2010-04-20  8:38         ` [ath9k-devel] " Johan Hovold
2010-04-20  8:28     ` [RFC][PATCH 2/2] ath9k: use also AR_DecryptBusyErr to determine decrypt errors Johan Hovold
2010-04-20  8:28       ` [ath9k-devel] " Johan Hovold
2010-04-20  9:10     ` [ath9k-devel] ath9k: corrupt frames forwarded to mac80211 as decrypted Ranga Rao Ravuri
2010-04-20  9:10       ` Ranga Rao Ravuri
2010-04-20 11:06       ` Johan Hovold [this message]
2010-04-20 11:06         ` Johan Hovold
2010-04-20 11:35         ` Johan Hovold
2010-04-20 11:35           ` Johan Hovold
2010-04-29  8:26           ` Daniel Yingqiang Ma
2010-04-29  8:26             ` Daniel Yingqiang Ma
2010-04-29  8:41             ` Tor Krill
2010-04-29  9:35               ` Daniel Yingqiang Ma
2010-04-29 18:08               ` Ben Gamari
2010-04-29 20:08                 ` Will Dyson
2010-04-30  9:07                 ` Tor Krill
2010-04-29 20:21               ` Benoit PAPILLAULT
2010-04-30  9:50               ` Tor Krill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100420110657.GH5288@lundinova.se \
    --to=johan.hovold@lundinova.se \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ranga.ravuri@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.