Please pull logfs tree for fixes

Please pull logfs tree for fixes

[Jörn Engel]

Another set of fixes.  Two of them are security relevant.  But given
that an attacker needs mount access and few people have logfs compiled
in, that's unlikely to be a huge issue.

 gc.c        |    8 ++++++
 journal.c   |   29 ++++++++++++++---------
 logfs.h     |   15 ++++++++++--
 readwrite.c |   75 +++++++++++++++++++++++++++++++++---------------------------
 segment.c   |    8 ------
 super.c     |   11 +++++++-
 6 files changed, 91 insertions(+), 55 deletions(-)

Jörn

-- 
More computing sins are committed in the name of efficiency (without
necessarily achieving it) than for any other single reason - including
blind stupidity.
-- W. A. Wulf

Re: Please pull logfs tree for fixes

[Daniel Walker]

On Wed, 2010-04-21 at 14:19 +0200, Jörn Engel wrote:
> Another set of fixes.  Two of them are security relevant.  But given
> that an attacker needs mount access and few people have logfs compiled
> in, that's unlikely to be a huge issue.
> 
>  gc.c        |    8 ++++++
>  journal.c   |   29 ++++++++++++++---------
>  logfs.h     |   15 ++++++++++--
>  readwrite.c |   75 +++++++++++++++++++++++++++++++++---------------------------
>  segment.c   |    8 ------
>  super.c     |   11 +++++++-
>  6 files changed, 91 insertions(+), 55 deletions(-)

Where is the url for your tree? There's a git command,

"git request-pull"

It spits out a form email with url , and all the needed info.

Daniel

Re: Please pull logfs tree for fixes

[Jörn Engel]

On Wed, 21 April 2010 07:09:22 -0700, Daniel Walker wrote:
> On Wed, 2010-04-21 at 14:19 +0200, Jörn Engel wrote:
> > Another set of fixes.  Two of them are security relevant.  But given
> > that an attacker needs mount access and few people have logfs compiled
> > in, that's unlikely to be a huge issue.
> > 
> >  gc.c        |    8 ++++++
> >  journal.c   |   29 ++++++++++++++---------
> >  logfs.h     |   15 ++++++++++--
> >  readwrite.c |   75 +++++++++++++++++++++++++++++++++---------------------------
> >  segment.c   |    8 ------
> >  super.c     |   11 +++++++-
> >  6 files changed, 91 insertions(+), 55 deletions(-)
> 
> Where is the url for your tree? There's a git command,

Doh!

git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs.git

> "git request-pull"
> 
> It spits out a form email with url , and all the needed info.

Nice.  Guess I'll use that from now on.  Thanks!

Jörn

-- 
"Translations are and will always be problematic. They inflict violence
upon two languages." (translation from German)

Re: Please pull logfs tree for fixes

[Linus Torvalds]

On Mon, 17 May 2010, Jörn Engel wrote:
> 
> If such a situation reappears in the future, would you rather have the
> fixes and mindlessly revert them in case of any trouble or wait until
> the respective maintainer reappers?

Hmm. I think I'm happier this way. If there is something really critical 
for 2.6.34, you can always send it to stable.

		Linus

Please pull logfs tree for fixes

[Jörn Engel]

Linus,

this should have made it into 2.6.34 - except that I was on vacation
last week and decided not to send a pull request right before hanging
out the "gone fishing" sign.  Whether that was a wise decision, I'm no
longer so sure.

If such a situation reappears in the future, would you rather have the
fixes and mindlessly revert them in case of any trouble or wait until
the respective maintainer reappers?

Jörn

-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it.
-- Brian W. Kernighan


The following changes since commit 79dba2eaa771c3173957eccfd288e0e0d12e4d3f:
  Linus Torvalds (1):
        Merge branch 'for-linus' of git://git.kernel.org/.../jbarnes/pci-2.6

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs.git master

Dan Carpenter (2):
      logfs: testing the wrong variable
      logfs: handle errors from get_mtd_device()

Joern Engel (10):
      LogFS: Fix typo in b6349ac8
      logfs: Return -EINVAL if filesystem image doesn't match
      logfs: fix logfs_seek_hole()
      logfs: Close i_ino reuse race
      logfs: survive logfs_buf_recover read errors
      logfs: commit reservations under space pressure
      logfs: fix compile failure
      logfs: fix sync
      logfs: remove unused variable
      logfs: handle powerfail on NAND flash

Prasad Joshi (1):
      logfs: initialize li->li_refcount

 fs/logfs/dev_bdev.c  |    6 ++++++
 fs/logfs/dev_mtd.c   |   26 +++++++++++++++++++++++++-
 fs/logfs/file.c      |   16 ++++++++++++----
 fs/logfs/gc.c        |   49 +++++++++++++++++++++----------------------------
 fs/logfs/inode.c     |    6 +++---
 fs/logfs/journal.c   |    7 +++----
 fs/logfs/logfs.h     |   13 ++++++++-----
 fs/logfs/readwrite.c |   19 +++++++++++++++----
 fs/logfs/segment.c   |    7 +++++--
 fs/logfs/super.c     |    8 ++++++--
 10 files changed, 104 insertions(+), 53 deletions(-)

Please pull logfs tree for fixes

[Jörn Engel]

Good morning Linus!

I have a dozen fixes for you.  Some solve error path bugs, some are
necessary for the SSD that I never wanted to buy but finally did anyway
and the rest solve rather nasty bugs.

Al still has one error path problem I haven't dealt with yet.

 dev_bdev.c  |    9 +++++++--
 dir.c       |    4 ++--
 journal.c   |    7 +++++++
 logfs.h     |    1 +
 readwrite.c |   13 ++++++++++++-
 segment.c   |   54 +++++++++++++++++++++++++++++++-----------------------
 super.c     |   15 +++++++--------
 7 files changed, 67 insertions(+), 36 deletions(-)

git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs.git

Jörn

-- 
Joern's library part 11:
http://www.unicom.com/pw/reply-to-harmful.html