* [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght
@ 2010-04-23 8:41 Florian Fainelli
2010-09-12 10:01 ` Remy Bohmer
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2010-04-23 8:41 UTC (permalink / raw)
To: u-boot
It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
successfully registered, and at the correct location.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 047902a..4402abb 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
hcor = (struct ehci_hcor *)((uint32_t) hccr +
HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+ printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
+ (uint32_t)hccr, (uint32_t)hcor,
+ (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght
2010-04-23 8:41 [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght Florian Fainelli
@ 2010-09-12 10:01 ` Remy Bohmer
2010-09-12 12:24 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Remy Bohmer @ 2010-09-12 10:01 UTC (permalink / raw)
To: u-boot
Hi Florian,
2010/4/23 Florian Fainelli <f.fainelli@gmail.com>:
> It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
> successfully registered, and at the correct location.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 047902a..4402abb 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
> ? ? ? ?hcor = (struct ehci_hcor *)((uint32_t) hccr +
> ? ? ? ? ? ? ? ? ? ? ? ?HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
>
> + ? ? ? printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
> + ? ? ? ? ? ? ? ? ? ? ? (uint32_t)hccr, (uint32_t)hcor,
> + ? ? ? ? ? ? ? ? ? ? ? (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> +
I guess I missed this patch...
Should the 'printf' not be a 'debug' statement?
Kind regards,
Remy
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght
2010-09-12 10:01 ` Remy Bohmer
@ 2010-09-12 12:24 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2010-09-12 12:24 UTC (permalink / raw)
To: u-boot
Hi Remy,
Le Sunday 12 September 2010 12:01:18, Remy Bohmer a ?crit :
> Hi Florian,
>
> 2010/4/23 Florian Fainelli <f.fainelli@gmail.com>:
> > It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure
> > it was successfully registered, and at the correct location.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> > index 047902a..4402abb 100644
> > --- a/drivers/usb/host/ehci-pci.c
> > +++ b/drivers/usb/host/ehci-pci.c
> > @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
> > hcor = (struct ehci_hcor *)((uint32_t) hccr +
> > HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> >
> > + printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
> > + (uint32_t)hccr, (uint32_t)hcor,
> > +
> > (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); +
>
> I guess I missed this patch...
No problem.
> Should the 'printf' not be a 'debug' statement?
I think so, I will respin this patch. Thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-12 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-23 8:41 [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght Florian Fainelli
2010-09-12 10:01 ` Remy Bohmer
2010-09-12 12:24 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.