All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfsprogs: mkfs manpage -nsize/log
@ 2010-04-26 11:53 Wengang Wang
  2010-04-26 12:32 ` Wengang Wang
  2010-04-26 15:59 ` Eric Sandeen
  0 siblings, 2 replies; 3+ messages in thread
From: Wengang Wang @ 2010-04-26 11:53 UTC (permalink / raw)
  To: xfs; +Cc: greg.marsden, joe.jin, wen.gang.wang

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
 man/man8/mkfs.xfs.8 |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 4b147e9..bdaa153 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -478,6 +478,8 @@ in bytes with
 or as a base two logarithm
 .I value
 .RB "with " log= .
+The block size must be a power of 2 size and cannot be made less than the
+filesystem block size.
 The default size
 .I value
 for version 2 directories is 4096 bytes (4 KiB),
-- 
1.6.6.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs: mkfs manpage -nsize/log
  2010-04-26 11:53 [PATCH] xfsprogs: mkfs manpage -nsize/log Wengang Wang
@ 2010-04-26 12:32 ` Wengang Wang
  2010-04-26 15:59 ` Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Wengang Wang @ 2010-04-26 12:32 UTC (permalink / raw)
  To: Wengang Wang; +Cc: greg.marsden, joe.jin, xfs

Sorry.
Send description of this patch.

There are two limitation for mkfs.xfs -nsize/log option:
1) directory block size must be a power of 2 size.
2) it can't be less than a file system block size.

Current man page don't include the above information. User could
be confused with errors, say "Illegal value xxx for -n size option", but
they can't find out the cause by checking the man page.

The patch adds the two limitations to the manpage.

On 10-04-26 19:53, Wengang Wang wrote:
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
>  man/man8/mkfs.xfs.8 |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 4b147e9..bdaa153 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -478,6 +478,8 @@ in bytes with
>  or as a base two logarithm
>  .I value
>  .RB "with " log= .
> +The block size must be a power of 2 size and cannot be made less than the
> +filesystem block size.
>  The default size
>  .I value
>  for version 2 directories is 4096 bytes (4 KiB),
> -- 
> 1.6.6.1
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs: mkfs manpage -nsize/log
  2010-04-26 11:53 [PATCH] xfsprogs: mkfs manpage -nsize/log Wengang Wang
  2010-04-26 12:32 ` Wengang Wang
@ 2010-04-26 15:59 ` Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2010-04-26 15:59 UTC (permalink / raw)
  To: Wengang Wang; +Cc: greg.marsden, joe.jin, xfs

On 04/26/2010 06:53 AM, Wengang Wang wrote:
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>

Looks good, thank you!   I'll merge this along with your updated commit
message.

-Eric

> ---
>  man/man8/mkfs.xfs.8 |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 4b147e9..bdaa153 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -478,6 +478,8 @@ in bytes with
>  or as a base two logarithm
>  .I value
>  .RB "with " log= .
> +The block size must be a power of 2 size and cannot be made less than the
> +filesystem block size.
>  The default size
>  .I value
>  for version 2 directories is 4096 bytes (4 KiB),

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-26 15:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-26 11:53 [PATCH] xfsprogs: mkfs manpage -nsize/log Wengang Wang
2010-04-26 12:32 ` Wengang Wang
2010-04-26 15:59 ` Eric Sandeen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.