* [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
@ 2010-04-14 15:52 Sergei Shtylyov
2010-04-23 2:12 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2010-04-14 15:52 UTC (permalink / raw)
To: davem, linux-ide; +Cc: rmk
The driver takes into account not only the interrupt status bit but also "FIFO
empty" bit in its test_irq() method. This actually is a superfluous check since
for the DMA commands calling the dma_test_irq() method further in the interrupt
handler makes sure FIFO is emptied.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is atop of ide-2.6.git tree...
Russell, would you mind giving this patch a test?
drivers/ide/pdc202xx_old.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: ide-2.6/drivers/ide/pdc202xx_old.c
===================================================================
--- ide-2.6.orig/drivers/ide/pdc202xx_old.c
+++ ide-2.6/drivers/ide/pdc202xx_old.c
@@ -93,13 +93,13 @@ static int pdc202xx_test_irq(ide_hwif_t
* bit 7: error, bit 6: interrupting,
* bit 5: FIFO full, bit 4: FIFO empty
*/
- return ((sc1d & 0x50) == 0x50) ? 1 : 0;
+ return (sc1d & 0x40) ? 1 : 0;
} else {
/*
* bit 3: error, bit 2: interrupting,
* bit 1: FIFO full, bit 0: FIFO empty
*/
- return ((sc1d & 0x05) == 0x05) ? 1 : 0;
+ return (sc1d & 0x04) ? 1 : 0;
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
2010-04-14 15:52 [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method Sergei Shtylyov
@ 2010-04-23 2:12 ` David Miller
2010-04-27 16:41 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2010-04-23 2:12 UTC (permalink / raw)
To: sshtylyov; +Cc: linux-ide, rmk
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Wed, 14 Apr 2010 19:52:59 +0400
> The driver takes into account not only the interrupt status bit but also "FIFO
> empty" bit in its test_irq() method. This actually is a superfluous check since
> for the DMA commands calling the dma_test_irq() method further in the interrupt
> handler makes sure FIFO is emptied.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is atop of ide-2.6.git tree...
>
> Russell, would you mind giving this patch a test?
Applied, but I don't want to push this out until there is
positive testing from Russell.
Russell, please test Sergei's patch, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
2010-04-23 2:12 ` David Miller
@ 2010-04-27 16:41 ` David Miller
2010-04-27 19:14 ` Mikael Pettersson
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2010-04-27 16:41 UTC (permalink / raw)
To: sshtylyov; +Cc: linux-ide, rmk
From: David Miller <davem@davemloft.net>
Date: Thu, 22 Apr 2010 19:12:36 -0700 (PDT)
> Russell, please test Sergei's patch, thanks!
I don't think Russell has seen any of these postings or requests for
testing since as vger postmaster I'm now seeing his email address
bouncing with 5 day delivery timeouts... sigh :-/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
2010-04-27 16:41 ` David Miller
@ 2010-04-27 19:14 ` Mikael Pettersson
0 siblings, 0 replies; 4+ messages in thread
From: Mikael Pettersson @ 2010-04-27 19:14 UTC (permalink / raw)
To: David Miller; +Cc: sshtylyov, linux-ide, rmk
David Miller writes:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 22 Apr 2010 19:12:36 -0700 (PDT)
>
> > Russell, please test Sergei's patch, thanks!
>
> I don't think Russell has seen any of these postings or requests for
> testing since as vger postmaster I'm now seeing his email address
> bouncing with 5 day delivery timeouts... sigh :-/
RMK is temporarily offline due to ISP problems. He's managed to sneak a few
messages about it to the ARM list via some other route, but that's it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-27 19:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-14 15:52 [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method Sergei Shtylyov
2010-04-23 2:12 ` David Miller
2010-04-27 16:41 ` David Miller
2010-04-27 19:14 ` Mikael Pettersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.