All of lore.kernel.org
 help / color / mirror / Atom feed
* [net-2.6 PATCH] ixgbe: Properly display 1 gig downshift warning for backplane
@ 2010-04-27 10:37 Jeff Kirsher
  2010-04-27 16:54 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2010-04-27 10:37 UTC (permalink / raw)
  To: davem; +Cc: netdev, gospo, Anjali Singhai, Jeff Kirsher

From: Anjali Singhai <anjali.singhai@intel.com>

Description: When using Intel smartspeed, the patch displays a
warning when the link down shifts to 1 Gig.

Signed-off-by: Anjali Singhai <anjali.singhai@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/ixgbe/ixgbe_82599.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_82599.c b/drivers/net/ixgbe/ixgbe_82599.c
index b405a00..217237c 100644
--- a/drivers/net/ixgbe/ixgbe_82599.c
+++ b/drivers/net/ixgbe/ixgbe_82599.c
@@ -608,6 +608,7 @@ static s32 ixgbe_setup_mac_link_smartspeed(struct ixgbe_hw *hw,
 	s32 i, j;
 	bool link_up = false;
 	u32 autoc_reg = IXGBE_READ_REG(hw, IXGBE_AUTOC);
+	struct ixgbe_adapter *adapter = hw->back;
 
 	hw_dbg(hw, "ixgbe_setup_mac_link_smartspeed.\n");
 
@@ -692,6 +693,10 @@ static s32 ixgbe_setup_mac_link_smartspeed(struct ixgbe_hw *hw,
 					    autoneg_wait_to_complete);
 
 out:
+	if (link_up && (link_speed == IXGBE_LINK_SPEED_1GB_FULL))
+		netif_info(adapter, hw, adapter->netdev, "Smartspeed has"
+			" downgraded the link speed from the maximum"
+			" advertised\n");
 	return status;
 }
 


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [net-2.6 PATCH] ixgbe: Properly display 1 gig downshift warning for backplane
  2010-04-27 10:37 [net-2.6 PATCH] ixgbe: Properly display 1 gig downshift warning for backplane Jeff Kirsher
@ 2010-04-27 16:54 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-27 16:54 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, anjali.singhai


Not fixing a regression, not fixing a catastropic error, just adding
a warning message.

Therefore not appropriate for net-2.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-27 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-27 10:37 [net-2.6 PATCH] ixgbe: Properly display 1 gig downshift warning for backplane Jeff Kirsher
2010-04-27 16:54 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.