* [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM
@ 2010-04-27 10:26 harald
2010-04-27 17:05 ` Martin Pitt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: harald @ 2010-04-27 10:26 UTC (permalink / raw)
To: linux-hotplug
From: Harald Hoyer <harald@redhat.com>
we cannot be sure for xvd*
---
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--git a/extras/cdrom_id/60-cdrom_id.rules b/extras/cdrom_id/60-cdrom_id.rules
index 16b3af9..b3109f1 100644
--- a/extras/cdrom_id/60-cdrom_id.rules
+++ b/extras/cdrom_id/60-cdrom_id.rules
@@ -5,7 +5,7 @@ SUBSYSTEM!="block", GOTO="cdrom_end"
KERNEL!="sr[0-9]*|xvd*", GOTO="cdrom_end"
ENV{DEVTYPE}!="disk", GOTO="cdrom_end"
-ENV{ID_CDROM}="1"
+KERNEL="sr[0-9]*", ENV{ID_CDROM}="1"
IMPORT{program}="cdrom_id --export $tempnode"
LABEL="cdrom_end"
--
1.7.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM
2010-04-27 10:26 [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM harald
@ 2010-04-27 17:05 ` Martin Pitt
2010-04-29 13:48 ` Kay Sievers
2010-05-04 7:09 ` Martin Pitt
2 siblings, 0 replies; 4+ messages in thread
From: Martin Pitt @ 2010-04-27 17:05 UTC (permalink / raw)
To: linux-hotplug
Hello Harald,
harald@redhat.com [2010-04-27 12:26 +0200]:
> diff --git a/extras/cdrom_id/60-cdrom_id.rules b/extras/cdrom_id/60-cdrom_id.rules
> index 16b3af9..b3109f1 100644
> --- a/extras/cdrom_id/60-cdrom_id.rules
> +++ b/extras/cdrom_id/60-cdrom_id.rules
> @@ -5,7 +5,7 @@ SUBSYSTEM!="block", GOTO="cdrom_end"
> KERNEL!="sr[0-9]*|xvd*", GOTO="cdrom_end"
> ENV{DEVTYPE}!="disk", GOTO="cdrom_end"
>
> -ENV{ID_CDROM}="1"
> +KERNEL="sr[0-9]*", ENV{ID_CDROM}="1"
This would require the distros/platforms (such as some powerpc) which
still use the IDE CD driver to adapt this as well (which shouldn't be
a big deal, but they need to know, since patches to adapt the first
rule might still apply cleanly)
I wonder why we need this at all. cdrom_id already sets ID_CDROM once
it figured out that it is a drive. Was this added for cases where
cdrom_id failed (we recently fixed a ton of bugs in it)? Or for the
case where you build without extras?
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM
2010-04-27 10:26 [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM harald
2010-04-27 17:05 ` Martin Pitt
@ 2010-04-29 13:48 ` Kay Sievers
2010-05-04 7:09 ` Martin Pitt
2 siblings, 0 replies; 4+ messages in thread
From: Kay Sievers @ 2010-04-29 13:48 UTC (permalink / raw)
To: linux-hotplug
On Tue, Apr 27, 2010 at 19:05, Martin Pitt <martin.pitt@ubuntu.com> wrote:
> harald@redhat.com [2010-04-27 12:26 +0200]:
>> diff --git a/extras/cdrom_id/60-cdrom_id.rules b/extras/cdrom_id/60-cdrom_id.rules
>> index 16b3af9..b3109f1 100644
>> --- a/extras/cdrom_id/60-cdrom_id.rules
>> +++ b/extras/cdrom_id/60-cdrom_id.rules
>> @@ -5,7 +5,7 @@ SUBSYSTEM!="block", GOTO="cdrom_end"
>> KERNEL!="sr[0-9]*|xvd*", GOTO="cdrom_end"
>> ENV{DEVTYPE}!="disk", GOTO="cdrom_end"
>>
>> -ENV{ID_CDROM}="1"
>> +KERNEL="sr[0-9]*", ENV{ID_CDROM}="1"
>
> This would require the distros/platforms (such as some powerpc) which
> still use the IDE CD driver to adapt this as well (which shouldn't be
> a big deal.
Yeah, and they need to patch moer than this rule. All the persistent
namning stuff does no longer match hd* too.
> I wonder why we need this at all. cdrom_id already sets ID_CDROM once
> it figured out that it is a drive. Was this added for cases where
> cdrom_id failed (we recently fixed a ton of bugs in it)? Or for the
> case where you build without extras?
We do O_ECXL now, which means we could validly fail to open the device
while handling an event, and would never set ID_CDROM, even when we
can be sure we have one.
The result is that we remove all /dev/cdrom, ... links with the same
event, which isn't what we want, and therefore just set it when the
kernel device matches and we know we can expect one.
Kay
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM
2010-04-27 10:26 [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM harald
2010-04-27 17:05 ` Martin Pitt
2010-04-29 13:48 ` Kay Sievers
@ 2010-05-04 7:09 ` Martin Pitt
2 siblings, 0 replies; 4+ messages in thread
From: Martin Pitt @ 2010-05-04 7:09 UTC (permalink / raw)
To: linux-hotplug
Hello Harald,
harald@redhat.com [2010-04-27 12:26 +0200]:
> From: Harald Hoyer <harald@redhat.com>
>
> we cannot be sure for xvd*
Thanks! Applied.
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-04 7:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-27 10:26 [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM harald
2010-04-27 17:05 ` Martin Pitt
2010-04-29 13:48 ` Kay Sievers
2010-05-04 7:09 ` Martin Pitt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.