All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
@ 2010-04-27  6:57 Jassi Brar
  2010-05-05 14:30 ` Mark Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Jassi Brar @ 2010-04-27  6:57 UTC (permalink / raw)
  To: alsa-devel; +Cc: broonie, Jassi Brar, ben-linux, lrg

Add the CPU driver for the IISv4 block found on S3C6410.
For now, the driver is almost a copy of s3c64xx-i2s.c but
it should diverge as more IISv4 specific stuff is added.

Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
 sound/soc/s3c24xx/Kconfig          |    5 +
 sound/soc/s3c24xx/Makefile         |    2 +
 sound/soc/s3c24xx/s3c64xx-i2s-v4.c |  209 ++++++++++++++++++++++++++++++++++++
 sound/soc/s3c24xx/s3c64xx-i2s.h    |    1 +
 4 files changed, 217 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/s3c24xx/s3c64xx-i2s-v4.c

diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig
index 15fe57e..c0c7edf 100644
--- a/sound/soc/s3c24xx/Kconfig
+++ b/sound/soc/s3c24xx/Kconfig
@@ -24,6 +24,11 @@ config SND_S3C64XX_SOC_I2S
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA
 
+config SND_S3C64XX_SOC_I2S_V4
+	tristate
+	select SND_S3C_I2SV2_SOC
+	select S3C64XX_DMA
+
 config SND_S3C_SOC_PCM
 	tristate
 
diff --git a/sound/soc/s3c24xx/Makefile b/sound/soc/s3c24xx/Makefile
index df071a3..81d8dc5 100644
--- a/sound/soc/s3c24xx/Makefile
+++ b/sound/soc/s3c24xx/Makefile
@@ -4,6 +4,7 @@ snd-soc-s3c24xx-i2s-objs := s3c24xx-i2s.o
 snd-soc-s3c2412-i2s-objs := s3c2412-i2s.o
 snd-soc-s3c64xx-i2s-objs := s3c64xx-i2s.o
 snd-soc-s3c-ac97-objs := s3c-ac97.o
+snd-soc-s3c64xx-i2s-v4-objs := s3c64xx-i2s-v4.o
 snd-soc-s3c-i2s-v2-objs := s3c-i2s-v2.o
 snd-soc-s3c-pcm-objs := s3c-pcm.o
 
@@ -12,6 +13,7 @@ obj-$(CONFIG_SND_S3C24XX_SOC_I2S) += snd-soc-s3c24xx-i2s.o
 obj-$(CONFIG_SND_S3C_SOC_AC97) += snd-soc-s3c-ac97.o
 obj-$(CONFIG_SND_S3C2412_SOC_I2S) += snd-soc-s3c2412-i2s.o
 obj-$(CONFIG_SND_S3C64XX_SOC_I2S) += snd-soc-s3c64xx-i2s.o
+obj-$(CONFIG_SND_S3C64XX_SOC_I2S_V4) += snd-soc-s3c64xx-i2s-v4.o
 obj-$(CONFIG_SND_S3C_I2SV2_SOC) += snd-soc-s3c-i2s-v2.o
 obj-$(CONFIG_SND_S3C_SOC_PCM) += snd-soc-s3c-pcm.o
 
diff --git a/sound/soc/s3c24xx/s3c64xx-i2s-v4.c b/sound/soc/s3c24xx/s3c64xx-i2s-v4.c
new file mode 100644
index 0000000..06db130
--- /dev/null
+++ b/sound/soc/s3c24xx/s3c64xx-i2s-v4.c
@@ -0,0 +1,209 @@
+/* sound/soc/s3c24xx/s3c64xx-i2s-v4.c
+ *
+ * ALSA SoC Audio Layer - S3C64XX I2Sv4 driver
+ * Copyright (c) 2010 Samsung Electronics Co. Ltd
+ * 	Author: Jaswinder Singh <jassi.brar@samsung.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/clk.h>
+#include <linux/gpio.h>
+#include <linux/io.h>
+
+#include <sound/soc.h>
+#include <sound/pcm_params.h>
+
+#include <mach/gpio-bank-c.h>
+#include <mach/gpio-bank-h.h>
+#include <plat/gpio-cfg.h>
+
+#include <mach/map.h>
+#include <mach/dma.h>
+
+#include "s3c-dma.h"
+#include "regs-i2s-v2.h"
+#include "s3c64xx-i2s.h"
+
+static struct s3c2410_dma_client s3c64xx_dma_client_out = {
+	.name		= "I2Sv4 PCM Stereo out"
+};
+
+static struct s3c2410_dma_client s3c64xx_dma_client_in = {
+	.name		= "I2Sv4 PCM Stereo in"
+};
+
+static struct s3c_dma_params s3c64xx_i2sv4_pcm_stereo_out;
+static struct s3c_dma_params s3c64xx_i2sv4_pcm_stereo_in;
+static struct s3c_i2sv2_info s3c64xx_i2sv4;
+
+struct snd_soc_dai s3c64xx_i2s_v4_dai;
+EXPORT_SYMBOL_GPL(s3c64xx_i2s_v4_dai);
+
+static inline struct s3c_i2sv2_info *to_info(struct snd_soc_dai *cpu_dai)
+{
+	return cpu_dai->private_data;
+}
+
+static int s3c64xx_i2sv4_probe(struct platform_device *pdev,
+			     struct snd_soc_dai *dai)
+{
+	/* configure GPIO for i2s port */
+	s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C64XX_GPC4_I2S_V40_DO0);
+	s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C64XX_GPC5_I2S_V40_DO1);
+	s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C64XX_GPC7_I2S_V40_DO2);
+	s3c_gpio_cfgpin(S3C64XX_GPH(6), S3C64XX_GPH6_I2S_V40_BCLK);
+	s3c_gpio_cfgpin(S3C64XX_GPH(7), S3C64XX_GPH7_I2S_V40_CDCLK);
+	s3c_gpio_cfgpin(S3C64XX_GPH(8), S3C64XX_GPH8_I2S_V40_LRCLK);
+	s3c_gpio_cfgpin(S3C64XX_GPH(9), S3C64XX_GPH9_I2S_V40_DI);
+
+	return 0;
+}
+
+static int s3c_i2sv4_hw_params(struct snd_pcm_substream *substream,
+				 struct snd_pcm_hw_params *params,
+				 struct snd_soc_dai *cpu_dai)
+{
+	struct s3c_i2sv2_info *i2s = to_info(cpu_dai);
+	struct s3c_dma_params *dma_data;
+	u32 iismod;
+
+	dev_dbg(cpu_dai->dev, "Entered %s\n", __func__);
+
+	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+		dma_data = i2s->dma_playback;
+	else
+		dma_data = i2s->dma_capture;
+
+	snd_soc_dai_set_dma_data(cpu_dai, substream, dma_data);
+
+	iismod = readl(i2s->regs + S3C2412_IISMOD);
+	dev_dbg(cpu_dai->dev, "%s: r: IISMOD: %x\n", __func__, iismod);
+
+	iismod &= ~S3C64XX_IISMOD_BLC_MASK;
+	switch (params_format(params)) {
+	case SNDRV_PCM_FORMAT_S8:
+		iismod |= S3C64XX_IISMOD_BLC_8BIT;
+		break;
+	case SNDRV_PCM_FORMAT_S16_LE:
+		break;
+	case SNDRV_PCM_FORMAT_S24_LE:
+		iismod |= S3C64XX_IISMOD_BLC_24BIT;
+		break;
+	}
+
+	writel(iismod, i2s->regs + S3C2412_IISMOD);
+	dev_dbg(cpu_dai->dev, "%s: w: IISMOD: %x\n", __func__, iismod);
+
+	return 0;
+}
+
+static struct snd_soc_dai_ops s3c64xx_i2sv4_dai_ops = {
+	.hw_params	= s3c_i2sv4_hw_params,
+};
+
+static __devinit int s3c64xx_i2sv4_dev_probe(struct platform_device *pdev)
+{
+	struct s3c_i2sv2_info *i2s;
+	struct snd_soc_dai *dai;
+	int ret;
+
+	i2s = &s3c64xx_i2sv4;
+	dai = &s3c64xx_i2s_v4_dai;
+
+	if (dai->dev) {
+		dev_dbg(dai->dev, "%s: \
+			I2Sv4 instance already registered!\n", __func__);
+		return -EBUSY;
+	}
+
+	dai->dev = &pdev->dev;
+	dai->name = "s3c64xx-i2s-v4";
+	dai->id = 0;
+	dai->symmetric_rates = 1;
+	dai->playback.channels_min = 2;
+	dai->playback.channels_max = 2;
+	dai->playback.rates = S3C64XX_I2S_RATES;
+	dai->playback.formats = S3C64XX_I2S_FMTS;
+	dai->capture.channels_min = 2;
+	dai->capture.channels_max = 2;
+	dai->capture.rates = S3C64XX_I2S_RATES;
+	dai->capture.formats = S3C64XX_I2S_FMTS;
+	dai->probe = s3c64xx_i2sv4_probe;
+	dai->ops = &s3c64xx_i2sv4_dai_ops;
+
+	i2s->feature |= S3C_FEATURE_CDCLKCON;
+
+	i2s->dma_capture = &s3c64xx_i2sv4_pcm_stereo_in;
+	i2s->dma_playback = &s3c64xx_i2sv4_pcm_stereo_out;
+
+	i2s->dma_capture->channel = DMACH_HSI_I2SV40_RX;
+	i2s->dma_capture->dma_addr = S3C64XX_PA_IISV4 + S3C2412_IISRXD;
+	i2s->dma_playback->channel = DMACH_HSI_I2SV40_TX;
+	i2s->dma_playback->dma_addr = S3C64XX_PA_IISV4 + S3C2412_IISTXD;
+
+	i2s->dma_capture->client = &s3c64xx_dma_client_in;
+	i2s->dma_capture->dma_size = 4;
+	i2s->dma_playback->client = &s3c64xx_dma_client_out;
+	i2s->dma_playback->dma_size = 4;
+
+	i2s->iis_cclk = clk_get(&pdev->dev, "audio-bus");
+	if (IS_ERR(i2s->iis_cclk)) {
+		dev_err(&pdev->dev, "failed to get audio-bus\n");
+		ret = PTR_ERR(i2s->iis_cclk);
+		goto err;
+	}
+
+	clk_enable(i2s->iis_cclk);
+
+	ret = s3c_i2sv2_probe(pdev, dai, i2s, 0);
+	if (ret)
+		goto err_clk;
+
+	ret = s3c_i2sv2_register_dai(dai);
+	if (ret != 0)
+		goto err_i2sv2;
+
+	return 0;
+
+err_i2sv2:
+	/* Not implemented for I2Sv2 core yet */
+err_clk:
+	clk_put(i2s->iis_cclk);
+err:
+	return ret;
+}
+
+static __devexit int s3c64xx_i2sv4_dev_remove(struct platform_device *pdev)
+{
+	dev_err(&pdev->dev, "Device removal not yet supported\n");
+	return 0;
+}
+
+static struct platform_driver s3c64xx_i2sv4_driver = {
+	.probe  = s3c64xx_i2sv4_dev_probe,
+	.remove = s3c64xx_i2sv4_dev_remove,
+	.driver = {
+		.name = "s3c64xx-iis-v4",
+		.owner = THIS_MODULE,
+	},
+};
+
+static int __init s3c64xx_i2sv4_init(void)
+{
+	return platform_driver_register(&s3c64xx_i2sv4_driver);
+}
+module_init(s3c64xx_i2sv4_init);
+
+static void __exit s3c64xx_i2sv4_exit(void)
+{
+	platform_driver_unregister(&s3c64xx_i2sv4_driver);
+}
+module_exit(s3c64xx_i2sv4_exit);
+
+/* Module information */
+MODULE_AUTHOR("Jaswinder Singh, <jassi.brar@samsung.com>");
+MODULE_DESCRIPTION("S3C64XX I2Sv4 SoC Interface");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.h b/sound/soc/s3c24xx/s3c64xx-i2s.h
index f27ed50..7a40f43 100644
--- a/sound/soc/s3c24xx/s3c64xx-i2s.h
+++ b/sound/soc/s3c24xx/s3c64xx-i2s.h
@@ -37,5 +37,6 @@ struct clk;
 	 SNDRV_PCM_FMTBIT_S24_LE)
 
 extern struct snd_soc_dai s3c64xx_i2s_dai[];
+extern struct snd_soc_dai s3c64xx_i2s_v4_dai;
 
 #endif /* __SND_SOC_S3C24XX_S3C64XX_I2S_H */
-- 
1.6.2.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
  2010-04-27  6:57 [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver Jassi Brar
@ 2010-05-05 14:30 ` Mark Brown
  2010-05-07  1:33   ` jassi brar
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-05-05 14:30 UTC (permalink / raw)
  To: Jassi Brar; +Cc: alsa-devel, ben-linux, lrg

On Tue, Apr 27, 2010 at 03:57:11PM +0900, Jassi Brar wrote:
> Add the CPU driver for the IISv4 block found on S3C6410.
> For now, the driver is almost a copy of s3c64xx-i2s.c but
> it should diverge as more IISv4 specific stuff is added.
> 
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>

Actually, this is the first patch that seems to have an issue so I've
applied the patches up till this point.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
  2010-05-05 14:30 ` Mark Brown
@ 2010-05-07  1:33   ` jassi brar
  2010-05-07 10:22     ` Mark Brown
  2010-05-07 16:44     ` Mark Brown
  0 siblings, 2 replies; 6+ messages in thread
From: jassi brar @ 2010-05-07  1:33 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, ben-linux, Jassi Brar, lrg

On Wed, May 5, 2010 at 11:30 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Apr 27, 2010 at 03:57:11PM +0900, Jassi Brar wrote:
>> Add the CPU driver for the IISv4 block found on S3C6410.
>> For now, the driver is almost a copy of s3c64xx-i2s.c but
>> it should diverge as more IISv4 specific stuff is added.
>>
>> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
>
> Actually, this is the first patch that seems to have an issue so I've
> applied the patches up till this point.
That is strange, because I am able to cleanly apply these 11 patches
against commit  cb7cf44c880aeb8caf8 of for-2.6.35
Could you please try again?
Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
  2010-05-07  1:33   ` jassi brar
@ 2010-05-07 10:22     ` Mark Brown
  2010-05-07 16:44     ` Mark Brown
  1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-05-07 10:22 UTC (permalink / raw)
  To: jassi brar; +Cc: alsa-devel, Jassi Brar, ben-linux, lrg

On Fri, May 07, 2010 at 10:33:39AM +0900, jassi brar wrote:
> On Wed, May 5, 2010 at 11:30 PM, Mark Brown

> > Actually, this is the first patch that seems to have an issue so I've
> > applied the patches up till this point.

> That is strange, because I am able to cleanly apply these 11 patches
> against commit  cb7cf44c880aeb8caf8 of for-2.6.35
> Could you please try again?

I did try several times, including using a three way merge.  It's
possible some damage was introduced in the mail path (though it'd be a
bit odd given that everything else might work) so a simple resend might
do the trick?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
  2010-05-07  1:33   ` jassi brar
  2010-05-07 10:22     ` Mark Brown
@ 2010-05-07 16:44     ` Mark Brown
  2010-05-10  6:29       ` jassi brar
  1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-05-07 16:44 UTC (permalink / raw)
  To: jassi brar; +Cc: alsa-devel, ben-linux, Jassi Brar, lrg

On Fri, May 07, 2010 at 10:33:39AM +0900, jassi brar wrote:

> That is strange, because I am able to cleanly apply these 11 patches
> against commit  cb7cf44c880aeb8caf8 of for-2.6.35
> Could you please try again?

I had another poke at this and managed to get the last two applied,
thanks.  However, the audio-bus clock for the IISv4 block on the S3C6410
is still not set up in -next.  If that doesn't get sorted out it might
be as well to mark it BROKEN again since it can't actually be used.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver
  2010-05-07 16:44     ` Mark Brown
@ 2010-05-10  6:29       ` jassi brar
  0 siblings, 0 replies; 6+ messages in thread
From: jassi brar @ 2010-05-10  6:29 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, ben-linux, Jassi Brar, lrg

On Sat, May 8, 2010 at 1:44 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, May 07, 2010 at 10:33:39AM +0900, jassi brar wrote:
>
>> That is strange, because I am able to cleanly apply these 11 patches
>> against commit  cb7cf44c880aeb8caf8 of for-2.6.35
>> Could you please try again?
>
> I had another poke at this and managed to get the last two applied,
> thanks.
ok, i waiting to reach workplace to resend.

>  However, the audio-bus clock for the IISv4 block on the S3C6410
> is still not set up in -next.  If that doesn't get sorted out it might
> be as well to mark it BROKEN again since it can't actually be used.
I reminded the patch to Ben, hope it's settled.
But of course, please do as appropriate.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-05-10  6:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-27  6:57 [PATCH 10/11] ASoC: S3C64XX: IISv4: Add CPU driver Jassi Brar
2010-05-05 14:30 ` Mark Brown
2010-05-07  1:33   ` jassi brar
2010-05-07 10:22     ` Mark Brown
2010-05-07 16:44     ` Mark Brown
2010-05-10  6:29       ` jassi brar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.