* [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-01 7:08 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:08 UTC (permalink / raw)
To: Sjur Braendeland; +Cc: netdev, David S. Miller, kernel-janitors
We don't use the "ser" variable so I've removed it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index 09257ca..f30a6a0 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
static int caif_net_open(struct net_device *dev)
{
- struct ser_device *ser;
- ser = netdev_priv(dev);
netif_wake_queue(dev);
return 0;
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-01 7:08 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:08 UTC (permalink / raw)
To: Sjur Braendeland; +Cc: netdev, David S. Miller, kernel-janitors
We don't use the "ser" variable so I've removed it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index 09257ca..f30a6a0 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
static int caif_net_open(struct net_device *dev)
{
- struct ser_device *ser;
- ser = netdev_priv(dev);
netif_wake_queue(dev);
return 0;
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [patch 1/2] caif: remove unneeded variable from caif_net_open()
2010-06-01 7:08 ` Dan Carpenter
@ 2010-06-01 7:19 ` Sjur BRENDELAND
-1 siblings, 0 replies; 10+ messages in thread
From: Sjur BRENDELAND @ 2010-06-01 7:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, David S. Miller, kernel-janitors
Dan Carpenter wrote:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Looks good thanks,
Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-01 7:19 ` Sjur BRENDELAND
0 siblings, 0 replies; 10+ messages in thread
From: Sjur BRENDELAND @ 2010-06-01 7:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, David S. Miller, kernel-janitors
Dan Carpenter wrote:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Looks good thanks,
Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
2010-06-01 7:08 ` Dan Carpenter
@ 2010-06-01 7:27 ` walter harms
-1 siblings, 0 replies; 10+ messages in thread
From: walter harms @ 2010-06-01 7:27 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sjur Braendeland, netdev, David S. Miller, kernel-janitors
Dan Carpenter schrieb:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
> index 09257ca..f30a6a0 100644
> --- a/drivers/net/caif/caif_serial.c
> +++ b/drivers/net/caif/caif_serial.c
> @@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
>
> static int caif_net_open(struct net_device *dev)
> {
> - struct ser_device *ser;
> - ser = netdev_priv(dev);
> netif_wake_queue(dev);
> return 0;
> }
what makes caif_net_open() obsolet ?
re,
wh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-01 7:27 ` walter harms
0 siblings, 0 replies; 10+ messages in thread
From: walter harms @ 2010-06-01 7:27 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sjur Braendeland, netdev, David S. Miller, kernel-janitors
Dan Carpenter schrieb:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
> index 09257ca..f30a6a0 100644
> --- a/drivers/net/caif/caif_serial.c
> +++ b/drivers/net/caif/caif_serial.c
> @@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
>
> static int caif_net_open(struct net_device *dev)
> {
> - struct ser_device *ser;
> - ser = netdev_priv(dev);
> netif_wake_queue(dev);
> return 0;
> }
what makes caif_net_open() obsolet ?
re,
wh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
2010-06-01 7:27 ` walter harms
@ 2010-06-01 7:45 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:45 UTC (permalink / raw)
To: walter harms; +Cc: Sjur Braendeland, netdev, David S. Miller, kernel-janitors
On Tue, Jun 01, 2010 at 09:27:02AM +0200, walter harms wrote:
> > static int caif_net_open(struct net_device *dev)
> > {
> > - struct ser_device *ser;
> > - ser = netdev_priv(dev);
> > netif_wake_queue(dev);
> > return 0;
> > }
>
>
> what makes caif_net_open() obsolet ?
>
No. It has to return an int to match this:
int (*ndo_open)(struct net_device *dev);
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-01 7:45 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:45 UTC (permalink / raw)
To: walter harms; +Cc: Sjur Braendeland, netdev, David S. Miller, kernel-janitors
On Tue, Jun 01, 2010 at 09:27:02AM +0200, walter harms wrote:
> > static int caif_net_open(struct net_device *dev)
> > {
> > - struct ser_device *ser;
> > - ser = netdev_priv(dev);
> > netif_wake_queue(dev);
> > return 0;
> > }
>
>
> what makes caif_net_open() obsolet ?
>
No. It has to return an int to match this:
int (*ndo_open)(struct net_device *dev);
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
2010-06-01 7:08 ` Dan Carpenter
@ 2010-06-02 12:16 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2010-06-02 12:16 UTC (permalink / raw)
To: error27; +Cc: sjur.brandeland, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 1 Jun 2010 09:08:55 +0200
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
@ 2010-06-02 12:16 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2010-06-02 12:16 UTC (permalink / raw)
To: error27; +Cc: sjur.brandeland, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 1 Jun 2010 09:08:55 +0200
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-06-02 12:16 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-01 7:08 [patch 1/2] caif: remove unneeded variable from caif_net_open() Dan Carpenter
2010-06-01 7:08 ` Dan Carpenter
2010-06-01 7:19 ` Sjur BRENDELAND
2010-06-01 7:19 ` Sjur BRENDELAND
2010-06-01 7:27 ` walter harms
2010-06-01 7:27 ` walter harms
2010-06-01 7:45 ` Dan Carpenter
2010-06-01 7:45 ` Dan Carpenter
2010-06-02 12:16 ` David Miller
2010-06-02 12:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.