* [PATCH] ppp: eliminate shadowed variable name
@ 2010-06-01 16:05 Stephen Hemminger
2010-06-02 12:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-06-01 16:05 UTC (permalink / raw)
To: Paul Mackerras, David Miller; +Cc: netdev
Sparse complains about shadowed declaration of skb. So use other
name.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/ppp_generic.c 2010-06-01 08:49:58.859739636 -0700
+++ b/drivers/net/ppp_generic.c 2010-06-01 08:50:41.184870657 -0700
@@ -1927,9 +1927,9 @@ ppp_receive_mp_frame(struct ppp *ppp, st
/* If the queue is getting long, don't wait any longer for packets
before the start of the queue. */
if (skb_queue_len(&ppp->mrq) >= PPP_MP_MAX_QLEN) {
- struct sk_buff *skb = skb_peek(&ppp->mrq);
- if (seq_before(ppp->minseq, skb->sequence))
- ppp->minseq = skb->sequence;
+ struct sk_buff *mskb = skb_peek(&ppp->mrq);
+ if (seq_before(ppp->minseq, mskb->sequence))
+ ppp->minseq = mskb->sequence;
}
/* Pull completed packets off the queue and receive them. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ppp: eliminate shadowed variable name
2010-06-01 16:05 [PATCH] ppp: eliminate shadowed variable name Stephen Hemminger
@ 2010-06-02 12:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-06-02 12:17 UTC (permalink / raw)
To: shemminger; +Cc: paulus, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 1 Jun 2010 09:05:46 -0700
> Sparse complains about shadowed declaration of skb. So use other
> name.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-02 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-01 16:05 [PATCH] ppp: eliminate shadowed variable name Stephen Hemminger
2010-06-02 12:17 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.