From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Nick Piggin <npiggin@suse.de>,
Oleg Nesterov <oleg@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-mm@kvack.org
Subject: Re: [patch -mm 08/18] oom: badness heuristic rewrite
Date: Wed, 2 Jun 2010 22:54:03 +0900 (JST) [thread overview]
Message-ID: <20100602225252.F536.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1006011140110.32024@chino.kir.corp.google.com>
> Why?
>
> If it's because the patch is too big, I've explained a few times that
> functionally you can't break it apart into anything meaningful. I do not
> believe it is better to break functional changes into smaller patches that
> simply change function signatures to pass additional arguments that are
> unused in the first patch, for example.
>
> If it's because it adds /proc/pid/oom_score_adj in the same patch, that's
> allowed since otherwise it would be useless with the old heuristic. In
> other words, you cannot apply oom_score_adj's meaning to the bitshift in
> any sane way.
>
> I'll suggest what I have multiple times: the easiest way to review the
> functional change here is to merge the patch into your own tree and then
> review oom_badness(). I agree that the way the diff comes out it is a
> little difficult to read just from the patch form, so merging it and
> reviewing the actual heuristic function is the easiest way.
I've already explained the reason. 1) all-of-rewrite patches are
always unacceptable. that's prevent our code maintainance. 2) no justification
patches are also unacceptable. you need to write more proper patch descriptaion
at least.
We don't need pointless suggestion. you only need to fix the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-02 13:54 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 7:18 [patch -mm 00/18] oom killer rewrite David Rientjes
2010-06-01 7:18 ` [patch -mm 01/18] oom: filter tasks not sharing the same cpuset David Rientjes
2010-06-01 7:20 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:37 ` David Rientjes
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-17 3:33 ` David Rientjes
2010-06-21 11:45 ` KOSAKI Motohiro
2010-06-21 11:45 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:43 ` David Rientjes
2010-06-08 23:25 ` Andrew Morton
2010-06-08 23:54 ` David Rientjes
2010-06-09 0:06 ` Andrew Morton
2010-06-09 1:07 ` David Rientjes
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 02/18] oom: sacrifice child with highest badness score for parent David Rientjes
2010-06-01 7:39 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:41 ` David Rientjes
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-14 8:54 ` David Rientjes
2010-06-14 11:08 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:45 ` David Rientjes
2010-06-01 7:18 ` [patch -mm 03/18] oom: select task from tasklist for mempolicy ooms David Rientjes
2010-06-01 7:39 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 23:28 ` Andrew Morton
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 04/18] oom: extract panic helper function David Rientjes
2010-06-01 7:33 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 05/18] oom: remove special handling for pagefault ooms David Rientjes
2010-06-01 7:34 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 06/18] oom: move sysctl declarations to oom.h David Rientjes
2010-06-01 7:34 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 07/18] oom: enable oom tasklist dump by default David Rientjes
2010-06-01 7:36 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 08/18] oom: badness heuristic rewrite David Rientjes
2010-06-01 7:36 ` KOSAKI Motohiro
2010-06-01 18:44 ` David Rientjes
2010-06-02 13:54 ` KOSAKI Motohiro [this message]
2010-06-02 21:20 ` David Rientjes
2010-06-03 23:10 ` Andrew Morton
2010-06-03 23:53 ` KAMEZAWA Hiroyuki
2010-06-04 0:04 ` Andrew Morton
2010-06-04 0:20 ` KAMEZAWA Hiroyuki
2010-06-04 5:57 ` KAMEZAWA Hiroyuki
2010-06-04 9:22 ` David Rientjes
2010-06-04 9:19 ` David Rientjes
2010-06-04 9:43 ` Oleg Nesterov
2010-06-04 10:54 ` KOSAKI Motohiro
2010-06-04 20:57 ` David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 23:47 ` Andrew Morton
2010-06-17 3:28 ` David Rientjes
2010-06-01 7:46 ` Nick Piggin
2010-06-01 18:56 ` David Rientjes
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 21:23 ` David Rientjes
2010-06-03 0:05 ` KAMEZAWA Hiroyuki
2010-06-03 6:44 ` David Rientjes
2010-06-03 3:07 ` KOSAKI Motohiro
2010-06-03 6:48 ` David Rientjes
2010-06-03 23:15 ` Andrew Morton
2010-06-04 10:54 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 09/18] oom: add forkbomb penalty to badness heuristic David Rientjes
2010-06-01 7:37 ` KOSAKI Motohiro
2010-06-01 18:57 ` David Rientjes
2010-06-03 20:33 ` David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 10/18] oom: deprecate oom_adj tunable David Rientjes
2010-06-01 7:37 ` KOSAKI Motohiro
2010-06-01 7:18 ` [patch -mm 11/18] oom: avoid oom killer for lowmem allocations David Rientjes
2010-06-01 7:38 ` KOSAKI Motohiro
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:38 ` David Rientjes
2010-06-01 7:18 ` [patch -mm 12/18] oom: remove unnecessary code and cleanup David Rientjes
2010-06-01 7:40 ` KOSAKI Motohiro
2010-06-01 18:58 ` David Rientjes
2010-06-01 7:19 ` [patch -mm 13/18] oom: avoid race for oom killed tasks detaching mm prior to exit David Rientjes
2010-06-01 7:40 ` KOSAKI Motohiro
2010-06-01 18:59 ` David Rientjes
2010-06-01 20:43 ` Oleg Nesterov
2010-06-01 21:19 ` David Rientjes
2010-06-02 0:28 ` KAMEZAWA Hiroyuki
2010-06-02 9:49 ` David Rientjes
2010-06-02 10:46 ` Nick Piggin
2010-06-02 21:35 ` David Rientjes
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-01 7:19 ` [patch -mm 14/18] oom: check PF_KTHREAD instead of !mm to skip kthreads David Rientjes
2010-06-01 7:41 ` KOSAKI Motohiro
2010-06-01 7:19 ` [patch -mm 15/18] oom: introduce find_lock_task_mm() to fix !mm false positives David Rientjes
2010-06-01 7:41 ` KOSAKI Motohiro
2010-06-01 7:19 ` [patch -mm 16/18] oom: give current access to memory reserves if it has been killed David Rientjes
2010-06-01 7:44 ` KOSAKI Motohiro
2010-06-01 7:19 ` [patch -mm 17/18] oom: avoid sending exiting tasks a SIGKILL David Rientjes
2010-06-01 7:19 ` [patch -mm 18/18] oom: clean up oom_kill_task() David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602225252.F536.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.