* [PATCH 0/5] Series short description @ 2010-06-07 4:11 Bruno Randolf 2010-06-07 4:11 ` [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration Bruno Randolf ` (4 more replies) 0 siblings, 5 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless here i resend the missing ath5k patches rebased against current wireless-testing. bruno --- Bruno Randolf (5): ath5k: fix NULL pointer in antenna configuration ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks ath5k: new function for setting the antenna switch table ath5k: no need to save/restore the default antenna ath5k: add debugfs file for queue debugging drivers/net/wireless/ath/ath5k/ath5k.h | 1 drivers/net/wireless/ath/ath5k/debug.c | 73 ++++++++++++++++++++++++++++++++ drivers/net/wireless/ath/ath5k/debug.h | 1 drivers/net/wireless/ath/ath5k/phy.c | 43 ++++++++++++++++++- drivers/net/wireless/ath/ath5k/reset.c | 41 +++--------------- 5 files changed, 123 insertions(+), 36 deletions(-) -- Signature ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf @ 2010-06-07 4:11 ` Bruno Randolf 2010-06-07 4:11 ` [PATCH 2/5] ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks Bruno Randolf ` (3 subsequent siblings) 4 siblings, 0 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless If the channel is not set yet and we configure the antennas just store the setting. It will be activated during the next reset, when the channel is set. Signed-off-by: Bruno Randolf <br1@einfach.org> --- drivers/net/wireless/ath/ath5k/phy.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index 2b3f7a7..34ba576 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1793,6 +1793,13 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) u8 def_ant, tx_ant, ee_mode; u32 sta_id1 = 0; + /* if channel is not initialized yet we can't set the antennas + * so just store the mode. it will be set on the next reset */ + if (channel == NULL) { + ah->ah_ant_mode = ant_mode; + return; + } + def_ant = ah->ah_def_ant; switch (channel->hw_value & CHANNEL_MODES) { ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/5] ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf 2010-06-07 4:11 ` [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration Bruno Randolf @ 2010-06-07 4:11 ` Bruno Randolf 2010-06-07 4:11 ` [PATCH 3/5] ath5k: new function for setting the antenna switch table Bruno Randolf ` (2 subsequent siblings) 4 siblings, 0 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless #define AR5K_PHY_RESTART_DIV_GC 0x001c0000 is 3 bit wide. The previous values of 0xc and 0x8 are 4bit wide and bigger than the mask. Writing 0 and 1 to AR5K_PHY_RESTART_DIV_GC is consistent with the comments and initvals we have in the HAL. Signed-off-by: Bruno Randolf <br1@einfach.org> --- drivers/net/wireless/ath/ath5k/phy.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index 34ba576..0f3b9be 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1768,13 +1768,13 @@ ath5k_hw_set_fast_div(struct ath5k_hw *ah, u8 ee_mode, bool enable) if (enable) { AR5K_REG_WRITE_BITS(ah, AR5K_PHY_RESTART, - AR5K_PHY_RESTART_DIV_GC, 0xc); + AR5K_PHY_RESTART_DIV_GC, 1); AR5K_REG_ENABLE_BITS(ah, AR5K_PHY_FAST_ANT_DIV, AR5K_PHY_FAST_ANT_DIV_EN); } else { AR5K_REG_WRITE_BITS(ah, AR5K_PHY_RESTART, - AR5K_PHY_RESTART_DIV_GC, 0x8); + AR5K_PHY_RESTART_DIV_GC, 0); AR5K_REG_DISABLE_BITS(ah, AR5K_PHY_FAST_ANT_DIV, AR5K_PHY_FAST_ANT_DIV_EN); ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/5] ath5k: new function for setting the antenna switch table 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf 2010-06-07 4:11 ` [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration Bruno Randolf 2010-06-07 4:11 ` [PATCH 2/5] ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks Bruno Randolf @ 2010-06-07 4:11 ` Bruno Randolf 2010-06-07 4:11 ` [PATCH 4/5] ath5k: no need to save/restore the default antenna Bruno Randolf 2010-06-07 4:11 ` [PATCH 5/5] ath5k: add debugfs file for queue debugging Bruno Randolf 4 siblings, 0 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless Collect all pieces concering the antenna switch table into one function. Previously it was split up between ath5k_hw_reset() and ath5k_hw_commit_eeprom_settings(). Also we need to set the antenna switch table when ath5k_hw_set_antenna_mode() is called manually (by "iw phy0 antenna set", for example). I'm not sure if we need to set the switchtable at the same place in ath5k_hw_reset() as it was before - it is set later thru ath5k_hw_set_antenna_mode() anyways - but i leave it there to avoid problems(?). Plus print switchtable registers in the debugfs file. Signed-off-by: Bruno Randolf <br1@einfach.org> --- drivers/net/wireless/ath/ath5k/ath5k.h | 1 + drivers/net/wireless/ath/ath5k/debug.c | 7 +++++++ drivers/net/wireless/ath/ath5k/phy.c | 32 +++++++++++++++++++++++++++++++ drivers/net/wireless/ath/ath5k/reset.c | 33 ++++++-------------------------- 4 files changed, 46 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h index eace74d..cf16318 100644 --- a/drivers/net/wireless/ath/ath5k/ath5k.h +++ b/drivers/net/wireless/ath/ath5k/ath5k.h @@ -1286,6 +1286,7 @@ u16 ath5k_hw_radio_revision(struct ath5k_hw *ah, unsigned int chan); int ath5k_hw_phy_disable(struct ath5k_hw *ah); /* Antenna control */ void ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode); +void ath5k_hw_set_antenna_switch(struct ath5k_hw *ah, u8 ee_mode); /* TX power setup */ int ath5k_hw_txpower(struct ath5k_hw *ah, struct ieee80211_channel *channel, u8 ee_mode, u8 txpower); diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index c58503c..41817a2 100644 --- a/drivers/net/wireless/ath/ath5k/debug.c +++ b/drivers/net/wireless/ath/ath5k/debug.c @@ -425,6 +425,13 @@ static ssize_t read_file_antenna(struct file *file, char __user *user_buf, "AR5K_PHY_FAST_ANT_DIV_EN\t%d\n", (v & AR5K_PHY_FAST_ANT_DIV_EN) != 0); + v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_0); + len += snprintf(buf+len, sizeof(buf)-len, + "\nAR5K_PHY_ANT_SWITCH_TABLE_0\t0x%08x\n", v); + v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_1); + len += snprintf(buf+len, sizeof(buf)-len, + "AR5K_PHY_ANT_SWITCH_TABLE_1\t0x%08x\n", v); + return simple_read_from_buffer(user_buf, count, ppos, buf, len); } diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index 0f3b9be..73c4fcd 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1781,6 +1781,37 @@ ath5k_hw_set_fast_div(struct ath5k_hw *ah, u8 ee_mode, bool enable) } } +void +ath5k_hw_set_antenna_switch(struct ath5k_hw *ah, u8 ee_mode) +{ + u8 ant0, ant1; + + /* + * In case a fixed antenna was set as default + * use the same switch table twice. + */ + if (ah->ah_ant_mode == AR5K_ANTMODE_FIXED_A) + ant0 = ant1 = AR5K_ANT_SWTABLE_A; + else if (ah->ah_ant_mode == AR5K_ANTMODE_FIXED_B) + ant0 = ant1 = AR5K_ANT_SWTABLE_B; + else { + ant0 = AR5K_ANT_SWTABLE_A; + ant1 = AR5K_ANT_SWTABLE_B; + } + + /* Set antenna idle switch table */ + AR5K_REG_WRITE_BITS(ah, AR5K_PHY_ANT_CTL, + AR5K_PHY_ANT_CTL_SWTABLE_IDLE, + (ah->ah_ant_ctl[ee_mode][AR5K_ANT_CTL] | + AR5K_PHY_ANT_CTL_TXRX_EN)); + + /* Set antenna switch tables */ + ath5k_hw_reg_write(ah, ah->ah_ant_ctl[ee_mode][ant0], + AR5K_PHY_ANT_SWITCH_TABLE_0); + ath5k_hw_reg_write(ah, ah->ah_ant_ctl[ee_mode][ant1], + AR5K_PHY_ANT_SWITCH_TABLE_1); +} + /* * Set antenna operating mode */ @@ -1900,6 +1931,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) if (sta_id1) AR5K_REG_ENABLE_BITS(ah, AR5K_STA_ID1, sta_id1); + ath5k_hw_set_antenna_switch(ah, ee_mode); /* Note: set diversity before default antenna * because it won't work correctly */ ath5k_hw_set_fast_div(ah, ee_mode, fast_div); diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c index c17c84e..d561f7c 100644 --- a/drivers/net/wireless/ath/ath5k/reset.c +++ b/drivers/net/wireless/ath/ath5k/reset.c @@ -729,7 +729,7 @@ static void ath5k_hw_tweak_initval_settings(struct ath5k_hw *ah, } static void ath5k_hw_commit_eeprom_settings(struct ath5k_hw *ah, - struct ieee80211_channel *channel, u8 *ant, u8 ee_mode) + struct ieee80211_channel *channel, u8 ee_mode) { struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; s16 cck_ofdm_pwr_delta; @@ -763,17 +763,9 @@ static void ath5k_hw_commit_eeprom_settings(struct ath5k_hw *ah, ee->ee_cck_ofdm_gain_delta; } - /* Set antenna idle switch table */ - AR5K_REG_WRITE_BITS(ah, AR5K_PHY_ANT_CTL, - AR5K_PHY_ANT_CTL_SWTABLE_IDLE, - (ah->ah_ant_ctl[ee_mode][0] | - AR5K_PHY_ANT_CTL_TXRX_EN)); - - /* Set antenna switch tables */ - ath5k_hw_reg_write(ah, ah->ah_ant_ctl[ee_mode][ant[0]], - AR5K_PHY_ANT_SWITCH_TABLE_0); - ath5k_hw_reg_write(ah, ah->ah_ant_ctl[ee_mode][ant[1]], - AR5K_PHY_ANT_SWITCH_TABLE_1); + /* XXX: necessary here? is called from ath5k_hw_set_antenna_mode() + * too */ + ath5k_hw_set_antenna_switch(ah, ee_mode); /* Noise floor threshold */ ath5k_hw_reg_write(ah, @@ -887,7 +879,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, struct ath_common *common = ath5k_hw_common(ah); u32 s_seq[10], s_ant, s_led[3], staid1_flags, tsf_up, tsf_lo; u32 phy_tst1; - u8 mode, freq, ee_mode, ant[2]; + u8 mode, freq, ee_mode; int i, ret; s_ant = 0; @@ -1110,21 +1102,8 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, AR5K_TXCFG_B_MODE); } - /* - * In case a fixed antenna was set as default - * use the same switch table twice. - */ - if (ah->ah_ant_mode == AR5K_ANTMODE_FIXED_A) - ant[0] = ant[1] = AR5K_ANT_SWTABLE_A; - else if (ah->ah_ant_mode == AR5K_ANTMODE_FIXED_B) - ant[0] = ant[1] = AR5K_ANT_SWTABLE_B; - else { - ant[0] = AR5K_ANT_SWTABLE_A; - ant[1] = AR5K_ANT_SWTABLE_B; - } - /* Commit values from EEPROM */ - ath5k_hw_commit_eeprom_settings(ah, channel, ant, ee_mode); + ath5k_hw_commit_eeprom_settings(ah, channel, ee_mode); } else { /* ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/5] ath5k: no need to save/restore the default antenna 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf ` (2 preceding siblings ...) 2010-06-07 4:11 ` [PATCH 3/5] ath5k: new function for setting the antenna switch table Bruno Randolf @ 2010-06-07 4:11 ` Bruno Randolf 2010-06-07 4:11 ` [PATCH 5/5] ath5k: add debugfs file for queue debugging Bruno Randolf 4 siblings, 0 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless Since ath5k_hw_set_antenna_mode() always writes the default antenna register and is called at the end of reset, there is no need to separately save and restore the default antenna. Signed-off-by: Bruno Randolf <br1@einfach.org> --- drivers/net/wireless/ath/ath5k/reset.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c index d561f7c..498aa28 100644 --- a/drivers/net/wireless/ath/ath5k/reset.c +++ b/drivers/net/wireless/ath/ath5k/reset.c @@ -877,12 +877,11 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, struct ieee80211_channel *channel, bool change_channel) { struct ath_common *common = ath5k_hw_common(ah); - u32 s_seq[10], s_ant, s_led[3], staid1_flags, tsf_up, tsf_lo; + u32 s_seq[10], s_led[3], staid1_flags, tsf_up, tsf_lo; u32 phy_tst1; u8 mode, freq, ee_mode; int i, ret; - s_ant = 0; ee_mode = 0; staid1_flags = 0; tsf_up = 0; @@ -979,9 +978,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, } } - /* Save default antenna */ - s_ant = ath5k_hw_reg_read(ah, AR5K_DEFAULT_ANTENNA); - if (ah->ah_version == AR5K_AR5212) { /* Restore normal 32/40MHz clock operation * to avoid register access delay on certain @@ -1141,8 +1137,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, ath5k_hw_reg_write(ah, tsf_lo, AR5K_TSF_L32); } } - - ath5k_hw_reg_write(ah, s_ant, AR5K_DEFAULT_ANTENNA); } /* Ledstate */ ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/5] ath5k: add debugfs file for queue debugging 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf ` (3 preceding siblings ...) 2010-06-07 4:11 ` [PATCH 4/5] ath5k: no need to save/restore the default antenna Bruno Randolf @ 2010-06-07 4:11 ` Bruno Randolf 4 siblings, 0 replies; 17+ messages in thread From: Bruno Randolf @ 2010-06-07 4:11 UTC (permalink / raw) To: linville; +Cc: ath5k-devel, linux-wireless Signed-off-by: Bruno Randolf <br1@einfach.org> --- drivers/net/wireless/ath/ath5k/debug.c | 66 ++++++++++++++++++++++++++++++++ drivers/net/wireless/ath/ath5k/debug.h | 1 2 files changed, 67 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index 41817a2..0f2e37d 100644 --- a/drivers/net/wireless/ath/ath5k/debug.c +++ b/drivers/net/wireless/ath/ath5k/debug.c @@ -735,6 +735,66 @@ static const struct file_operations fops_ani = { }; +/* debugfs: queues etc */ + +static ssize_t read_file_queue(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct ath5k_softc *sc = file->private_data; + char buf[700]; + unsigned int len = 0; + + struct ath5k_txq *txq; + struct ath5k_buf *bf, *bf0; + int i, n = 0; + + len += snprintf(buf+len, sizeof(buf)-len, + "available txbuffers: %d\n", sc->txbuf_len); + + for (i = 0; i < ARRAY_SIZE(sc->txqs); i++) { + txq = &sc->txqs[i]; + + len += snprintf(buf+len, sizeof(buf)-len, + "%02d: %ssetup\n", i, txq->setup ? "" : "not "); + + if (!txq->setup) + continue; + + list_for_each_entry_safe(bf, bf0, &txq->q, list) + n++; + len += snprintf(buf+len, sizeof(buf)-len, " len: %d\n", n); + } + + return simple_read_from_buffer(user_buf, count, ppos, buf, len); +} + +static ssize_t write_file_queue(struct file *file, + const char __user *userbuf, + size_t count, loff_t *ppos) +{ + struct ath5k_softc *sc = file->private_data; + char buf[20]; + + if (copy_from_user(buf, userbuf, min(count, sizeof(buf)))) + return -EFAULT; + + if (strncmp(buf, "start", 5) == 0) + ieee80211_wake_queues(sc->hw); + else if (strncmp(buf, "stop", 4) == 0) + ieee80211_stop_queues(sc->hw); + + return count; +} + + +static const struct file_operations fops_queue = { + .read = read_file_queue, + .write = write_file_queue, + .open = ath5k_debugfs_open, + .owner = THIS_MODULE, +}; + + /* init */ void @@ -778,6 +838,11 @@ ath5k_debug_init_device(struct ath5k_softc *sc) S_IWUSR | S_IRUSR, sc->debug.debugfs_phydir, sc, &fops_ani); + + sc->debug.debugfs_queue = debugfs_create_file("queue", + S_IWUSR | S_IRUSR, + sc->debug.debugfs_phydir, sc, + &fops_queue); } void @@ -796,6 +861,7 @@ ath5k_debug_finish_device(struct ath5k_softc *sc) debugfs_remove(sc->debug.debugfs_antenna); debugfs_remove(sc->debug.debugfs_frameerrors); debugfs_remove(sc->debug.debugfs_ani); + debugfs_remove(sc->debug.debugfs_queue); debugfs_remove(sc->debug.debugfs_phydir); } diff --git a/drivers/net/wireless/ath/ath5k/debug.h b/drivers/net/wireless/ath/ath5k/debug.h index bd16587..606ae94 100644 --- a/drivers/net/wireless/ath/ath5k/debug.h +++ b/drivers/net/wireless/ath/ath5k/debug.h @@ -77,6 +77,7 @@ struct ath5k_dbg_info { struct dentry *debugfs_antenna; struct dentry *debugfs_frameerrors; struct dentry *debugfs_ani; + struct dentry *debugfs_queue; }; /** ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2021-12-06 5:43 Masami Hiramatsu 2021-12-06 7:49 ` Masami Hiramatsu 0 siblings, 1 reply; 17+ messages in thread From: Masami Hiramatsu @ 2021-12-06 5:43 UTC (permalink / raw) To: Lukasz Majewski; +Cc: u-boot, ilias.apalodimas, sughosh.ganu, jaswinder.singh Hi, This series is improving DFU subsystem. This improves dfu_alt_info parser and fixing documents etc. When I was debuging my patch for updating dfu_alt_info on the DeveloperBox platform, I found that dfu_alt_info parser doesn't accept redundant spaces and tabs. Also the dfu.rst description seems wrong. Moreover, there is no way to check whether the parser parses the dfu_alt_info correctly. These patches fixes such issues. [1/5] is just for avoiding buffer overrun, [2/5] and [3/5] improves dfu_alt_info parser to accept redundant spaces and tabs, and check the number of arguments strictly so that the parser (and user) can notice any unexpected parameters. [4/5] fixes the documents (there seems some wrong description maybe coming from copy&paste). [5/5] allows user to run 'dfu list' even if the platform doesn't support DFU_OVER_USB. Thank you, --- Masami Hiramatsu (5): DFU: Do not copy the entity name over the buffer size DFU: Accept redundant spaces and tabs in dfu_alt_info DFU: Check the number of arguments and argument string strictly doc: usage: DFU: Fix dfu_alt_info document cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB cmd/dfu.c | 6 +++-- doc/usage/dfu.rst | 57 ++++++++++++++++++++++++++++++++++-------------- drivers/dfu/dfu.c | 37 ++++++++++++++++++++++++------- drivers/dfu/dfu_mmc.c | 55 +++++++++++++++++++++++++++------------------- drivers/dfu/dfu_mtd.c | 34 +++++++++++++++++++---------- drivers/dfu/dfu_nand.c | 34 ++++++++++++++++++----------- drivers/dfu/dfu_ram.c | 24 ++++++++++---------- drivers/dfu/dfu_sf.c | 34 ++++++++++++++++++----------- drivers/dfu/dfu_virt.c | 5 +++- include/dfu.h | 33 ++++++++++++++++++---------- 10 files changed, 205 insertions(+), 114 deletions(-) -- Masami Hiramatsu <masami.hiramatsu@linaro.org> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/5] Series short description 2021-12-06 5:43 [PATCH 0/5] Series short description Masami Hiramatsu @ 2021-12-06 7:49 ` Masami Hiramatsu 0 siblings, 0 replies; 17+ messages in thread From: Masami Hiramatsu @ 2021-12-06 7:49 UTC (permalink / raw) To: Lukasz Majewski; +Cc: u-boot, ilias.apalodimas, sughosh.ganu, jaswinder.singh Sorry, please ignore this mail, i missed to update the subject. Thanks, 2021年12月6日(月) 14:43 Masami Hiramatsu <masami.hiramatsu@linaro.org>: > > Hi, > > This series is improving DFU subsystem. This improves dfu_alt_info > parser and fixing documents etc. > > When I was debuging my patch for updating dfu_alt_info on the > DeveloperBox platform, I found that dfu_alt_info parser doesn't > accept redundant spaces and tabs. Also the dfu.rst description > seems wrong. Moreover, there is no way to check whether the > parser parses the dfu_alt_info correctly. > > These patches fixes such issues. [1/5] is just for avoiding > buffer overrun, [2/5] and [3/5] improves dfu_alt_info parser > to accept redundant spaces and tabs, and check the number of > arguments strictly so that the parser (and user) can notice > any unexpected parameters. [4/5] fixes the documents (there > seems some wrong description maybe coming from copy&paste). > [5/5] allows user to run 'dfu list' even if the platform > doesn't support DFU_OVER_USB. > > Thank you, > > --- > > Masami Hiramatsu (5): > DFU: Do not copy the entity name over the buffer size > DFU: Accept redundant spaces and tabs in dfu_alt_info > DFU: Check the number of arguments and argument string strictly > doc: usage: DFU: Fix dfu_alt_info document > cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB > > > cmd/dfu.c | 6 +++-- > doc/usage/dfu.rst | 57 ++++++++++++++++++++++++++++++++++-------------- > drivers/dfu/dfu.c | 37 ++++++++++++++++++++++++------- > drivers/dfu/dfu_mmc.c | 55 +++++++++++++++++++++++++++------------------- > drivers/dfu/dfu_mtd.c | 34 +++++++++++++++++++---------- > drivers/dfu/dfu_nand.c | 34 ++++++++++++++++++----------- > drivers/dfu/dfu_ram.c | 24 ++++++++++---------- > drivers/dfu/dfu_sf.c | 34 ++++++++++++++++++----------- > drivers/dfu/dfu_virt.c | 5 +++- > include/dfu.h | 33 ++++++++++++++++++---------- > 10 files changed, 205 insertions(+), 114 deletions(-) > > -- > Masami Hiramatsu <masami.hiramatsu@linaro.org> -- Masami Hiramatsu ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2013-12-24 7:52 Ian Kent 0 siblings, 0 replies; 17+ messages in thread From: Ian Kent @ 2013-12-24 7:52 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list The following series implements... --- Ian Kent (4): autofs-5.0.8 - fix ipv6 link local address handling autofs-5.0.8 - fix fix ipv6 libtirpc getport autofs-5.0.8 - fix rpc_portmap_getport() proto not set autofs-5.0.8 - fix options compare Scott Mayhew (1): From a22123dad2107a7a872ba44b0ebc478cc4d2367d Mon Sep 17 00:00:00 2001 include/automount.h | 1 + lib/cat_path.c | 9 +++++++++ lib/rpc_subs.c | 14 +++++++++----- modules/mount_autofs.c | 12 ++++++------ modules/mount_bind.c | 2 +- modules/mount_ext2.c | 2 +- modules/mount_nfs.c | 34 +++++++++++++++++----------------- modules/parse_sun.c | 22 +++++++++++----------- modules/replicated.c | 9 ++++++--- 9 files changed, 61 insertions(+), 44 deletions(-) -- Signature ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2010-11-16 20:49 ` John Bonesio 0 siblings, 0 replies; 17+ messages in thread From: John Bonesio @ 2010-11-16 20:49 UTC (permalink / raw) To: linux-kernel; +Cc: linuxppc-dev, jdl, glikely, devicetree-discuss, david The following series implements a set of changes to refactor dts (device tree source) files for systems using the mpc5200b SoC. The dtc changes allow a base dts to be defined in a common dts file included with '/include/ <filename>'. This base dts can then be updated and modified by merging in a second device tree defined in the system specific dts file. The rest of the changes are the refactoring of the mpc5200b dts files. --- John Bonesio (5): scripts: dtc: Merge in changes from the dtc repository powerpc/5200: dts: rename nodes to prepare for refactoring dts files powerpc/5200: dts: remove unused properties powerpc/5200: dts: Remove incorrect combatible strings powerpc/5200: dts: refactor dts files arch/powerpc/boot/dts/cm5200.dts | 198 +++---------------------- arch/powerpc/boot/dts/digsy_mtc.dts | 179 +++-------------------- arch/powerpc/boot/dts/lite5200b.dts | 210 ++------------------------- arch/powerpc/boot/dts/media5200.dts | 216 +++------------------------ arch/powerpc/boot/dts/motionpro.dts | 198 +++---------------------- arch/powerpc/boot/dts/mpc5200b.dtsi | 276 +++++++++++++++++++++++++++++++++++ arch/powerpc/boot/dts/mucmc52.dts | 176 ++++++---------------- arch/powerpc/boot/dts/pcm030.dts | 201 ++----------------------- arch/powerpc/boot/dts/pcm032.dts | 205 ++------------------------ arch/powerpc/boot/dts/uc101.dts | 162 ++++----------------- 10 files changed, 499 insertions(+), 1522 deletions(-) create mode 100644 arch/powerpc/boot/dts/mpc5200b.dtsi -- Signature ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2010-11-16 20:49 ` John Bonesio 0 siblings, 0 replies; 17+ messages in thread From: John Bonesio @ 2010-11-16 20:49 UTC (permalink / raw) To: linux-kernel; +Cc: glikely, jdl, linuxppc-dev, devicetree-discuss, david The following series implements a set of changes to refactor dts (device tree source) files for systems using the mpc5200b SoC. The dtc changes allow a base dts to be defined in a common dts file included with '/include/ <filename>'. This base dts can then be updated and modified by merging in a second device tree defined in the system specific dts file. The rest of the changes are the refactoring of the mpc5200b dts files. --- John Bonesio (5): scripts: dtc: Merge in changes from the dtc repository powerpc/5200: dts: rename nodes to prepare for refactoring dts files powerpc/5200: dts: remove unused properties powerpc/5200: dts: Remove incorrect combatible strings powerpc/5200: dts: refactor dts files arch/powerpc/boot/dts/cm5200.dts | 198 +++---------------------- arch/powerpc/boot/dts/digsy_mtc.dts | 179 +++-------------------- arch/powerpc/boot/dts/lite5200b.dts | 210 ++------------------------- arch/powerpc/boot/dts/media5200.dts | 216 +++------------------------ arch/powerpc/boot/dts/motionpro.dts | 198 +++---------------------- arch/powerpc/boot/dts/mpc5200b.dtsi | 276 +++++++++++++++++++++++++++++++++++ arch/powerpc/boot/dts/mucmc52.dts | 176 ++++++---------------- arch/powerpc/boot/dts/pcm030.dts | 201 ++----------------------- arch/powerpc/boot/dts/pcm032.dts | 205 ++------------------------ arch/powerpc/boot/dts/uc101.dts | 162 ++++----------------- 10 files changed, 499 insertions(+), 1522 deletions(-) create mode 100644 arch/powerpc/boot/dts/mpc5200b.dtsi -- Signature ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2010-11-16 20:49 ` John Bonesio 0 siblings, 0 replies; 17+ messages in thread From: John Bonesio @ 2010-11-16 20:49 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: glikely-s3s/WqlpOiPyB63q8FvJNQ, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ The following series implements a set of changes to refactor dts (device tree source) files for systems using the mpc5200b SoC. The dtc changes allow a base dts to be defined in a common dts file included with '/include/ <filename>'. This base dts can then be updated and modified by merging in a second device tree defined in the system specific dts file. The rest of the changes are the refactoring of the mpc5200b dts files. --- John Bonesio (5): scripts: dtc: Merge in changes from the dtc repository powerpc/5200: dts: rename nodes to prepare for refactoring dts files powerpc/5200: dts: remove unused properties powerpc/5200: dts: Remove incorrect combatible strings powerpc/5200: dts: refactor dts files arch/powerpc/boot/dts/cm5200.dts | 198 +++---------------------- arch/powerpc/boot/dts/digsy_mtc.dts | 179 +++-------------------- arch/powerpc/boot/dts/lite5200b.dts | 210 ++------------------------- arch/powerpc/boot/dts/media5200.dts | 216 +++------------------------ arch/powerpc/boot/dts/motionpro.dts | 198 +++---------------------- arch/powerpc/boot/dts/mpc5200b.dtsi | 276 +++++++++++++++++++++++++++++++++++ arch/powerpc/boot/dts/mucmc52.dts | 176 ++++++---------------- arch/powerpc/boot/dts/pcm030.dts | 201 ++----------------------- arch/powerpc/boot/dts/pcm032.dts | 205 ++------------------------ arch/powerpc/boot/dts/uc101.dts | 162 ++++----------------- 10 files changed, 499 insertions(+), 1522 deletions(-) create mode 100644 arch/powerpc/boot/dts/mpc5200b.dtsi -- Signature ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2009-11-17 14:50 Alan Cox 2009-11-19 21:41 ` Jeff Garzik 0 siblings, 1 reply; 17+ messages in thread From: Alan Cox @ 2009-11-17 14:50 UTC (permalink / raw) To: linux-kernel, linux-ide Pending experimental bits. Not necessarily ready to apply but so folks know what is going on. --- Alan Cox (5): pata_piccolo: Driver for old Toshiba chipsets pata: Update experimental tags cmd64x: implement serialization as per notes pata_sis: Implement MWDMA for the UDMA 133 capable chips pata_via: Blacklist some combinations of Transcend Flash and via drivers/ata/Kconfig | 33 +++++++--- drivers/ata/Makefile | 1 drivers/ata/ata_generic.c | 5 +- drivers/ata/pata_cmd64x.c | 132 +++++++++++++++++++++++++++++++++++++++-- drivers/ata/pata_piccolo.c | 140 ++++++++++++++++++++++++++++++++++++++++++++ drivers/ata/pata_sis.c | 88 +++++++++++++++++++++------- drivers/ata/pata_via.c | 27 ++++++++ include/linux/pci_ids.h | 7 +- 8 files changed, 388 insertions(+), 45 deletions(-) create mode 100644 drivers/ata/pata_piccolo.c -- My Git tree is full of regressions, my git tree is full of bad C My Git tree is full of regressions oh git-clone my codebase and see Git-clone git-clone, oh git-clone my codebase and see, and see Git-clone git-clone, oh git-clone my codebase and see ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/5] Series short description 2009-11-17 14:50 Alan Cox @ 2009-11-19 21:41 ` Jeff Garzik 0 siblings, 0 replies; 17+ messages in thread From: Jeff Garzik @ 2009-11-19 21:41 UTC (permalink / raw) To: Alan Cox; +Cc: linux-kernel, linux-ide On 11/17/2009 09:50 AM, Alan Cox wrote: > Pending experimental bits. Not necessarily ready to apply but so folks know > what is going on. Seems sane, modulo my Kconfig comment, and on-going thread resolution of course :) Jeff ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2008-06-12 4:54 Ian Kent 2008-06-12 6:15 ` Ian Kent 0 siblings, 1 reply; 17+ messages in thread From: Ian Kent @ 2008-06-12 4:54 UTC (permalink / raw) To: Jim Carter, autofs mailing list The following series implements... --- Ian Kent (5): autofs-5.0.3 - fix submount shutdown handling. autofs-5.0.3 - don't abuse the ap->ghost field on NFS mount autofs-5.0.3 - mount thread create condition handling fix Fix incorrect pthreads condition handling for mount requests. Another fix for don't fail on empty master map. daemon/automount.c | 82 ++++++++++++------------ daemon/direct.c | 100 +++++++++++++++++------------ daemon/indirect.c | 164 ++++++++++++++++++++++++++++++++++-------------- daemon/lookup.c | 3 - daemon/state.c | 5 + include/automount.h | 19 +++++- lib/master.c | 63 +++++++++++------- modules/lookup_file.c | 1 modules/mount_autofs.c | 4 + modules/mount_bind.c | 2 - modules/mount_nfs.c | 11 --- 11 files changed, 277 insertions(+), 177 deletions(-) -- ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/5] Series short description 2008-06-12 4:54 Ian Kent @ 2008-06-12 6:15 ` Ian Kent 0 siblings, 0 replies; 17+ messages in thread From: Ian Kent @ 2008-06-12 6:15 UTC (permalink / raw) To: Jim Carter; +Cc: autofs mailing list Another false start. Wish I could tell StGIT to cancel the send when I decide I don't want to proceed when editing the cover mail. On Thu, 2008-06-12 at 12:54 +0800, Ian Kent wrote: > The following series implements... > > --- > > Ian Kent (5): > autofs-5.0.3 - fix submount shutdown handling. > autofs-5.0.3 - don't abuse the ap->ghost field on NFS mount > autofs-5.0.3 - mount thread create condition handling fix > Fix incorrect pthreads condition handling for mount requests. > Another fix for don't fail on empty master map. > > > daemon/automount.c | 82 ++++++++++++------------ > daemon/direct.c | 100 +++++++++++++++++------------ > daemon/indirect.c | 164 ++++++++++++++++++++++++++++++++++-------------- > daemon/lookup.c | 3 - > daemon/state.c | 5 + > include/automount.h | 19 +++++- > lib/master.c | 63 +++++++++++------- > modules/lookup_file.c | 1 > modules/mount_autofs.c | 4 + > modules/mount_bind.c | 2 - > modules/mount_nfs.c | 11 --- > 11 files changed, 277 insertions(+), 177 deletions(-) > ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 0/5] Series short description @ 2008-02-25 11:20 Vasu Dev 0 siblings, 0 replies; 17+ messages in thread From: Vasu Dev @ 2008-02-25 11:20 UTC (permalink / raw) To: linux-scsi, devel The following series implements... Currently OpenFC maintains several control structures for each enabled fcoe interface, such as inner and outer fc_port, fcdev, openfc_softc, fcs_state (for fc_local_port and fc_virt_fab) etc. Here fc_port should not be confused with FC protocol's ports related structs, instead fc_port provides generic/portable interface to FCS sub module embedded inside openFC for egress, ingress handlers and sa events lists to OpenFC per FCoE interface instance. I removed outer port instance in these patches, instead used existing fcdev structure by direct functions calls between FCS & OpenFC for outer port egress and inegress functions. The fcdev is key shared structure per FCoE interface between OpenFC and FCoE modules, fcdev can be extended for all libfc(TBD) users to access per libfc user instance. Consolidation of more control structures in fcdev will simplify openFC implementation which will help in converting OpenFC into generic libfc library as suggested by linux-scsi reviewers. -- Signature : Vasu Dev <vasu.dev@intel.com> ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-12-06 7:49 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-06-07 4:11 [PATCH 0/5] Series short description Bruno Randolf 2010-06-07 4:11 ` [PATCH 1/5] ath5k: fix NULL pointer in antenna configuration Bruno Randolf 2010-06-07 4:11 ` [PATCH 2/5] ath5k: update AR5K_PHY_RESTART_DIV_GC values to match masks Bruno Randolf 2010-06-07 4:11 ` [PATCH 3/5] ath5k: new function for setting the antenna switch table Bruno Randolf 2010-06-07 4:11 ` [PATCH 4/5] ath5k: no need to save/restore the default antenna Bruno Randolf 2010-06-07 4:11 ` [PATCH 5/5] ath5k: add debugfs file for queue debugging Bruno Randolf -- strict thread matches above, loose matches on Subject: below -- 2021-12-06 5:43 [PATCH 0/5] Series short description Masami Hiramatsu 2021-12-06 7:49 ` Masami Hiramatsu 2013-12-24 7:52 Ian Kent 2010-11-16 20:49 John Bonesio 2010-11-16 20:49 ` John Bonesio 2010-11-16 20:49 ` John Bonesio 2009-11-17 14:50 Alan Cox 2009-11-19 21:41 ` Jeff Garzik 2008-06-12 4:54 Ian Kent 2008-06-12 6:15 ` Ian Kent 2008-02-25 11:20 Vasu Dev
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.