From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Nick Piggin <npiggin@suse.de>, Minchan Kim <minchan.kim@gmail.com> Cc: kosaki.motohiro@jp.fujitsu.com Subject: [PATCH 02/10] oom: remove verbose argument from __oom_kill_process() Date: Tue, 8 Jun 2010 20:55:32 +0900 (JST) [thread overview] Message-ID: <20100608205454.7680.A69D9226@jp.fujitsu.com> (raw) In-Reply-To: <20100608204621.767A.A69D9226@jp.fujitsu.com> Now, verbose argument is unused. This patch remove it. [remark: this patch is needed to fold to "oom: remove PF_EXITING check completely"] Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/oom_kill.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 0d7397b..3c83fba 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -384,20 +384,18 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order, * flag though it's unlikely that we select a process with CAP_SYS_RAW_IO * set. */ -static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, - int verbose) +static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem) { p = find_lock_task_mm(p); if (!p) return 1; - if (verbose) - printk(KERN_ERR "Killed process %d (%s) " - "vsz:%lukB, anon-rss:%lukB, file-rss:%lukB\n", - task_pid_nr(p), p->comm, - K(p->mm->total_vm), - K(get_mm_counter(p->mm, MM_ANONPAGES)), - K(get_mm_counter(p->mm, MM_FILEPAGES))); + printk(KERN_ERR "Killed process %d (%s) " + "vsz:%lukB, anon-rss:%lukB, file-rss:%lukB\n", + task_pid_nr(p), p->comm, + K(p->mm->total_vm), + K(get_mm_counter(p->mm, MM_ANONPAGES)), + K(get_mm_counter(p->mm, MM_FILEPAGES))); task_unlock(p); /* @@ -437,7 +435,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, if (c->mm == p->mm) continue; - if (oom_unkillable(c, mem, nodemask)) + if (oom_unkillable(c, mem)) continue; /* badness() returns 0 if the thread is unkillable */ @@ -449,7 +447,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, } } while_each_thread(p, t); - return __oom_kill_process(victim, mem, 1); + return __oom_kill_process(victim, mem); } #ifdef CONFIG_CGROUP_MEM_RES_CTLR -- 1.6.5.2
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Nick Piggin <npiggin@suse.de>, Minchan Kim <minchan.kim@gmail.com> Cc: kosaki.motohiro@jp.fujitsu.com Subject: [PATCH 02/10] oom: remove verbose argument from __oom_kill_process() Date: Tue, 8 Jun 2010 20:55:32 +0900 (JST) [thread overview] Message-ID: <20100608205454.7680.A69D9226@jp.fujitsu.com> (raw) In-Reply-To: <20100608204621.767A.A69D9226@jp.fujitsu.com> Now, verbose argument is unused. This patch remove it. [remark: this patch is needed to fold to "oom: remove PF_EXITING check completely"] Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/oom_kill.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 0d7397b..3c83fba 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -384,20 +384,18 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order, * flag though it's unlikely that we select a process with CAP_SYS_RAW_IO * set. */ -static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, - int verbose) +static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem) { p = find_lock_task_mm(p); if (!p) return 1; - if (verbose) - printk(KERN_ERR "Killed process %d (%s) " - "vsz:%lukB, anon-rss:%lukB, file-rss:%lukB\n", - task_pid_nr(p), p->comm, - K(p->mm->total_vm), - K(get_mm_counter(p->mm, MM_ANONPAGES)), - K(get_mm_counter(p->mm, MM_FILEPAGES))); + printk(KERN_ERR "Killed process %d (%s) " + "vsz:%lukB, anon-rss:%lukB, file-rss:%lukB\n", + task_pid_nr(p), p->comm, + K(p->mm->total_vm), + K(get_mm_counter(p->mm, MM_ANONPAGES)), + K(get_mm_counter(p->mm, MM_FILEPAGES))); task_unlock(p); /* @@ -437,7 +435,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, if (c->mm == p->mm) continue; - if (oom_unkillable(c, mem, nodemask)) + if (oom_unkillable(c, mem)) continue; /* badness() returns 0 if the thread is unkillable */ @@ -449,7 +447,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, } } while_each_thread(p, t); - return __oom_kill_process(victim, mem, 1); + return __oom_kill_process(victim, mem); } #ifdef CONFIG_CGROUP_MEM_RES_CTLR -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-08 11:55 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-06-08 11:53 [0/10] 3rd pile of OOM patch series KOSAKI Motohiro 2010-06-08 11:53 ` KOSAKI Motohiro 2010-06-08 11:54 ` [PATCH 01/10] oom: don't try to kill oom_unkillable child KOSAKI Motohiro 2010-06-08 11:54 ` KOSAKI Motohiro 2010-06-08 19:10 ` David Rientjes 2010-06-08 19:10 ` David Rientjes 2010-06-08 11:55 ` KOSAKI Motohiro [this message] 2010-06-08 11:55 ` [PATCH 02/10] oom: remove verbose argument from __oom_kill_process() KOSAKI Motohiro 2010-06-08 19:09 ` David Rientjes 2010-06-08 19:09 ` David Rientjes 2010-06-08 11:56 ` [PATCH 03/10] oom: rename badness() to oom_badness() KOSAKI Motohiro 2010-06-08 11:56 ` KOSAKI Motohiro 2010-06-08 19:09 ` David Rientjes 2010-06-08 19:09 ` David Rientjes 2010-06-08 11:57 ` [PATCH 04/10] oom: move sysctl declarations to oom.h KOSAKI Motohiro 2010-06-08 11:57 ` KOSAKI Motohiro 2010-06-08 11:58 ` [PATCH 05/10] oom: enable oom tasklist dump by default KOSAKI Motohiro 2010-06-08 11:58 ` KOSAKI Motohiro 2010-06-08 11:59 ` [PATCH 06/10] oom: cleanup has_intersects_mems_allowed() KOSAKI Motohiro 2010-06-08 11:59 ` KOSAKI Motohiro 2010-06-08 19:07 ` David Rientjes 2010-06-08 19:07 ` David Rientjes 2010-06-08 11:59 ` [PATCH 07/10] oom: kill useless debug print KOSAKI Motohiro 2010-06-08 11:59 ` KOSAKI Motohiro 2010-06-08 19:01 ` David Rientjes 2010-06-08 19:01 ` David Rientjes 2010-06-08 12:01 ` [PATCH 08/10] oom: use send_sig() instead force_sig() KOSAKI Motohiro 2010-06-08 12:01 ` KOSAKI Motohiro 2010-06-08 18:41 ` Oleg Nesterov 2010-06-08 18:41 ` Oleg Nesterov 2010-06-10 0:59 ` [PATCH 0/1] signals: introduce send_sigkill() helper Oleg Nesterov 2010-06-10 0:59 ` Oleg Nesterov 2010-06-10 1:00 ` [PATCH 1/1] " Oleg Nesterov 2010-06-10 1:00 ` Oleg Nesterov 2010-06-11 0:40 ` KAMEZAWA Hiroyuki 2010-06-11 0:40 ` KAMEZAWA Hiroyuki 2010-06-13 11:24 ` KOSAKI Motohiro 2010-06-13 11:24 ` KOSAKI Motohiro 2010-06-13 15:29 ` Oleg Nesterov 2010-06-13 15:29 ` Oleg Nesterov 2010-06-16 10:00 ` KOSAKI Motohiro 2010-06-16 10:00 ` KOSAKI Motohiro 2010-06-13 11:24 ` [PATCH 08/10] oom: use send_sig() instead force_sig() KOSAKI Motohiro 2010-06-13 11:24 ` KOSAKI Motohiro 2010-06-08 12:02 ` [PATCH 09/10] oom: filter tasks not sharing the same cpuset KOSAKI Motohiro 2010-06-08 12:02 ` KOSAKI Motohiro 2010-06-08 19:05 ` David Rientjes 2010-06-08 19:05 ` David Rientjes 2010-06-08 12:04 ` [PATCH 10/10] oom: select task from tasklist for mempolicy ooms KOSAKI Motohiro 2010-06-08 12:04 ` KOSAKI Motohiro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100608205454.7680.A69D9226@jp.fujitsu.com \ --to=kosaki.motohiro@jp.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=lclaudio@uudg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan.kim@gmail.com \ --cc=npiggin@suse.de \ --cc=oleg@redhat.com \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.