From: Alex Chiang <achiang@canonical.com>
To: Greg KH <greg@kroah.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-pci@vger.kernel.org,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: cpqphp: NULL ptr deref in cpqhpc_probe
Date: Thu, 10 Jun 2010 17:28:25 -0600 [thread overview]
Message-ID: <20100610232825.GH8257@canonical.com> (raw)
In-Reply-To: <20100610231919.GA21669@kroah.com>
* Greg KH <greg@kroah.com>:
> On Thu, Jun 10, 2010 at 04:34:36PM -0600, Alex Chiang wrote:
> > But I seriously think it's just time to rip this driver out
> > of the tree. If anyone is actually using this driver to do
> > hotplug, I will personally buy that person a full half-barrel
> > of Colorado's finest microbrew of choice in order to numb the
> > pain of making poor career decisions. Hell, we can drink it
> > together, during which time I'll hack on the driver. The code
> > surely can't get any worse.
>
> A real user found this problem on their machine, so you might
> have to go buy that barrel. Jiri has more details on that :)
Well, I went and read the bz before responding, and the user did
say that he wan't interested in the actual hotplug aspect of it.
;)
> Me, I gave the machine that had this hardware in it to
> osuosl.org a long time ago, odds are, it's still being used by
> some group.
Oh, I don't doubt that someone is using the hardware to do
something useful. But I do doubt that anyone's using the hotplug
driver. It's been in various stages of brokenness for several
years now.
/ac
prev parent reply other threads:[~2010-06-10 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 9:24 cpqphp: NULL ptr deref in cpqhpc_probe Jiri Slaby
2010-06-03 9:26 ` Jiri Slaby
2010-06-08 21:37 ` Jesse Barnes
2010-06-08 22:05 ` Greg KH
2010-06-10 22:34 ` Alex Chiang
2010-06-10 23:19 ` Greg KH
2010-06-10 23:28 ` Alex Chiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610232825.GH8257@canonical.com \
--to=achiang@canonical.com \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.