All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Jiri Slaby <jirislaby@gmail.com>,
	achiang@hp.com
Subject: cpqphp: NULL ptr deref in cpqhpc_probe
Date: Thu, 03 Jun 2010 11:24:22 +0200	[thread overview]
Message-ID: <4C0774C6.4090000@suse.cz> (raw)

Hi,

we have a system where there is a pci hotplug class device to be handled
by cpqphp, but it is not a bridge. But in cpqhpc_probe there is:
struct pci_bus *bus;
...
bus = pdev->subordinate;
...
bus->max_bus_speed = PCI_SPEED_66MHz_PCIX;

But as it is not a bridge, subordinate is NULL and the kernel crashes.

Any idea what would be a correct fix here?

The bugzilla entry is at:
https://bugzilla.novell.com/show_bug.cgi?id=609338

thanks,
-- 
js
suse labs

             reply	other threads:[~2010-06-03  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03  9:24 Jiri Slaby [this message]
2010-06-03  9:26 ` cpqphp: NULL ptr deref in cpqhpc_probe Jiri Slaby
2010-06-08 21:37 ` Jesse Barnes
2010-06-08 22:05   ` Greg KH
2010-06-10 22:34   ` Alex Chiang
2010-06-10 23:19     ` Greg KH
2010-06-10 23:28       ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0774C6.4090000@suse.cz \
    --to=jslaby@suse.cz \
    --cc=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.