All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH] configure: Fix evaluation of config-host.mak in create_config
Date: Sun, 13 Jun 2010 12:50:59 +0200	[thread overview]
Message-ID: <20100613105059.GA30566@volta.aurel32.net> (raw)
In-Reply-To: <4C13CAA0.70606@redhat.com>

On Sat, Jun 12, 2010 at 07:57:52PM +0200, Paolo Bonzini wrote:
> On 06/12/2010 06:44 PM, Jan Kiszka wrote:
> >>Yes, but only for this line. What I mean is something more generic
> >>like:
> >>
> >>"#"*) # comment
> >>     continue
> >>     ;;
> >>
> >
> >IMO, that would only paper over suboptimally expressed patterns for the
> >other line evaluations.
> 
> Agreed.  I like Jan's patch more.
> 

I have applied it.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2010-06-13 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11 20:58 [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config Jan Kiszka
2010-06-12 11:55 ` Aurelien Jarno
2010-06-12 12:25   ` Jan Kiszka
2010-06-12 14:37     ` Aurelien Jarno
2010-06-12 16:44       ` Jan Kiszka
2010-06-12 17:57         ` [Qemu-devel] " Paolo Bonzini
2010-06-13 10:50           ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100613105059.GA30566@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=jan.kiszka@web.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.