Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

From: Jan Kiszka <jan.kiszka@web.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config
Date: Sat, 12 Jun 2010 18:44:40 +0200	[thread overview]
Message-ID: <4C13B978.1000805@web.de> (raw)
In-Reply-To: <20100612143758.GD1940@ohm.aurel32.net>

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Aurelien Jarno wrote:
> On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
>> Aurelien Jarno wrote:
>>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Only match on true dir variable assignments, avoid generating garbage
>>>> due to the "# Configured with: ..." line which may contain "*dir=" as
>>>> well.
>>> Wouldn't it be better to skip all lines starting with '#', as this
>>> problem might happen again after some more changes?
>>>
>>> Or maybe we should do both.
>> This is what the patch (implicitly) does.
> 
> Yes, but only for this line. What I mean is something more generic
> like:
> 
> "#"*) # comment
>     continue
>     ;;
> 

IMO, that would only paper over suboptimally expressed patterns for the
other line evaluations.

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]