[GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Konrad Rzeszutek Wilk]

Hey Jeremy,

Plese pull from
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git pv/pcifront-2.6.32

Since the last pull it fixes two bugs:

 1). Passing in to the guest a device with non-zero function would not
     be scanned. You had to pass in the zero-function as well.
     This fixes: http://lists.xensource.com/archives/html/xen-devel/2010-06/msg00475.html

 2). When rescanning (so using 'xm pci-attach') the xen-pcifront would
     not set the parent of the device to be the PCI bus device and the
     device initialization would stop at:

[    4.802563] igb 0000:01:00.1: device not available (can't reserve
[mem 0xfb840000-0xfb85ffff])

Konrad Rzeszutek Wilk (2):
      xen-pcifront: Enforce scanning of device functions on initial execution.
      xen-pcifront: Claim PCI resources before going live.

P.S.
I will concentrate on back-porting some of those fixes in the
pcifront-2.6.31.x branch as well.

Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Thomas Schwinge]

[-- Attachment #1.1: Type: text/plain, Size: 1149 bytes --]

Hello!

On Fri, Jun 18, 2010 at 04:16:20PM -0400, Konrad Rzeszutek Wilk wrote:
> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git pv/pcifront-2.6.32
> 
> Since the last pull it fixes two bugs:
> 
>  1). Passing in to the guest a device with non-zero function would not
>      be scanned. You had to pass in the zero-function as well.
>      This fixes: http://lists.xensource.com/archives/html/xen-devel/2010-06/msg00475.html
> 
>  2). When rescanning (so using 'xm pci-attach') the xen-pcifront would
>      not set the parent of the device to be the PCI bus device and the
>      device initialization would stop at:
> 
> [    4.802563] igb 0000:01:00.1: device not available (can't reserve
> [mem 0xfb840000-0xfb85ffff])
> 
> Konrad Rzeszutek Wilk (2):
>       xen-pcifront: Enforce scanning of device functions on initial execution.
>       xen-pcifront: Claim PCI resources before going live.

Confirmed -- with both patches applied on top of a current Debian
amd64-xen kernel, forwarding of only PCI ID 0:2.7 (that is, without also
forwarding 0:2.0) works fine on my system. Thanks!


Regards,
 Thomas

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Konrad Rzeszutek Wilk]

On Mon, Jun 21, 2010 at 11:12:27PM +0200, Thomas Schwinge wrote:
> Hello!
> 
> On Fri, Jun 18, 2010 at 04:16:20PM -0400, Konrad Rzeszutek Wilk wrote:
> > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git pv/pcifront-2.6.32
> > 
> > Since the last pull it fixes two bugs:
> > 
> >  1). Passing in to the guest a device with non-zero function would not
> >      be scanned. You had to pass in the zero-function as well.
> >      This fixes: http://lists.xensource.com/archives/html/xen-devel/2010-06/msg00475.html
> > 
> >  2). When rescanning (so using 'xm pci-attach') the xen-pcifront would
> >      not set the parent of the device to be the PCI bus device and the
> >      device initialization would stop at:
> > 
> > [    4.802563] igb 0000:01:00.1: device not available (can't reserve
> > [mem 0xfb840000-0xfb85ffff])
> > 
> > Konrad Rzeszutek Wilk (2):
> >       xen-pcifront: Enforce scanning of device functions on initial execution.
> >       xen-pcifront: Claim PCI resources before going live.
> 
> Confirmed -- with both patches applied on top of a current Debian
> amd64-xen kernel, forwarding of only PCI ID 0:2.7 (that is, without also
> forwarding 0:2.0) works fine on my system. Thanks!

Great. Now did it fix your e100 card as well?
> 
> 
> Regards,
>  Thomas



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Thomas Schwinge]

[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]

Hello!

On Mon, Jun 21, 2010 at 06:09:51PM -0400, Konrad Rzeszutek Wilk wrote:
> Now did it fix your e100 card as well?

Hrm, I don't remember reporting any problems concerning e100 cards?

That aside, I do have a bunch of e100 cards, but did not yet try to
PCI-forward them.  Please tell if you want me to try that.


Regards,
 Thomas

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Konrad Rzeszutek Wilk]

On Tue, Jun 22, 2010 at 12:34:51AM +0200, Thomas Schwinge wrote:
> Hello!
> 
> On Mon, Jun 21, 2010 at 06:09:51PM -0400, Konrad Rzeszutek Wilk wrote:
> > Now did it fix your e100 card as well?
> 
> Hrm, I don't remember reporting any problems concerning e100 cards?

Duh! You are right.

I've been in correspondence with another user who had e100 cards and I
emailed them about the availability of these patches. And then I saw
your email and did not even look at who had sent it and thought it was
the other person. Sorry about that.

That aside, thank you for taking the time to test the patches.

AW: Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

[Carsten Schiers]

Yep, Konrad, that was me. I will not be able to check the patches before Thursday.
Sorry, but first I have to finish renovation in my house and the German Team needs
to win its Game vs. Ghana. ;o).

BR,
Carsten.

----- Originalnachricht -----
Von: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Gesendet: Die, 22.6.2010 00:48
An: Thomas Schwinge <thomas@schwinge.name>
Cc: Jeremy Fitzhardinge <jeremy@goop.org> ; xen-devel@lists.xensource.com
Betreff: Re: [Xen-devel] Re: [GIT PULL] pv/pcifront-2.6.32 .. update: 2 bug-fixes.

On Tue, Jun 22, 2010 at 12:34:51AM +0200, Thomas Schwinge wrote:
> Hello!
> 
> On Mon, Jun 21, 2010 at 06:09:51PM -0400, Konrad Rzeszutek Wilk wrote:
> > Now did it fix your e100 card as well?
> 
> Hrm, I don't remember reporting any problems concerning e100 cards?

Duh! You are right.

I've been in correspondence with another user who had e100 cards and I
emailed them about the availability of these patches. And then I saw
your email and did not even look at who had sent it and thought it was
the other person. Sorry about that.

That aside, thank you for taking the time to test the patches.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel