From: Jean Delvare <khali@linux-fr.org> To: Guenter Roeck <guenter.roeck@ericsson.com> Cc: Randy Dunlap <rdunlap@xenotime.net>, Andrew Morton <akpm@linux-foundation.org>, "Ira W. Snyder" <iws@ovro.caltech.edu>, Hans de Goede <hdegoede@redhat.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Samuel Ortiz <sameo@linux.intel.com>, Jonathan Cameron <kernel@jic23.retrosnub.co.uk>, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes Date: Fri, 25 Jun 2010 10:05:09 +0200 [thread overview] Message-ID: <20100625100509.7cf0e9fa@hyperion.delvare> (raw) In-Reply-To: <1277416861-32494-4-git-send-email-guenter.roeck@ericsson.com> Hi Guenter, On Thu, 24 Jun 2010 15:01:00 -0700, Guenter Roeck wrote: > Added _lcrit and _crit to voltage attributes. > Added _lcrit to temperature attributes. > > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> > --- > Documentation/hwmon/sysfs-interface | 21 ++++++++++++++++++++- > 1 files changed, 20 insertions(+), 1 deletions(-) > > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface > index d4e2917..7f60c0d 100644 > --- a/Documentation/hwmon/sysfs-interface > +++ b/Documentation/hwmon/sysfs-interface > @@ -107,10 +107,24 @@ in[0-*]_min Voltage min value. > Unit: millivolt > RW > > +in[0-*]_lcrit Voltage critical min value. > + Unit: millivolt > + RW > + If voltage drops to or below this limit, the system may > + take drastic action such as power down or reset. At the very > + least, it should report a fault. > + > in[0-*]_max Voltage max value. > Unit: millivolt > RW > > +in[0-*]_crit Voltage critical max value. > + Unit: millivolt > + RW > + If voltage reaches or exceeds this limit, the system may > + take drastic action such as power down or reset. At the very > + least, it should report a fault. > + > in[0-*]_input Voltage input value. > Unit: millivolt > RO > @@ -284,11 +298,16 @@ temp[1-*]_input Temperature input value. > Unit: millidegree Celsius > RO > > -temp[1-*]_crit Temperature critical value, typically greater than > +temp[1-*]_crit Temperature critical max value, typically greater than > corresponding temp_max values. > Unit: millidegree Celsius > RW > > +temp[1-*]_lcrit Temperature critical min value, typically lower than > + corresponding temp_min values. > + Unit: millidegree Celsius > + RW > + I'd rather have you insert that one _after_ temp[1-*]_crit_hyst, as temp[1-*]_crit_hyst is rightly related to temp[1-*]_crit. > temp[1-*]_crit_hyst > Temperature hysteresis value for critical limit. > Unit: millidegree Celsius Other than this minor issue, which I have addresses myself, this patch looks very good to me and I've applied it. Thanks, -- Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org> To: Guenter Roeck <guenter.roeck@ericsson.com> Cc: Randy Dunlap <rdunlap@xenotime.net>, Andrew Morton <akpm@linux-foundation.org>, "Ira W. Snyder" <iws@ovro.caltech.edu>, Hans de Goede <hdegoede@redhat.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Samuel Ortiz <sameo@linux.intel.com>, Jonathan Cameron <kernel@jic23.retrosnub.co.uk>, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [lm-sensors] [PATCH v3 3/4] hwmon: Update sysfs-interface to Date: Fri, 25 Jun 2010 08:05:09 +0000 [thread overview] Message-ID: <20100625100509.7cf0e9fa@hyperion.delvare> (raw) In-Reply-To: <1277416861-32494-4-git-send-email-guenter.roeck@ericsson.com> Hi Guenter, On Thu, 24 Jun 2010 15:01:00 -0700, Guenter Roeck wrote: > Added _lcrit and _crit to voltage attributes. > Added _lcrit to temperature attributes. > > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> > --- > Documentation/hwmon/sysfs-interface | 21 ++++++++++++++++++++- > 1 files changed, 20 insertions(+), 1 deletions(-) > > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface > index d4e2917..7f60c0d 100644 > --- a/Documentation/hwmon/sysfs-interface > +++ b/Documentation/hwmon/sysfs-interface > @@ -107,10 +107,24 @@ in[0-*]_min Voltage min value. > Unit: millivolt > RW > > +in[0-*]_lcrit Voltage critical min value. > + Unit: millivolt > + RW > + If voltage drops to or below this limit, the system may > + take drastic action such as power down or reset. At the very > + least, it should report a fault. > + > in[0-*]_max Voltage max value. > Unit: millivolt > RW > > +in[0-*]_crit Voltage critical max value. > + Unit: millivolt > + RW > + If voltage reaches or exceeds this limit, the system may > + take drastic action such as power down or reset. At the very > + least, it should report a fault. > + > in[0-*]_input Voltage input value. > Unit: millivolt > RO > @@ -284,11 +298,16 @@ temp[1-*]_input Temperature input value. > Unit: millidegree Celsius > RO > > -temp[1-*]_crit Temperature critical value, typically greater than > +temp[1-*]_crit Temperature critical max value, typically greater than > corresponding temp_max values. > Unit: millidegree Celsius > RW > > +temp[1-*]_lcrit Temperature critical min value, typically lower than > + corresponding temp_min values. > + Unit: millidegree Celsius > + RW > + I'd rather have you insert that one _after_ temp[1-*]_crit_hyst, as temp[1-*]_crit_hyst is rightly related to temp[1-*]_crit. > temp[1-*]_crit_hyst > Temperature hysteresis value for critical limit. > Unit: millidegree Celsius Other than this minor issue, which I have addresses myself, this patch looks very good to me and I've applied it. Thanks, -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-06-25 8:05 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-06-24 22:00 [PATCH v3 0/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Guenter Roeck 2010-06-24 22:00 ` [lm-sensors] [PATCH v3 0/4] hwmon: Driver for SMM665 Six-Channel Guenter Roeck 2010-06-24 22:00 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Guenter Roeck 2010-06-24 22:00 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Guenter Roeck 2010-06-24 23:05 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Guenter Roeck 2010-06-24 23:05 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Guenter Roeck 2010-06-27 10:20 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Mark Brown 2010-06-27 10:20 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Mark Brown 2010-06-27 15:10 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Guenter Roeck 2010-06-27 15:10 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Guenter Roeck 2010-06-27 19:54 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Mark Brown 2010-06-27 19:54 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Mark Brown 2010-06-27 22:07 ` [PATCH v3 1/4] hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor Guenter Roeck 2010-06-27 22:07 ` [lm-sensors] [PATCH v3 1/4] hwmon: Driver for SMM665 Guenter Roeck 2010-06-24 22:00 ` [PATCH v3 2/4] hwmon: SMM665 driver documentation Guenter Roeck 2010-06-24 22:00 ` [lm-sensors] " Guenter Roeck 2010-06-24 22:01 ` [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes Guenter Roeck 2010-06-24 22:01 ` [lm-sensors] [PATCH v3 3/4] hwmon: Update sysfs-interface to Guenter Roeck 2010-06-24 23:32 ` [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes Ira W. Snyder 2010-06-24 23:32 ` [lm-sensors] [PATCH v3 3/4] hwmon: Update sysfs-interface to Ira W. Snyder 2010-06-24 23:40 ` [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes Guenter Roeck 2010-06-24 23:40 ` [lm-sensors] [PATCH v3 3/4] hwmon: Update sysfs-interface to Guenter Roeck 2010-06-25 8:05 ` Jean Delvare [this message] 2010-06-25 8:05 ` Jean Delvare 2010-06-24 22:01 ` [PATCH v3 4/4] hwmon: Update MAINTAINERS for smm665 driver Guenter Roeck 2010-06-24 22:01 ` [lm-sensors] [PATCH v3 4/4] hwmon: Update MAINTAINERS for smm665 Guenter Roeck 2010-06-25 8:09 ` [PATCH v3 4/4] hwmon: Update MAINTAINERS for smm665 driver Jean Delvare 2010-06-25 8:09 ` [lm-sensors] [PATCH v3 4/4] hwmon: Update MAINTAINERS for Jean Delvare
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100625100509.7cf0e9fa@hyperion.delvare \ --to=khali@linux-fr.org \ --cc=akpm@linux-foundation.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=guenter.roeck@ericsson.com \ --cc=hdegoede@redhat.com \ --cc=iws@ovro.caltech.edu \ --cc=kernel@jic23.retrosnub.co.uk \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lm-sensors@lm-sensors.org \ --cc=rdunlap@xenotime.net \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.