* section .data..init_task
@ 2010-06-28 4:59 Sean MacLennan
2010-07-13 0:34 ` Sean MacLennan
0 siblings, 1 reply; 11+ messages in thread
From: Sean MacLennan @ 2010-06-28 4:59 UTC (permalink / raw)
To: linuxppc-dev
Anybody else seeing these messages?
ppc_4xxFP-ld: .tmp_vmlinux1: section .data..init_task lma 0xc0374000 overlaps previous sections
ppc_4xxFP-ld: .tmp_vmlinux2: section .data..init_task lma 0xc03a2000 overlaps previous sections
ppc_4xxFP-ld: vmlinux: section .data..init_task lma 0xc03a2000 overlaps previous sections
Or does anybody know what they mean? They started showing up in 2.6.35.
Very easy to reproduce, so don't hesitate to ask for more info.
Cheers,
Sean
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: section .data..init_task
2010-06-28 4:59 section .data..init_task Sean MacLennan
@ 2010-07-13 0:34 ` Sean MacLennan
2010-07-13 8:54 ` Sam Ravnborg
2010-07-13 9:50 ` [ Sam Ravnborg
0 siblings, 2 replies; 11+ messages in thread
From: Sean MacLennan @ 2010-07-13 0:34 UTC (permalink / raw)
To: Denys Vlasenko, linuxppc-dev, Tim Abbott, Sam Ravnborg
On Mon, 28 Jun 2010 00:59:00 -0400
Sean MacLennan <smaclennan@pikatech.com> wrote:
> Anybody else seeing these messages?
>
> ppc_4xxFP-ld: .tmp_vmlinux1: section .data..init_task lma 0xc0374000
> overlaps previous sections ppc_4xxFP-ld: .tmp_vmlinux2:
> section .data..init_task lma 0xc03a2000 overlaps previous sections
> ppc_4xxFP-ld: vmlinux: section .data..init_task lma 0xc03a2000
> overlaps previous sections
>
> Or does anybody know what they mean? They started showing up in
> 2.6.35.
>
> Very easy to reproduce, so don't hesitate to ask for more info.
I had a bit of time, so I tracked this down. This patch seems to be
the culprit: http://lkml.org/lkml/2010/2/19/366
Specifically, this code:
/* The initial task and kernel stack */
- .data.init_task : AT(ADDR(.data.init_task) - LOAD_OFFSET) {
- INIT_TASK_DATA(THREAD_SIZE)
- }
+ INIT_TASK_DATA_SECTION(THREAD_SIZE)
If I change it back to:
/* The initial task and kernel stack */
.data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) {
INIT_TASK_DATA(THREAD_SIZE)
}
not only do the warnings go away, but the kernel now boots again!
Cheers,
Sean
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: section .data..init_task
2010-07-13 0:34 ` Sean MacLennan
@ 2010-07-13 8:54 ` Sam Ravnborg
2010-07-13 15:26 ` Sean MacLennan
2010-07-13 9:50 ` [ Sam Ravnborg
1 sibling, 1 reply; 11+ messages in thread
From: Sam Ravnborg @ 2010-07-13 8:54 UTC (permalink / raw)
To: Sean MacLennan; +Cc: Denys Vlasenko, linuxppc-dev, Tim Abbott
On Mon, Jul 12, 2010 at 08:34:35PM -0400, Sean MacLennan wrote:
> On Mon, 28 Jun 2010 00:59:00 -0400
> Sean MacLennan <smaclennan@pikatech.com> wrote:
>
> > Anybody else seeing these messages?
> >
> > ppc_4xxFP-ld: .tmp_vmlinux1: section .data..init_task lma 0xc0374000
> > overlaps previous sections ppc_4xxFP-ld: .tmp_vmlinux2:
> > section .data..init_task lma 0xc03a2000 overlaps previous sections
> > ppc_4xxFP-ld: vmlinux: section .data..init_task lma 0xc03a2000
> > overlaps previous sections
> >
> > Or does anybody know what they mean? They started showing up in
> > 2.6.35.
> >
> > Very easy to reproduce, so don't hesitate to ask for more info.
>
> I had a bit of time, so I tracked this down. This patch seems to be
> the culprit: http://lkml.org/lkml/2010/2/19/366
>
> Specifically, this code:
>
> /* The initial task and kernel stack */
> - .data.init_task : AT(ADDR(.data.init_task) - LOAD_OFFSET) {
> - INIT_TASK_DATA(THREAD_SIZE)
> - }
> + INIT_TASK_DATA_SECTION(THREAD_SIZE)
>
> If I change it back to:
>
> /* The initial task and kernel stack */
> .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) {
> INIT_TASK_DATA(THREAD_SIZE)
> }
>
> not only do the warnings go away, but the kernel now boots again!
It looks like a missing AT() in the output section.
The following patch should also fix it.
Please test and let us know.
Thanks,
Sam
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 48c5299..3c4bf03 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -435,7 +435,7 @@
*/
#define INIT_TASK_DATA_SECTION(align) \
. = ALIGN(align); \
- .data..init_task : { \
+ .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) { \
INIT_TASK_DATA(align) \
}
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: section .data..init_task
2010-07-13 8:54 ` Sam Ravnborg
@ 2010-07-13 15:26 ` Sean MacLennan
2010-07-13 15:33 ` Sam Ravnborg
0 siblings, 1 reply; 11+ messages in thread
From: Sean MacLennan @ 2010-07-13 15:26 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Denys Vlasenko, linuxppc-dev, Tim Abbott
On Tue, 13 Jul 2010 10:54:19 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> It looks like a missing AT() in the output section.
> The following patch should also fix it.
>
> Please test and let us know.
>
> Thanks,
> Sam
Applied the patch and it solves the problem. Thanks.
Cheers,
Sean
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: section .data..init_task
2010-07-13 15:26 ` Sean MacLennan
@ 2010-07-13 15:33 ` Sam Ravnborg
0 siblings, 0 replies; 11+ messages in thread
From: Sam Ravnborg @ 2010-07-13 15:33 UTC (permalink / raw)
To: Sean MacLennan; +Cc: Denys Vlasenko, linuxppc-dev, Tim Abbott
On Tue, Jul 13, 2010 at 11:26:10AM -0400, Sean MacLennan wrote:
> On Tue, 13 Jul 2010 10:54:19 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > It looks like a missing AT() in the output section.
> > The following patch should also fix it.
> >
> > Please test and let us know.
> >
> > Thanks,
> > Sam
>
> Applied the patch and it solves the problem. Thanks.
Thanks for the quick feedback!
Sam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [
2010-07-13 0:34 ` Sean MacLennan
2010-07-13 8:54 ` Sam Ravnborg
@ 2010-07-13 9:50 ` Sam Ravnborg
2010-07-22 22:27 ` [ Sean MacLennan
2010-07-22 23:50 ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
1 sibling, 2 replies; 11+ messages in thread
From: Sam Ravnborg @ 2010-07-13 9:50 UTC (permalink / raw)
To: Sean MacLennan, Benjamin Herrenschmidt
Cc: Denys Vlasenko, linuxppc-dev, Michal Marek, Tim Abbott
>From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 13 Jul 2010 11:39:42 +0200
Subject: [PATCH] vmlinux.lds: fix .data..init_task output section (fix popwerpc boot)
The .data..init_task output section was missing
a load offset causing a popwerpc target to fail to boot.
Sean MacLennan tracked it down to the definition of
INIT_TASK_DATA_SECTION().
There are only two users of INIT_TASK_DATA_SECTION()
in the kernel today: cris and popwerpc.
cris do not support relocatable kernels and is thus not
impacted by this change.
Fix INIT_TASK_DATA_SECTION() to specify load offset like
all other output sections.
Reported-by: Sean MacLennan <smaclennan@pikatech.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
On the assumption that Sean reports that it fixes
the warnings/boot issue here is a real patch.
Ben - will you take it via the popwerpc tree
or shall I ask Michal to take it via kbuild?
Sam
include/asm-generic/vmlinux.lds.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 48c5299..cdfff74 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -435,7 +435,7 @@
*/
#define INIT_TASK_DATA_SECTION(align) \
. = ALIGN(align); \
- .data..init_task : { \
+ .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) { \
INIT_TASK_DATA(align) \
}
--
1.6.0.6
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [
2010-07-13 9:50 ` [ Sam Ravnborg
@ 2010-07-22 22:27 ` Sean MacLennan
2010-07-22 22:33 ` [ Benjamin Herrenschmidt
2010-07-22 23:50 ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
1 sibling, 1 reply; 11+ messages in thread
From: Sean MacLennan @ 2010-07-22 22:27 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Denys Vlasenko, Tim Abbott, Michal Marek, linuxppc-dev
On Tue, 13 Jul 2010 11:50:24 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Ben - will you take it via the popwerpc tree
> or shall I ask Michal to take it via kbuild?
Anything happening with this patch?
Cheers,
Sean
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [
2010-07-22 22:27 ` [ Sean MacLennan
@ 2010-07-22 22:33 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 11+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-22 22:33 UTC (permalink / raw)
To: Sean MacLennan
Cc: Denys Vlasenko, linuxppc-dev, Sam Ravnborg, Michal Marek, Tim Abbott
On Thu, 2010-07-22 at 18:27 -0400, Sean MacLennan wrote:
> On Tue, 13 Jul 2010 11:50:24 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > Ben - will you take it via the popwerpc tree
> > or shall I ask Michal to take it via kbuild?
>
> Anything happening with this patch?
The subject line tripped my spam filter ...
I'm happy to take it.
Sean, make sure it's on patchwork and it will be in one of my next
batches.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] powerpc: fix .data..init_task output section
2010-07-13 9:50 ` [ Sam Ravnborg
2010-07-22 22:27 ` [ Sean MacLennan
@ 2010-07-22 23:50 ` Sean MacLennan
2010-07-23 13:58 ` Sam Ravnborg
1 sibling, 1 reply; 11+ messages in thread
From: Sean MacLennan @ 2010-07-22 23:50 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linuxppc-dev
On Tue, 13 Jul 2010 11:50:24 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Tue, 13 Jul 2010 11:39:42 +0200
> Subject: [PATCH] vmlinux.lds: fix .data..init_task output section
> (fix popwerpc boot)
>
> The .data..init_task output section was missing
> a load offset causing a popwerpc target to fail to boot.
>
> Sean MacLennan tracked it down to the definition of
> INIT_TASK_DATA_SECTION().
>
> There are only two users of INIT_TASK_DATA_SECTION()
> in the kernel today: cris and popwerpc.
> cris do not support relocatable kernels and is thus not
> impacted by this change.
>
> Fix INIT_TASK_DATA_SECTION() to specify load offset like
> all other output sections.
>
> Reported-by: Sean MacLennan <smaclennan@pikatech.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>
> On the assumption that Sean reports that it fixes
> the warnings/boot issue here is a real patch.
>
> Ben - will you take it via the popwerpc tree
> or shall I ask Michal to take it via kbuild?
>
> Sam
>
> include/asm-generic/vmlinux.lds.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h
> b/include/asm-generic/vmlinux.lds.h index 48c5299..cdfff74 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -435,7 +435,7 @@
> */
> #define
> INIT_TASK_DATA_SECTION(align)
> \ . = ALIGN(align); \
> - .data..init_task :
> { \
> + .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET)
> { \
> INIT_TASK_DATA(align) \ }
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] powerpc: fix .data..init_task output section
2010-07-22 23:50 ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
@ 2010-07-23 13:58 ` Sam Ravnborg
2010-07-23 22:16 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 11+ messages in thread
From: Sam Ravnborg @ 2010-07-23 13:58 UTC (permalink / raw)
To: Sean MacLennan; +Cc: linuxppc-dev
On Thu, Jul 22, 2010 at 07:50:08PM -0400, Sean MacLennan wrote:
> On Tue, 13 Jul 2010 11:50:24 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
> > From: Sam Ravnborg <sam@ravnborg.org>
> > Date: Tue, 13 Jul 2010 11:39:42 +0200
> > Subject: [PATCH] vmlinux.lds: fix .data..init_task output section
> > (fix popwerpc boot)
> >
> > The .data..init_task output section was missing
> > a load offset causing a popwerpc target to fail to boot.
> >
> > Sean MacLennan tracked it down to the definition of
> > INIT_TASK_DATA_SECTION().
> >
> > There are only two users of INIT_TASK_DATA_SECTION()
> > in the kernel today: cris and popwerpc.
> > cris do not support relocatable kernels and is thus not
> > impacted by this change.
> >
> > Fix INIT_TASK_DATA_SECTION() to specify load offset like
> > all other output sections.
> >
> > Reported-by: Sean MacLennan <smaclennan@pikatech.com>
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > ---
> >
> > On the assumption that Sean reports that it fixes
> > the warnings/boot issue here is a real patch.
> >
> > Ben - will you take it via the popwerpc tree
> > or shall I ask Michal to take it via kbuild?
> >
> > Sam
Sorry for the bad initial subject line!
As Sean reported that the patch fixes his isuse it
deserves a:
Tested-by: Sean MacLennan <smaclennan@pikatech.com>
Sam
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] powerpc: fix .data..init_task output section
2010-07-23 13:58 ` Sam Ravnborg
@ 2010-07-23 22:16 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 11+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-23 22:16 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linuxppc-dev, Sean MacLennan
> > >
> > > On the assumption that Sean reports that it fixes
> > > the warnings/boot issue here is a real patch.
> > >
> > > Ben - will you take it via the popwerpc tree
> > > or shall I ask Michal to take it via kbuild?
> > >
> > > Sam
>
> Sorry for the bad initial subject line!
> As Sean reported that the patch fixes his isuse it
> deserves a:
>
> Tested-by: Sean MacLennan <smaclennan@pikatech.com>
Heh. Too late, I already sent it to Linus :-)
Ben.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-07-23 22:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-28 4:59 section .data..init_task Sean MacLennan
2010-07-13 0:34 ` Sean MacLennan
2010-07-13 8:54 ` Sam Ravnborg
2010-07-13 15:26 ` Sean MacLennan
2010-07-13 15:33 ` Sam Ravnborg
2010-07-13 9:50 ` [ Sam Ravnborg
2010-07-22 22:27 ` [ Sean MacLennan
2010-07-22 22:33 ` [ Benjamin Herrenschmidt
2010-07-22 23:50 ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
2010-07-23 13:58 ` Sam Ravnborg
2010-07-23 22:16 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.