All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-15 18:43 ` Kulikov Vasiliy
  0 siblings, 0 replies; 9+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 18:43 UTC (permalink / raw)
  To: kernel-janitors
  Cc: Dmitry Torokhov, Samuel Ortiz, Luotao Fu, linux-input, linux-kernel

platform_get_irq_byname() can return negative results, it is not seen to
unsigned ts_irq. Make it signed.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 77f4374..656148e 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
 	struct input_dev *idev;
 	struct stmpe_ts_platform_data *ts_pdata = NULL;
 	int ret = 0;
-	unsigned int ts_irq;
+	int ts_irq;
 
 	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
 	if (ts_irq < 0)
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-15 18:43 ` Kulikov Vasiliy
  0 siblings, 0 replies; 9+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 18:43 UTC (permalink / raw)
  To: kernel-janitors
  Cc: Dmitry Torokhov, Samuel Ortiz, Luotao Fu, linux-input, linux-kernel

platform_get_irq_byname() can return negative results, it is not seen to
unsigned ts_irq. Make it signed.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 77f4374..656148e 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
 	struct input_dev *idev;
 	struct stmpe_ts_platform_data *ts_pdata = NULL;
 	int ret = 0;
-	unsigned int ts_irq;
+	int ts_irq;
 
 	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
 	if (ts_irq < 0)
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
  2010-07-15 18:43 ` Kulikov Vasiliy
@ 2010-07-15 20:49   ` Luotao Fu
  -1 siblings, 0 replies; 9+ messages in thread
From: Luotao Fu @ 2010-07-15 20:49 UTC (permalink / raw)
  To: Kulikov Vasiliy
  Cc: kernel-janitors, Dmitry Torokhov, Samuel Ortiz, Luotao Fu,
	linux-input, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>

Acked-By: Luotao Fu <l.fu@pengutronix.de>

> ---
>  drivers/input/touchscreen/stmpe-ts.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
>  	struct input_dev *idev;
>  	struct stmpe_ts_platform_data *ts_pdata = NULL;
>  	int ret = 0;
> -	unsigned int ts_irq;
> +	int ts_irq;
>  
>  	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
>  	if (ts_irq < 0)
> -- 
> 1.7.0.4
> 

Stupid bug. Thanks for catching this.

cheers
Luotao Fu

-- 
Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-15 20:49   ` Luotao Fu
  0 siblings, 0 replies; 9+ messages in thread
From: Luotao Fu @ 2010-07-15 20:49 UTC (permalink / raw)
  To: Kulikov Vasiliy
  Cc: kernel-janitors, Dmitry Torokhov, Samuel Ortiz, Luotao Fu,
	linux-input, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>

Acked-By: Luotao Fu <l.fu@pengutronix.de>

> ---
>  drivers/input/touchscreen/stmpe-ts.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
>  	struct input_dev *idev;
>  	struct stmpe_ts_platform_data *ts_pdata = NULL;
>  	int ret = 0;
> -	unsigned int ts_irq;
> +	int ts_irq;
>  
>  	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
>  	if (ts_irq < 0)
> -- 
> 1.7.0.4
> 

Stupid bug. Thanks for catching this.

cheers
Luotao Fu

-- 
Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
  2010-07-15 20:49   ` Luotao Fu
  (?)
@ 2010-07-16  7:18     ` Dmitry Torokhov
  -1 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2010-07-16  7:18 UTC (permalink / raw)
  To: Kulikov Vasiliy, kernel-janitors, Samuel Ortiz, Luotao Fu,
	linux-input, linux-kernel

On Thu, Jul 15, 2010 at 10:49:27PM +0200, Luotao Fu wrote:
> On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> > platform_get_irq_byname() can return negative results, it is not seen to
> > unsigned ts_irq. Make it signed.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> 
> Acked-By: Luotao Fu <l.fu@pengutronix.de>
> 

OK, the driver is still in Samuel's tree so he gets to pick the patch...

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-16  7:18     ` Dmitry Torokhov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2010-07-16  7:18 UTC (permalink / raw)
  To: Kulikov Vasiliy, kernel-janitors, Samuel Ortiz, Luotao Fu,
	linux-input, linux-kernel

On Thu, Jul 15, 2010 at 10:49:27PM +0200, Luotao Fu wrote:
> On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> > platform_get_irq_byname() can return negative results, it is not seen to
> > unsigned ts_irq. Make it signed.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> 
> Acked-By: Luotao Fu <l.fu@pengutronix.de>
> 

OK, the driver is still in Samuel's tree so he gets to pick the patch...

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-16  7:18     ` Dmitry Torokhov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2010-07-16  7:18 UTC (permalink / raw)
  To: Kulikov Vasiliy, kernel-janitors, Samuel Ortiz, Luotao Fu,
	linux-input, linux-kernel

On Thu, Jul 15, 2010 at 10:49:27PM +0200, Luotao Fu wrote:
> On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> > platform_get_irq_byname() can return negative results, it is not seen to
> > unsigned ts_irq. Make it signed.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> 
> Acked-By: Luotao Fu <l.fu@pengutronix.de>
> 

OK, the driver is still in Samuel's tree so he gets to pick the patch...

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
  2010-07-15 18:43 ` Kulikov Vasiliy
@ 2010-07-25 21:32   ` Samuel Ortiz
  -1 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2010-07-25 21:32 UTC (permalink / raw)
  To: Kulikov Vasiliy
  Cc: kernel-janitors, Dmitry Torokhov, Luotao Fu, linux-input, linux-kernel

Hi Vasiliy,

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
Patch applied to my mfd tree, thanks.

Cheers,
Samuel.


> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
>  drivers/input/touchscreen/stmpe-ts.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
>  	struct input_dev *idev;
>  	struct stmpe_ts_platform_data *ts_pdata = NULL;
>  	int ret = 0;
> -	unsigned int ts_irq;
> +	int ts_irq;
>  
>  	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
>  	if (ts_irq < 0)
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 2/8] touchscreen: fix sign bug
@ 2010-07-25 21:32   ` Samuel Ortiz
  0 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2010-07-25 21:32 UTC (permalink / raw)
  To: Kulikov Vasiliy
  Cc: kernel-janitors, Dmitry Torokhov, Luotao Fu, linux-input, linux-kernel

Hi Vasiliy,

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
Patch applied to my mfd tree, thanks.

Cheers,
Samuel.


> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
>  drivers/input/touchscreen/stmpe-ts.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
>  	struct input_dev *idev;
>  	struct stmpe_ts_platform_data *ts_pdata = NULL;
>  	int ret = 0;
> -	unsigned int ts_irq;
> +	int ts_irq;
>  
>  	ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
>  	if (ts_irq < 0)
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-07-25 21:32 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-15 18:43 [PATCH 2/8] touchscreen: fix sign bug Kulikov Vasiliy
2010-07-15 18:43 ` Kulikov Vasiliy
2010-07-15 20:49 ` Luotao Fu
2010-07-15 20:49   ` Luotao Fu
2010-07-16  7:18   ` Dmitry Torokhov
2010-07-16  7:18     ` Dmitry Torokhov
2010-07-16  7:18     ` Dmitry Torokhov
2010-07-25 21:32 ` Samuel Ortiz
2010-07-25 21:32   ` Samuel Ortiz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.