* + omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch added to -mm tree
@ 2010-07-21 23:14 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2010-07-21 23:14 UTC (permalink / raw)
To: mm-commits; +Cc: svenkatr, linux-mmc, madhu.cr
The patch titled
omap hsmmc: fix processing of all dma interrupts as block completion
has been added to the -mm tree. Its filename is
omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: omap hsmmc: fix processing of all dma interrupts as block completion
From: Venkatraman S <svenkatr@ti.com>
If other informative interrupts are enabled for the DMA channel used by
hsmmc, those are incorrectly treated as block completion. This patch lets
only the block completion interrupt to be processed.
Signed-off-by: Venkatraman S <svenkatr@ti.com>
Acked-by: Madhusudhan Chikkature <madhu.cr@ti.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mmc/host/omap_hsmmc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN drivers/mmc/host/omap_hsmmc.c~omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion drivers/mmc/host/omap_hsmmc.c
--- a/drivers/mmc/host/omap_hsmmc.c~omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion
+++ a/drivers/mmc/host/omap_hsmmc.c
@@ -1280,8 +1280,11 @@ static void omap_hsmmc_dma_cb(int lch, u
struct mmc_data *data = host->mrq->data;
int dma_ch, req_in_progress;
- if (ch_status & OMAP2_DMA_MISALIGNED_ERR_IRQ)
- dev_dbg(mmc_dev(host->mmc), "MISALIGNED_ADRS_ERR\n");
+ if (!(ch_status & OMAP_DMA_BLOCK_IRQ)) {
+ dev_warn(mmc_dev(host->mmc), "unexpected dma status %x\n",
+ ch_status);
+ return;
+ }
spin_lock(&host->irq_lock);
if (host->dma_ch < 0) {
_
Patches currently in -mm which might be from svenkatr@ti.com are
mmc-omap-fix-for-bus-width-which-improves-sd-cards-peformance.patch
omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* + omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch added to -mm tree
@ 2010-07-21 23:14 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2010-07-21 23:14 UTC (permalink / raw)
To: mm-commits; +Cc: svenkatr, linux-mmc, madhu.cr
The patch titled
omap hsmmc: fix processing of all dma interrupts as block completion
has been added to the -mm tree. Its filename is
omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: omap hsmmc: fix processing of all dma interrupts as block completion
From: Venkatraman S <svenkatr@ti.com>
If other informative interrupts are enabled for the DMA channel used by
hsmmc, those are incorrectly treated as block completion. This patch lets
only the block completion interrupt to be processed.
Signed-off-by: Venkatraman S <svenkatr@ti.com>
Acked-by: Madhusudhan Chikkature <madhu.cr@ti.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mmc/host/omap_hsmmc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN drivers/mmc/host/omap_hsmmc.c~omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion drivers/mmc/host/omap_hsmmc.c
--- a/drivers/mmc/host/omap_hsmmc.c~omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion
+++ a/drivers/mmc/host/omap_hsmmc.c
@@ -1280,8 +1280,11 @@ static void omap_hsmmc_dma_cb(int lch, u
struct mmc_data *data = host->mrq->data;
int dma_ch, req_in_progress;
- if (ch_status & OMAP2_DMA_MISALIGNED_ERR_IRQ)
- dev_dbg(mmc_dev(host->mmc), "MISALIGNED_ADRS_ERR\n");
+ if (!(ch_status & OMAP_DMA_BLOCK_IRQ)) {
+ dev_warn(mmc_dev(host->mmc), "unexpected dma status %x\n",
+ ch_status);
+ return;
+ }
spin_lock(&host->irq_lock);
if (host->dma_ch < 0) {
_
Patches currently in -mm which might be from svenkatr@ti.com are
mmc-omap-fix-for-bus-width-which-improves-sd-cards-peformance.patch
omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-21 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-21 23:14 + omap-hsmmc-fix-processing-of-all-dma-interrupts-as-block-completion.patch added to -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2010-07-21 23:14 akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.