* [PATCH] xfs_io: allow resvsp command for foreign filesystems
@ 2010-07-22 5:30 Christoph Hellwig
2010-07-22 6:23 ` Nathan Scott
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-07-22 5:30 UTC (permalink / raw)
To: xfs
Recent kernels implement the RESVP ioctl in common code, so using
command for non-XFS filesystems is fine.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfsprogs-dev/io/prealloc.c
===================================================================
--- xfsprogs-dev.orig/io/prealloc.c 2010-07-21 19:11:34.943494680 +0200
+++ xfsprogs-dev/io/prealloc.c 2010-07-21 19:11:57.093494680 +0200
@@ -182,7 +182,7 @@ prealloc_init(void)
resvsp_cmd.cfunc = resvsp_f;
resvsp_cmd.argmin = 2;
resvsp_cmd.argmax = 2;
- resvsp_cmd.flags = CMD_NOMAP_OK;
+ resvsp_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
resvsp_cmd.args = _("off len");
resvsp_cmd.oneline =
_("reserves space associated with part of a file");
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_io: allow resvsp command for foreign filesystems
2010-07-22 5:30 [PATCH] xfs_io: allow resvsp command for foreign filesystems Christoph Hellwig
@ 2010-07-22 6:23 ` Nathan Scott
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Scott @ 2010-07-22 6:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
----- "Christoph Hellwig" <hch@infradead.org> wrote:
> Recent kernels implement the RESVP ioctl in common code, so using
> command for non-XFS filesystems is fine.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
Looks good.
Reviewed-by: Nathan Scott <nathans@debian.org>
cheers.
--
Nathan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-22 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-22 5:30 [PATCH] xfs_io: allow resvsp command for foreign filesystems Christoph Hellwig
2010-07-22 6:23 ` Nathan Scott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.