All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc:  fix .data..init_task output section
@ 2010-07-22 23:55 Sean MacLennan
  2010-07-23  0:04 ` Sean MacLennan
  0 siblings, 1 reply; 5+ messages in thread
From: Sean MacLennan @ 2010-07-22 23:55 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Sam Ravnborg

=46rom 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 13 Jul 2010 11:39:42 +0200
Subject: [PATCH] vmlinux.lds: fix .data..init_task output section (fix
popwerpc boot)

The .data..init_task output section was missing
a load offset causing a popwerpc target to fail to boot.

Sean MacLennan tracked it down to the definition of
INIT_TASK_DATA_SECTION().

There are only two users of INIT_TASK_DATA_SECTION()
in the kernel today: cris and popwerpc.
cris do not support relocatable kernels and is thus not
impacted by this change.

Fix INIT_TASK_DATA_SECTION() to specify load offset like
all other output sections.

Reported-by: Sean MacLennan <smaclennan@pikatech.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 include/asm-generic/vmlinux.lds.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h
b/include/asm-generic/vmlinux.lds.h index 48c5299..cdfff74 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -435,7 +435,7 @@
  */
 #define
INIT_TASK_DATA_SECTION(align)
\ . =3D ALIGN(align);						\
-	.data..init_task :
{						\
+	.data..init_task :  AT(ADDR(.data..init_task) - LOAD_OFFSET)
{	\ INIT_TASK_DATA(align)
\ }
=20
--=20
1.6.0.6

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc:  fix .data..init_task output section
  2010-07-22 23:55 [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
@ 2010-07-23  0:04 ` Sean MacLennan
  0 siblings, 0 replies; 5+ messages in thread
From: Sean MacLennan @ 2010-07-23  0:04 UTC (permalink / raw)
  To: Sean MacLennan; +Cc: linuxppc-dev, Sam Ravnborg

=46rom 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 13 Jul 2010 11:39:42 +0200
Subject: [PATCH] vmlinux.lds: fix .data..init_task output section (fix popw=
erpc boot)

The .data..init_task output section was missing
a load offset causing a popwerpc target to fail to boot.

Sean MacLennan tracked it down to the definition of
INIT_TASK_DATA_SECTION().

There are only two users of INIT_TASK_DATA_SECTION()
in the kernel today: cris and popwerpc.
cris do not support relocatable kernels and is thus not
impacted by this change.

Fix INIT_TASK_DATA_SECTION() to specify load offset like
all other output sections.

Reported-by: Sean MacLennan <smaclennan@pikatech.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 include/asm-generic/vmlinux.lds.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinu=
x.lds.h
index 48c5299..cdfff74 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -435,7 +435,7 @@
  */
 #define INIT_TASK_DATA_SECTION(align)					\
 	. =3D ALIGN(align);						\
-	.data..init_task : {						\
+	.data..init_task :  AT(ADDR(.data..init_task) - LOAD_OFFSET) {	\
 		INIT_TASK_DATA(align)					\
 	}
=20
--=20
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc:  fix .data..init_task output section
  2010-07-23 13:58       ` Sam Ravnborg
@ 2010-07-23 22:16         ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-23 22:16 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: linuxppc-dev, Sean MacLennan


> > > 
> > > On the assumption that Sean reports that it fixes
> > > the warnings/boot issue here is a real patch.
> > > 
> > > Ben - will you take it via the popwerpc tree
> > > or shall I ask Michal to take it via kbuild?
> > > 
> > > 	Sam
> 
> Sorry for the bad initial subject line!
> As Sean reported that the patch fixes his isuse it
> deserves a:
> 
> Tested-by: Sean MacLennan <smaclennan@pikatech.com>

Heh. Too late, I already sent it to Linus :-)

Ben.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc:  fix .data..init_task output section
  2010-07-22 23:50     ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
@ 2010-07-23 13:58       ` Sam Ravnborg
  2010-07-23 22:16         ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2010-07-23 13:58 UTC (permalink / raw)
  To: Sean MacLennan; +Cc: linuxppc-dev

On Thu, Jul 22, 2010 at 07:50:08PM -0400, Sean MacLennan wrote:
> On Tue, 13 Jul 2010 11:50:24 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
> 
> > From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
> > From: Sam Ravnborg <sam@ravnborg.org>
> > Date: Tue, 13 Jul 2010 11:39:42 +0200
> > Subject: [PATCH] vmlinux.lds: fix .data..init_task output section
> > (fix popwerpc boot)
> > 
> > The .data..init_task output section was missing
> > a load offset causing a popwerpc target to fail to boot.
> > 
> > Sean MacLennan tracked it down to the definition of
> > INIT_TASK_DATA_SECTION().
> > 
> > There are only two users of INIT_TASK_DATA_SECTION()
> > in the kernel today: cris and popwerpc.
> > cris do not support relocatable kernels and is thus not
> > impacted by this change.
> > 
> > Fix INIT_TASK_DATA_SECTION() to specify load offset like
> > all other output sections.
> > 
> > Reported-by: Sean MacLennan <smaclennan@pikatech.com>
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > ---
> > 
> > On the assumption that Sean reports that it fixes
> > the warnings/boot issue here is a real patch.
> > 
> > Ben - will you take it via the popwerpc tree
> > or shall I ask Michal to take it via kbuild?
> > 
> > 	Sam

Sorry for the bad initial subject line!
As Sean reported that the patch fixes his isuse it
deserves a:

Tested-by: Sean MacLennan <smaclennan@pikatech.com>

	Sam

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] powerpc:  fix .data..init_task output section
  2010-07-13  9:50   ` [ Sam Ravnborg
@ 2010-07-22 23:50     ` Sean MacLennan
  2010-07-23 13:58       ` Sam Ravnborg
  0 siblings, 1 reply; 5+ messages in thread
From: Sean MacLennan @ 2010-07-22 23:50 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: linuxppc-dev

On Tue, 13 Jul 2010 11:50:24 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:

> From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Tue, 13 Jul 2010 11:39:42 +0200
> Subject: [PATCH] vmlinux.lds: fix .data..init_task output section
> (fix popwerpc boot)
> 
> The .data..init_task output section was missing
> a load offset causing a popwerpc target to fail to boot.
> 
> Sean MacLennan tracked it down to the definition of
> INIT_TASK_DATA_SECTION().
> 
> There are only two users of INIT_TASK_DATA_SECTION()
> in the kernel today: cris and popwerpc.
> cris do not support relocatable kernels and is thus not
> impacted by this change.
> 
> Fix INIT_TASK_DATA_SECTION() to specify load offset like
> all other output sections.
> 
> Reported-by: Sean MacLennan <smaclennan@pikatech.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> 
> On the assumption that Sean reports that it fixes
> the warnings/boot issue here is a real patch.
> 
> Ben - will you take it via the popwerpc tree
> or shall I ask Michal to take it via kbuild?
> 
> 	Sam
> 
>  include/asm-generic/vmlinux.lds.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h
> b/include/asm-generic/vmlinux.lds.h index 48c5299..cdfff74 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -435,7 +435,7 @@
>   */
>  #define
> INIT_TASK_DATA_SECTION(align)
> \ . = ALIGN(align);						\
> -	.data..init_task :
> {						\
> +	.data..init_task :  AT(ADDR(.data..init_task) - LOAD_OFFSET)
> {	\
> INIT_TASK_DATA(align)					\ }
>  

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-23 22:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-22 23:55 [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
2010-07-23  0:04 ` Sean MacLennan
  -- strict thread matches above, loose matches on Subject: below --
2010-06-28  4:59 section .data..init_task Sean MacLennan
2010-07-13  0:34 ` Sean MacLennan
2010-07-13  9:50   ` [ Sam Ravnborg
2010-07-22 23:50     ` [PATCH] powerpc: fix .data..init_task output section Sean MacLennan
2010-07-23 13:58       ` Sam Ravnborg
2010-07-23 22:16         ` Benjamin Herrenschmidt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.