* Re: [PATCH] mount.nilfs2: add "uhelper=" option
[not found] ` <87d3ueej51.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
@ 2010-07-23 14:33 ` Ryusuke Konishi
0 siblings, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2010-07-23 14:33 UTC (permalink / raw)
To: jir-hfpbi5WX9J54Eiagz67IpQ
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA,
konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg
On Fri, 23 Jul 2010 16:45:30 +0900, Jiro SEKIBA wrote:
>
> Standard mount command takes uhelper=<helper_name> option to tell the mount
> is under <helper_name> control. When this option is specified,
> umount.<helper_name> is called on unmount time.
>
> This option is used when mount is triggered by udisks. udisks is a dbus
> service daemon. The service is used by Palimpsest. To controll nilfs2
> partition from palimpsest, interpret the option is required.
>
> Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
> ---
Very interesting. If nilfs becomes available on Palimsest, it will
make levels of entry lower.
I took this one and applied to nilfs-utils.git.
If you need any additional help for this, please let me know.
BTW, I didn't know the role of the struct string_opt_map until now.
It looks helpful also for other virtual options.
Thanks,
Ryusuke Konishi
> sbin/mount/mount_opts.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/sbin/mount/mount_opts.c b/sbin/mount/mount_opts.c
> index 9db599f..396b41f 100644
> --- a/sbin/mount/mount_opts.c
> +++ b/sbin/mount/mount_opts.c
> @@ -98,7 +98,7 @@ static const struct opt_map opt_map[] = {
> };
>
> static const char *opt_loopdev, *opt_vfstype, *opt_offset, *opt_encryption,
> - *opt_speed, *opt_comment;
> + *opt_speed, *opt_comment, *opt_uhelper;
>
> static struct string_opt_map {
> char *tag;
> @@ -111,6 +111,7 @@ static struct string_opt_map {
> { "encryption=", 0, &opt_encryption },
> { "speed=", 0, &opt_speed },
> { "comment=", 1, &opt_comment },
> + { "uhelper=", 0, &opt_uhelper },
> { NULL, 0, NULL }
> };
>
> --
> 1.5.6.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mount.nilfs2: add "uhelper=" option
[not found] ` <876306y7ha.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
@ 2010-07-23 7:42 ` Jiro SEKIBA
0 siblings, 0 replies; 3+ messages in thread
From: Jiro SEKIBA @ 2010-07-23 7:42 UTC (permalink / raw)
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA, Ryusuke Konishi, Ryusuke Konishi
Grr I'm sorry. please ignore this patch.
I sent the wrong one.
I'll resend the correct one soon.
--
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
At Fri, 23 Jul 2010 16:37:05 +0900,
Jiro SEKIBA wrote:
>
> Hi,
>
> This is a patch against mount.nilfs2.
>
> I'm trying to add nilfs2 support on several software stack to control
> nilfs2 partition from palimpsest(gnome-disk-utility). And found
> that the option is required to handled properly.
>
> Standard mount command takes uhelper=<helper_name> option to tell the mount
> is under <helper_name> control. When this option is specified,
> umount.<helper_name> is called on unmount time.
>
> This option is used when mount is triggered by udisks. udisks is a dbus
> service daemon. The service is used by Palimpsest. To controll nilfs2
> partition from palimpsest, interpret the option is required.
>
> Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
> ---
> sbin/mount/mount_opts.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/sbin/mount/mount_opts.c b/sbin/mount/mount_opts.c
> index 9db599f..0c6ca79 100644
> --- a/sbin/mount/mount_opts.c
> +++ b/sbin/mount/mount_opts.c
> @@ -98,7 +98,7 @@ static const struct opt_map opt_map[] = {
> };
>
> static const char *opt_loopdev, *opt_vfstype, *opt_offset, *opt_encryption,
> - *opt_speed, *opt_comment;
> + *opt_speed, *opt_comment, *opt_uhelper;
>
> static struct string_opt_map {
> char *tag;
> @@ -111,6 +111,7 @@ static struct string_opt_map {
> { "encryption=", 0, &opt_encryption },
> { "speed=", 0, &opt_speed },
> { "comment=", 1, &opt_comment },
> + { "uhelper=", 1, &opt_uhelper },
> { NULL, 0, NULL }
> };
>
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mount.nilfs2: add "uhelper=" option
@ 2010-07-23 7:37 Jiro SEKIBA
[not found] ` <876306y7ha.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jiro SEKIBA @ 2010-07-23 7:37 UTC (permalink / raw)
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA; +Cc: Ryusuke Konishi, Ryusuke Konishi
Hi,
This is a patch against mount.nilfs2.
I'm trying to add nilfs2 support on several software stack to control
nilfs2 partition from palimpsest(gnome-disk-utility). And found
that the option is required to handled properly.
Standard mount command takes uhelper=<helper_name> option to tell the mount
is under <helper_name> control. When this option is specified,
umount.<helper_name> is called on unmount time.
This option is used when mount is triggered by udisks. udisks is a dbus
service daemon. The service is used by Palimpsest. To controll nilfs2
partition from palimpsest, interpret the option is required.
Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
---
sbin/mount/mount_opts.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sbin/mount/mount_opts.c b/sbin/mount/mount_opts.c
index 9db599f..0c6ca79 100644
--- a/sbin/mount/mount_opts.c
+++ b/sbin/mount/mount_opts.c
@@ -98,7 +98,7 @@ static const struct opt_map opt_map[] = {
};
static const char *opt_loopdev, *opt_vfstype, *opt_offset, *opt_encryption,
- *opt_speed, *opt_comment;
+ *opt_speed, *opt_comment, *opt_uhelper;
static struct string_opt_map {
char *tag;
@@ -111,6 +111,7 @@ static struct string_opt_map {
{ "encryption=", 0, &opt_encryption },
{ "speed=", 0, &opt_speed },
{ "comment=", 1, &opt_comment },
+ { "uhelper=", 1, &opt_uhelper },
{ NULL, 0, NULL }
};
--
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-23 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87d3ueej51.wl%jir@sekiba.com>
[not found] ` <87d3ueej51.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-07-23 14:33 ` [PATCH] mount.nilfs2: add "uhelper=" option Ryusuke Konishi
2010-07-23 7:37 Jiro SEKIBA
[not found] ` <876306y7ha.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-07-23 7:42 ` Jiro SEKIBA
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.