* [patch -next] V4L: media/IR: testing the wrong variable
@ 2010-07-23 10:08 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-07-23 10:08 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jarod Wilson, Arnd Bergmann, linux-media, kernel-janitors
There is a typo here. We meant to test "rbuf" instead of "drv". We
already tested "drv" earlier.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c
index 178bc5b..870000e 100644
--- a/drivers/media/IR/ir-lirc-codec.c
+++ b/drivers/media/IR/ir-lirc-codec.c
@@ -192,7 +192,7 @@ static int ir_lirc_register(struct input_dev *input_dev)
return rc;
rbuf = kzalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
- if (!drv)
+ if (!rbuf)
goto rbuf_alloc_failed;
rc = lirc_buffer_init(rbuf, sizeof(int), LIRCBUF_SIZE);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch -next] V4L: media/IR: testing the wrong variable
@ 2010-07-23 10:08 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-07-23 10:08 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jarod Wilson, Arnd Bergmann, linux-media, kernel-janitors
There is a typo here. We meant to test "rbuf" instead of "drv". We
already tested "drv" earlier.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c
index 178bc5b..870000e 100644
--- a/drivers/media/IR/ir-lirc-codec.c
+++ b/drivers/media/IR/ir-lirc-codec.c
@@ -192,7 +192,7 @@ static int ir_lirc_register(struct input_dev *input_dev)
return rc;
rbuf = kzalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
- if (!drv)
+ if (!rbuf)
goto rbuf_alloc_failed;
rc = lirc_buffer_init(rbuf, sizeof(int), LIRCBUF_SIZE);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -next] V4L: media/IR: testing the wrong variable
2010-07-23 10:08 ` Dan Carpenter
@ 2010-07-23 13:16 ` Jarod Wilson
-1 siblings, 0 replies; 4+ messages in thread
From: Jarod Wilson @ 2010-07-23 13:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Arnd Bergmann, linux-media, kernel-janitors
On Fri, Jul 23, 2010 at 12:08:26PM +0200, Dan Carpenter wrote:
> There is a typo here. We meant to test "rbuf" instead of "drv". We
> already tested "drv" earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Gah. I swear that got fixed once already... Thanks!
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -next] V4L: media/IR: testing the wrong variable
@ 2010-07-23 13:16 ` Jarod Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Jarod Wilson @ 2010-07-23 13:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Arnd Bergmann, linux-media, kernel-janitors
On Fri, Jul 23, 2010 at 12:08:26PM +0200, Dan Carpenter wrote:
> There is a typo here. We meant to test "rbuf" instead of "drv". We
> already tested "drv" earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Gah. I swear that got fixed once already... Thanks!
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-23 13:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-23 10:08 [patch -next] V4L: media/IR: testing the wrong variable Dan Carpenter
2010-07-23 10:08 ` Dan Carpenter
2010-07-23 13:16 ` Jarod Wilson
2010-07-23 13:16 ` Jarod Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.