* [PATCH] net/rose: Use GFP_ATOMIC
@ 2010-07-31 9:56 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2010-07-31 9:56 UTC (permalink / raw)
To: Ralf Baechle, David S. Miller, linux-hams, linux-kernel, netdev,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
two locks are held within the body of the function.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@ identifier f; @@
*f(...,GFP_ATOMIC,...)
... when != spin_unlock(...)
when != read_unlock(...)
when != write_unlock(...)
when != read_unlock_irq(...)
when != write_unlock_irq(...)
when != read_unlock_irqrestore(...)
when != write_unlock_irqrestore(...)
when != spin_unlock_irq(...)
when != spin_unlock_irqrestore(...)
*f(...,GFP_KERNEL,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/rose/rose_route.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index cbc244a..b4fdaac 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -109,7 +109,9 @@ static int __must_check rose_add_node(struct rose_route_struct *rose_route,
init_timer(&rose_neigh->t0timer);
if (rose_route->ndigis != 0) {
- if ((rose_neigh->digipeat = kmalloc(sizeof(ax25_digi), GFP_KERNEL)) == NULL) {
+ rose_neigh->digipeat =
+ kmalloc(sizeof(ax25_digi), GFP_ATOMIC);
+ if (rose_neigh->digipeat == NULL) {
kfree(rose_neigh);
res = -ENOMEM;
goto out;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net/rose: Use GFP_ATOMIC
@ 2010-07-31 9:56 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2010-07-31 9:56 UTC (permalink / raw)
To: Ralf Baechle, David S. Miller, linux-hams, linux-kernel, netdev,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
two locks are held within the body of the function.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@ identifier f; @@
*f(...,GFP_ATOMIC,...)
... when != spin_unlock(...)
when != read_unlock(...)
when != write_unlock(...)
when != read_unlock_irq(...)
when != write_unlock_irq(...)
when != read_unlock_irqrestore(...)
when != write_unlock_irqrestore(...)
when != spin_unlock_irq(...)
when != spin_unlock_irqrestore(...)
*f(...,GFP_KERNEL,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/rose/rose_route.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index cbc244a..b4fdaac 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -109,7 +109,9 @@ static int __must_check rose_add_node(struct rose_route_struct *rose_route,
init_timer(&rose_neigh->t0timer);
if (rose_route->ndigis != 0) {
- if ((rose_neigh->digipeat = kmalloc(sizeof(ax25_digi), GFP_KERNEL)) = NULL) {
+ rose_neigh->digipeat + kmalloc(sizeof(ax25_digi), GFP_ATOMIC);
+ if (rose_neigh->digipeat = NULL) {
kfree(rose_neigh);
res = -ENOMEM;
goto out;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/rose: Use GFP_ATOMIC
2010-07-31 9:56 ` Julia Lawall
@ 2010-08-01 7:32 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-01 7:32 UTC (permalink / raw)
To: julia; +Cc: ralf, linux-hams, linux-kernel, netdev, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sat, 31 Jul 2010 11:56:39 +0200 (CEST)
> The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
> two locks are held within the body of the function.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/rose: Use GFP_ATOMIC
@ 2010-08-01 7:32 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-01 7:32 UTC (permalink / raw)
To: julia; +Cc: ralf, linux-hams, linux-kernel, netdev, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sat, 31 Jul 2010 11:56:39 +0200 (CEST)
> The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
> two locks are held within the body of the function.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-01 7:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-31 9:56 [PATCH] net/rose: Use GFP_ATOMIC Julia Lawall
2010-07-31 9:56 ` Julia Lawall
2010-08-01 7:32 ` David Miller
2010-08-01 7:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.