* [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
@ 2010-07-30 14:25 ` David Howells
0 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2010-07-30 14:25 UTC (permalink / raw)
To: torvalds-3NddpPZAyC0, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, Jeff Layton
Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
module init routine in case of error, and so may have been discarded during
linkage.
Signed-off-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/cifs/dns_resolve.c | 2 +-
fs/cifs/dns_resolve.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
index 49315cb..853a968 100644
--- a/fs/cifs/dns_resolve.c
+++ b/fs/cifs/dns_resolve.c
@@ -227,7 +227,7 @@ failed_put_cred:
return ret;
}
-void __exit cifs_exit_dns_resolver(void)
+void cifs_exit_dns_resolver(void)
{
key_revoke(dns_resolver_cache->thread_keyring);
unregister_key_type(&key_type_dns_resolver);
diff --git a/fs/cifs/dns_resolve.h b/fs/cifs/dns_resolve.h
index 26b9eaa..5d7f291 100644
--- a/fs/cifs/dns_resolve.h
+++ b/fs/cifs/dns_resolve.h
@@ -25,7 +25,7 @@
#ifdef __KERNEL__
extern int __init cifs_init_dns_resolver(void);
-extern void __exit cifs_exit_dns_resolver(void);
+extern void cifs_exit_dns_resolver(void);
extern int dns_resolve_server_name_to_ip(const char *unc, char **ip_addr);
#endif /* KERNEL */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
@ 2010-07-30 14:25 ` David Howells
0 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2010-07-30 14:25 UTC (permalink / raw)
To: torvalds, akpm; +Cc: linux-cifs, linux-kernel, David Howells, Jeff Layton
Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
module init routine in case of error, and so may have been discarded during
linkage.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
---
fs/cifs/dns_resolve.c | 2 +-
fs/cifs/dns_resolve.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
index 49315cb..853a968 100644
--- a/fs/cifs/dns_resolve.c
+++ b/fs/cifs/dns_resolve.c
@@ -227,7 +227,7 @@ failed_put_cred:
return ret;
}
-void __exit cifs_exit_dns_resolver(void)
+void cifs_exit_dns_resolver(void)
{
key_revoke(dns_resolver_cache->thread_keyring);
unregister_key_type(&key_type_dns_resolver);
diff --git a/fs/cifs/dns_resolve.h b/fs/cifs/dns_resolve.h
index 26b9eaa..5d7f291 100644
--- a/fs/cifs/dns_resolve.h
+++ b/fs/cifs/dns_resolve.h
@@ -25,7 +25,7 @@
#ifdef __KERNEL__
extern int __init cifs_init_dns_resolver(void);
-extern void __exit cifs_exit_dns_resolver(void);
+extern void cifs_exit_dns_resolver(void);
extern int dns_resolve_server_name_to_ip(const char *unc, char **ip_addr);
#endif /* KERNEL */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
2010-07-30 14:25 ` David Howells
@ 2010-08-01 12:40 ` Uwe Kleine-König
-1 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2010-08-01 12:40 UTC (permalink / raw)
To: David Howells
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
linux-cifs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Jeff Layton
Hello,
On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote:
> Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
> module init routine in case of error, and so may have been discarded during
> linkage.
From time to time I think about introducing something like
__init_or_exit that puts a function into .init.text if .exit.text is
discarded. Is it worth the effort?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
@ 2010-08-01 12:40 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2010-08-01 12:40 UTC (permalink / raw)
To: David Howells; +Cc: torvalds, akpm, linux-cifs, linux-kernel, Jeff Layton
Hello,
On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote:
> Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
> module init routine in case of error, and so may have been discarded during
> linkage.
>From time to time I think about introducing something like
__init_or_exit that puts a function into .init.text if .exit.text is
discarded. Is it worth the effort?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
2010-07-30 14:25 ` David Howells
@ 2010-08-02 9:17 ` David Howells
-1 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2010-08-02 9:17 UTC (permalink / raw)
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
linux-cifs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Jeff Layton
Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> From time to time I think about introducing something like
> __init_or_exit that puts a function into .init.text if .exit.text is
> discarded. Is it worth the effort?
It might be worth including __exit stuff in __init if we would otherwise have
discarded it. Otherwise there's liable to be a bunch of stuff that we could
otherwise discard left hanging around permanently. But your suggestion would
work too.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
@ 2010-08-02 9:17 ` David Howells
0 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2010-08-02 9:17 UTC (permalink / raw)
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=
Cc: dhowells, torvalds, akpm, linux-cifs, linux-kernel, Jeff Layton
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> From time to time I think about introducing something like
> __init_or_exit that puts a function into .init.text if .exit.text is
> discarded. Is it worth the effort?
It might be worth including __exit stuff in __init if we would otherwise have
discarded it. Otherwise there's liable to be a bunch of stuff that we could
otherwise discard left hanging around permanently. But your suggestion would
work too.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-02 9:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-30 14:25 [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver() David Howells
2010-07-30 14:25 ` David Howells
[not found] ` <20100730142519.18287.22053.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-08-01 12:40 ` Uwe Kleine-König
2010-08-01 12:40 ` Uwe Kleine-König
[not found] ` <20100801124059.GA7977-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-08-02 9:17 ` David Howells
2010-08-02 9:17 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.