* [PATCH] OMAP2: powerdomain: Add break in switch statement
@ 2010-07-09 7:40 ` Thomas Weber
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Weber @ 2010-07-09 7:40 UTC (permalink / raw)
To: linux-omap
Cc: Thomas Weber, Tony Lindgren, Russell King, Paul Walmsley,
Kevin Hilman, linux-arm-kernel, linux-kernel
Add a missing break at end of switch statement. At the moment it is a
fall through to WARN_ON(1) and return -EEXIST.
Signed-off-by: Thomas Weber <weber@corscience.de>
---
arch/arm/mach-omap2/powerdomain.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index a2904aa..6527ec3 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -875,6 +875,7 @@ int pwrdm_read_mem_retst(struct powerdomain *pwrdm, u8 bank)
break;
case 4:
m = OMAP_MEM4_RETSTATE_MASK;
+ break;
default:
WARN_ON(1); /* should never happen */
return -EEXIST;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] OMAP2: powerdomain: Add break in switch statement
@ 2010-07-09 7:40 ` Thomas Weber
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Weber @ 2010-07-09 7:40 UTC (permalink / raw)
To: linux-arm-kernel
Add a missing break at end of switch statement. At the moment it is a
fall through to WARN_ON(1) and return -EEXIST.
Signed-off-by: Thomas Weber <weber@corscience.de>
---
arch/arm/mach-omap2/powerdomain.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index a2904aa..6527ec3 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -875,6 +875,7 @@ int pwrdm_read_mem_retst(struct powerdomain *pwrdm, u8 bank)
break;
case 4:
m = OMAP_MEM4_RETSTATE_MASK;
+ break;
default:
WARN_ON(1); /* should never happen */
return -EEXIST;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] OMAP2: powerdomain: Add break in switch statement
2010-07-09 7:40 ` Thomas Weber
@ 2010-07-12 20:21 ` Paul Walmsley
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2010-07-12 20:21 UTC (permalink / raw)
To: Thomas Weber, Tony Lindgren
Cc: linux-omap, Russell King, Kevin Hilman, linux-arm-kernel, linux-kernel
On Fri, 9 Jul 2010, Thomas Weber wrote:
> Add a missing break at end of switch statement. At the moment it is a
> fall through to WARN_ON(1) and return -EEXIST.
>
> Signed-off-by: Thomas Weber <weber@corscience.de>
Thanks Thomas.
Tony, this is
Acked-by: Paul Walmsley <paul@pwsan.com>
if you want it for .36; otherwise, can queue it for .37 here.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP2: powerdomain: Add break in switch statement
@ 2010-07-12 20:21 ` Paul Walmsley
0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2010-07-12 20:21 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 9 Jul 2010, Thomas Weber wrote:
> Add a missing break at end of switch statement. At the moment it is a
> fall through to WARN_ON(1) and return -EEXIST.
>
> Signed-off-by: Thomas Weber <weber@corscience.de>
Thanks Thomas.
Tony, this is
Acked-by: Paul Walmsley <paul@pwsan.com>
if you want it for .36; otherwise, can queue it for .37 here.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] OMAP2: powerdomain: Add break in switch statement
2010-07-12 20:21 ` Paul Walmsley
@ 2010-08-03 7:22 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2010-08-03 7:22 UTC (permalink / raw)
To: Paul Walmsley
Cc: Thomas Weber, linux-omap, Russell King, Kevin Hilman,
linux-arm-kernel, linux-kernel
* Paul Walmsley <paul@pwsan.com> [100712 23:14]:
> On Fri, 9 Jul 2010, Thomas Weber wrote:
>
> > Add a missing break at end of switch statement. At the moment it is a
> > fall through to WARN_ON(1) and return -EEXIST.
> >
> > Signed-off-by: Thomas Weber <weber@corscience.de>
>
> Thanks Thomas.
>
> Tony, this is
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> if you want it for .36; otherwise, can queue it for .37 here.
Thanks, I've added it into omap-for-linus.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP2: powerdomain: Add break in switch statement
@ 2010-08-03 7:22 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2010-08-03 7:22 UTC (permalink / raw)
To: linux-arm-kernel
* Paul Walmsley <paul@pwsan.com> [100712 23:14]:
> On Fri, 9 Jul 2010, Thomas Weber wrote:
>
> > Add a missing break at end of switch statement. At the moment it is a
> > fall through to WARN_ON(1) and return -EEXIST.
> >
> > Signed-off-by: Thomas Weber <weber@corscience.de>
>
> Thanks Thomas.
>
> Tony, this is
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> if you want it for .36; otherwise, can queue it for .37 here.
Thanks, I've added it into omap-for-linus.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-03 7:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-09 7:40 [PATCH] OMAP2: powerdomain: Add break in switch statement Thomas Weber
2010-07-09 7:40 ` Thomas Weber
2010-07-12 20:21 ` Paul Walmsley
2010-07-12 20:21 ` Paul Walmsley
2010-08-03 7:22 ` Tony Lindgren
2010-08-03 7:22 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.