[PATCH for linux-next] V4L/DVB: v4l2: v4l2-ctrls.c needs kzalloc/kfree prototype

[PATCH for linux-next] V4L/DVB: v4l2: v4l2-ctrls.c needs kzalloc/kfree prototype

[Laurent Riffard]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 996 bytes --]

linux-next 20100807 failed to compile:

drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_init’:
drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function ‘kzalloc’
drivers/media/video/v4l2-ctrls.c:767: warning: assignment makes pointer from integer without a cast
drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_free’:
drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function ‘kfree’
...

---
  drivers/media/video/v4l2-ctrls.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
index 84c1a53..951c8c6 100644
--- a/drivers/media/video/v4l2-ctrls.c
+++ b/drivers/media/video/v4l2-ctrls.c
@@ -19,6 +19,7 @@
   */

  #include <linux/ctype.h>
+#include <linux/slab.h>         /* for kzalloc/kfree */
  #include <media/v4l2-ioctl.h>
  #include <media/v4l2-device.h>
  #include <media/v4l2-ctrls.h>
-- 
1.7.2.1.26.gbb89e

Re: [PATCH for linux-next] V4L/DVB: v4l2: v4l2-ctrls.c needs kzalloc/kfree prototype

[Hans Verkuil]

On Saturday 07 August 2010 17:47:57 Laurent Riffard wrote:
> linux-next 20100807 failed to compile:
> 
> drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_init’:
> drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function ‘kzalloc’
> drivers/media/video/v4l2-ctrls.c:767: warning: assignment makes pointer from integer without a cast
> drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_free’:
> drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function ‘kfree’

Thanks for the notification, but I discovered it myself already and posted a
pull request fixing this yesterday.

Regards,

	Hans

> ...
> 
> ---
>   drivers/media/video/v4l2-ctrls.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
> index 84c1a53..951c8c6 100644
> --- a/drivers/media/video/v4l2-ctrls.c
> +++ b/drivers/media/video/v4l2-ctrls.c
> @@ -19,6 +19,7 @@
>    */
> 
>   #include <linux/ctype.h>
> +#include <linux/slab.h>         /* for kzalloc/kfree */
>   #include <media/v4l2-ioctl.h>
>   #include <media/v4l2-device.h>
>   #include <media/v4l2-ctrls.h>
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco