All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Zummo <a.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: wellsk40@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Durgesh Pattamatta <durgesh.pattamatta@nxp.com>
Subject: Re: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver for  the LPC32XX SoC
Date: Tue, 10 Aug 2010 15:34:48 +0200	[thread overview]
Message-ID: <20100810153448.17443314@linux.lan.towertech.it> (raw)
In-Reply-To: <1281370650-29520-2-git-send-email-wellsk40@gmail.com>

On Mon,  9 Aug 2010 09:17:29 -0700
wellsk40@gmail.com wrote:

> +
> +	retval = request_irq(rtc->irq, lpc32xx_rtc_alarm_interrupt,
> +		IRQF_DISABLED, "rtcalarm", rtc);
> +	if (retval < 0) {
> +		dev_err(&pdev->dev, "Can't request interrupt\n");
> +		goto err_free_irq;
> +	}

 if the driver can work without the alarm irq you
 can convert this to a non fatal warning.

 having an rtc without alarms is much better than having none.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


WARNING: multiple messages have this Message-ID (diff)
From: a.zummo@towertech.it (Alessandro Zummo)
To: linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver for  the LPC32XX SoC
Date: Tue, 10 Aug 2010 15:34:48 +0200	[thread overview]
Message-ID: <20100810153448.17443314@linux.lan.towertech.it> (raw)
In-Reply-To: <1281370650-29520-2-git-send-email-wellsk40@gmail.com>

On Mon,  9 Aug 2010 09:17:29 -0700
wellsk40 at gmail.com wrote:

> +
> +	retval = request_irq(rtc->irq, lpc32xx_rtc_alarm_interrupt,
> +		IRQF_DISABLED, "rtcalarm", rtc);
> +	if (retval < 0) {
> +		dev_err(&pdev->dev, "Can't request interrupt\n");
> +		goto err_free_irq;
> +	}

 if the driver can work without the alarm irq you
 can convert this to a non fatal warning.

 having an rtc without alarms is much better than having none.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

  parent reply	other threads:[~2010-08-10 13:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 16:17 RTC: LPC32xx: Introduce RTC driver for the LPC32xx wellsk40
2010-08-09 16:17 ` wellsk40 at gmail.com
2010-08-09 16:17 ` [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver for the LPC32XX SoC wellsk40
2010-08-09 16:17   ` wellsk40 at gmail.com
2010-08-10  1:55   ` [rtc-linux] " Wan ZongShun
2010-08-10  1:55     ` Wan ZongShun
2010-08-10 19:08     ` Kevin Wells
2010-08-10 19:08       ` Kevin Wells
2010-08-11  1:40       ` Wan ZongShun
2010-08-11  1:40         ` Wan ZongShun
2010-08-10 10:25   ` Wolfram Sang
2010-08-10 10:25     ` Wolfram Sang
2010-08-10 12:00     ` Uwe Kleine-König
2010-08-10 12:00       ` Uwe Kleine-König
2010-08-10 13:40       ` Wolfram Sang
2010-08-10 13:40         ` Wolfram Sang
2010-08-10 19:08     ` Kevin Wells
2010-08-10 19:08       ` Kevin Wells
2010-08-10 13:34   ` Alessandro Zummo [this message]
2010-08-10 13:34     ` Alessandro Zummo
2010-08-10 19:08     ` Kevin Wells
2010-08-10 19:08       ` Kevin Wells
2010-08-09 16:17 ` [PATCH 2/2] rtc: Add support in Makefile/Kconfig for the LPC32XX RTC wellsk40
2010-08-09 16:17   ` wellsk40 at gmail.com
2010-08-10  1:45   ` [rtc-linux] " Wan ZongShun
2010-08-10  1:45     ` Wan ZongShun
2010-08-10  9:25     ` Wolfram Sang
2010-08-10  9:25       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100810153448.17443314@linux.lan.towertech.it \
    --to=a.zummo@towertech.it \
    --cc=durgesh.pattamatta@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=wellsk40@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.