* [patch] dbgp: cleanup: remove unneeded check
@ 2010-08-12 7:40 Dan Carpenter
2010-08-25 11:57 ` stephane duverger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-08-12 7:40 UTC (permalink / raw)
To: kernel-janitors
len is always greater than or equal to zero here. First of all, it's
type is unsigned and also we only assign it numbers which are greater
than or equal to zero.
Removing the check lets us pull everything in an indent level.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/usb/gadget/dbgp.c b/drivers/usb/gadget/dbgp.c
index 0ed50a2..abe4a2e 100644
--- a/drivers/usb/gadget/dbgp.c
+++ b/drivers/usb/gadget/dbgp.c
@@ -386,15 +386,13 @@ static int dbgp_setup(struct usb_gadget *gadget,
} else
goto fail;
- if (len >= 0) {
- req->length = min(length, len);
- req->zero = len < req->length;
- if (data && req->length)
- memcpy(req->buf, data, req->length);
-
- req->complete = dbgp_setup_complete;
- return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
- }
+ req->length = min(length, len);
+ req->zero = len < req->length;
+ if (data && req->length)
+ memcpy(req->buf, data, req->length);
+
+ req->complete = dbgp_setup_complete;
+ return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
fail:
dev_dbg(&dbgp.gadget->dev,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] dbgp: cleanup: remove unneeded check
2010-08-12 7:40 [patch] dbgp: cleanup: remove unneeded check Dan Carpenter
@ 2010-08-25 11:57 ` stephane duverger
0 siblings, 0 replies; 2+ messages in thread
From: stephane duverger @ 2010-08-25 11:57 UTC (permalink / raw)
To: kernel-janitors
Acked-by: Stephane duverger <stephane.duverger@gmail.com>
> len is always greater than or equal to zero here. First of all, it's
> type is unsigned and also we only assign it numbers which are greater
> than or equal to zero.
>
> Removing the check lets us pull everything in an indent level.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/usb/gadget/dbgp.c b/drivers/usb/gadget/dbgp.c
> index 0ed50a2..abe4a2e 100644
> --- a/drivers/usb/gadget/dbgp.c
> +++ b/drivers/usb/gadget/dbgp.c
> @@ -386,15 +386,13 @@ static int dbgp_setup(struct usb_gadget *gadget,
> } else
> goto fail;
>
> - if (len >= 0) {
> - req->length = min(length, len);
> - req->zero = len < req->length;
> - if (data && req->length)
> - memcpy(req->buf, data, req->length);
> -
> - req->complete = dbgp_setup_complete;
> - return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
> - }
> + req->length = min(length, len);
> + req->zero = len < req->length;
> + if (data && req->length)
> + memcpy(req->buf, data, req->length);
> +
> + req->complete = dbgp_setup_complete;
> + return usb_ep_queue(gadget->ep0, req, GFP_ATOMIC);
>
> fail:
> dev_dbg(&dbgp.gadget->dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-25 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-12 7:40 [patch] dbgp: cleanup: remove unneeded check Dan Carpenter
2010-08-25 11:57 ` stephane duverger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.