From: Andrew Morton <akpm@linux-foundation.org> To: Helge Deller <deller@gmx.de> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>, Manfred Spraul <manfred@colorfullife.com> Subject: Re: [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm Date: Thu, 12 Aug 2010 13:10:05 -0700 [thread overview] Message-ID: <20100812131005.e466a9fd.akpm@linux-foundation.org> (raw) In-Reply-To: <20100811201345.GA11304@p100.box> On Wed, 11 Aug 2010 22:13:45 +0200 Helge Deller <deller@gmx.de> wrote: > The kernel currently provides no functionality to analyze the RSS > and swap space usage of each individual sysvipc shared memory segment. > > This patch add this info for each existing shm segment by extending > the output of /proc/sysvipc/shm by two columns for RSS and swap. > > Since shmctl(SHM_INFO) already provides a similiar calculation (it > currently sums up all RSS/swap info for all segments), I did split > out a static function which is now used by the /proc/sysvipc/shm > output and shmctl(SHM_INFO). > I suppose that could be useful, although it would be most interesting to hear why _you_ consider it useful? But is it useful enough to risk breaking existing code which parses that file? The risk is not great, but it's there. > > --- > > shm.c | 63 ++++++++++++++++++++++++++++++++++++++++++--------------------- > 1 file changed, 42 insertions(+), 21 deletions(-) > > > diff --git a/ipc/shm.c b/ipc/shm.c > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -108,7 +108,11 @@ void __init shm_init (void) > { > shm_init_ns(&init_ipc_ns); > ipc_init_proc_interface("sysvipc/shm", > - " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime\n", > +#if BITS_PER_LONG <= 32 > + " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime RSS swap\n", > +#else > + " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime RSS swap\n", This adds 11 new spaces between "perms" and "size", only on 64-bit machines. That was unchangelogged and adds another (smaller) risk of breaking things. Please explain. This interface is really old and crufty and horrid, but I guess that there's not a lot we can do about that :(
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org> To: Helge Deller <deller@gmx.de> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>, Manfred Spraul <manfred@colorfullife.com> Subject: Re: [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm Date: Thu, 12 Aug 2010 13:10:05 -0700 [thread overview] Message-ID: <20100812131005.e466a9fd.akpm@linux-foundation.org> (raw) In-Reply-To: <20100811201345.GA11304@p100.box> On Wed, 11 Aug 2010 22:13:45 +0200 Helge Deller <deller@gmx.de> wrote: > The kernel currently provides no functionality to analyze the RSS > and swap space usage of each individual sysvipc shared memory segment. > > This patch add this info for each existing shm segment by extending > the output of /proc/sysvipc/shm by two columns for RSS and swap. > > Since shmctl(SHM_INFO) already provides a similiar calculation (it > currently sums up all RSS/swap info for all segments), I did split > out a static function which is now used by the /proc/sysvipc/shm > output and shmctl(SHM_INFO). > I suppose that could be useful, although it would be most interesting to hear why _you_ consider it useful? But is it useful enough to risk breaking existing code which parses that file? The risk is not great, but it's there. > > --- > > shm.c | 63 ++++++++++++++++++++++++++++++++++++++++++--------------------- > 1 file changed, 42 insertions(+), 21 deletions(-) > > > diff --git a/ipc/shm.c b/ipc/shm.c > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -108,7 +108,11 @@ void __init shm_init (void) > { > shm_init_ns(&init_ipc_ns); > ipc_init_proc_interface("sysvipc/shm", > - " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime\n", > +#if BITS_PER_LONG <= 32 > + " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime RSS swap\n", > +#else > + " key shmid perms size cpid lpid nattch uid gid cuid cgid atime dtime ctime RSS swap\n", This adds 11 new spaces between "perms" and "size", only on 64-bit machines. That was unchangelogged and adds another (smaller) risk of breaking things. Please explain. This interface is really old and crufty and horrid, but I guess that there's not a lot we can do about that :( -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-12 20:11 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-11 20:13 [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm Helge Deller 2010-08-11 20:13 ` Helge Deller 2010-08-12 20:10 ` Andrew Morton [this message] 2010-08-12 20:10 ` Andrew Morton 2010-08-12 21:33 ` Helge Deller 2010-08-12 21:33 ` Helge Deller 2010-08-12 21:44 ` Andrew Morton 2010-08-12 21:44 ` Andrew Morton 2010-08-12 22:40 ` Hugh Dickins 2010-08-12 22:40 ` Hugh Dickins 2010-08-13 14:59 ` [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm (v2) Helge Deller 2010-08-13 14:59 ` Helge Deller 2010-08-13 19:52 ` [PATCH][RFC] Fix up rss/swap usage of shm segments in /proc/pid/smaps Helge Deller 2010-08-13 19:52 ` Helge Deller 2010-08-13 22:45 ` Hugh Dickins 2010-08-13 22:45 ` Hugh Dickins 2010-08-16 20:21 ` Helge Deller 2010-08-16 20:21 ` Helge Deller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100812131005.e466a9fd.akpm@linux-foundation.org \ --to=akpm@linux-foundation.org \ --cc=deller@gmx.de \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=manfred@colorfullife.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.