All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: "ext Gadiyar, Anand" <gadiyar-l0cyMroinI0@public.gmane.org>
Cc: "Balbi Felipe (Nokia-MS/Helsinki)"
	<felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
	"Munegowda,
	Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3
Date: Fri, 20 Aug 2010 09:13:22 +0300	[thread overview]
Message-ID: <20100820061322.GG15196@nokia.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0324222B65-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>

On Fri, Aug 20, 2010 at 07:59:16AM +0200, ext Gadiyar, Anand wrote:
>Felipe Balbi wrote:
>> On Thu, Aug 19, 2010 at 01:49:36AM +0200, ext Keshava Munegowda wrote:
>> >@@ -126,6 +126,14 @@ config USB_EHCI_MXC
>> > 	---help---
>> > 	  Variation of ARC USB block used in some Freescale chips.
>> >
>> >+config USB_EHCI_HCD_OMAP3
>> >+	bool "EHCI support for OMAP3 and later chips"
>> >+	depends on USB_EHCI_HCD && (ARCH_OMAP3 || ARCH_OMAP4)
>>
>> this line doesn't scale. When we have another omap release this will
>> become e.g. ARCH_OMAP3 || ARCH_OMAP4 || ARCH_OMAP5 || ARCH_OMAP6 etc
>> etc, so instead of depending on ARCH_OMAPX, depend only on ARCH_OMAP and
>> make the architecture select the USB_ARCH_HAS_EHCI like this:
>
>ARCH_OMAP includes OMAP1/2, and these chips do not have any EHCI controllers.
>
>Is this okay?

as long as noone selects USB_ARCH_HAS_EHCI for omap1/2 it's fine.

-- 
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-08-20  6:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 23:49 [PATCH 0/7] usb: ehci: omap: Adding OMAP4 support Keshava Munegowda
2010-08-18 23:49 ` [RFC] [PATCH 1/7] usb: ehci-omap: Add the HSUSB base address Keshava Munegowda
     [not found]   ` <1282175377-2784-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49     ` [RFC] [PATCH 2/7] usb: ehci-omap: don't execute OMAP3-specific code on non-OMAP3 Keshava Munegowda
     [not found]       ` <1282175377-2784-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49         ` [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support Keshava Munegowda
     [not found]           ` <1282175377-2784-4-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49             ` [RFC] [PATCH 4/7] omap: usb: ehci: IO mux mode settings for omap4 Keshava Munegowda
     [not found]               ` <1282175377-2784-5-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49                 ` [RFC] [PATCH 5/7] omap: usb: ehci: Initialize resources " Keshava Munegowda
2010-08-18 23:49                   ` [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3 Keshava Munegowda
2010-08-20  5:41                     ` Felipe Balbi
     [not found]                     ` <1282175377-2784-7-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49                       ` [RFC] [PATCH 7/7] omap: ehci: enable the ehci port on OMAP4SDP Keshava Munegowda
2010-08-20  5:45                       ` [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3 Felipe Balbi
     [not found]                         ` <20100820054507.GE15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20  5:59                           ` Gadiyar, Anand
     [not found]                             ` <5A47E75E594F054BAF48C5E4FC4B92AB0324222B65-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-08-20  6:13                               ` Felipe Balbi [this message]
2010-08-20  6:32                                 ` Gadiyar, Anand
2010-08-20  9:13                                   ` Felipe Balbi
     [not found]                                     ` <20100820091336.GC31377-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-20 17:30                                       ` Menon, Nishanth
     [not found]                   ` <1282175377-2784-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-20  5:39                     ` [RFC] [PATCH 5/7] omap: usb: ehci: Initialize resources for omap4 Felipe Balbi
2010-08-20  5:38           ` [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support Felipe Balbi
     [not found]             ` <20100820053844.GB15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20  5:47               ` Gadiyar, Anand
2010-08-20  5:52                 ` Felipe Balbi
2010-08-20  6:03                   ` Gadiyar, Anand
     [not found]                   ` <20100820055204.GF15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20  6:24                     ` Gadiyar, Anand
     [not found]                 ` <5A47E75E594F054BAF48C5E4FC4B92AB0324222B50-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-08-20  6:01                   ` Shilimkar, Santosh
2010-08-20  5:35       ` [RFC] [PATCH 2/7] usb: ehci-omap: don't execute OMAP3-specific code on non-OMAP3 Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820061322.GG15196@nokia.com \
    --to=felipe.balbi-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
    --cc=gadiyar-l0cyMroinI0@public.gmane.org \
    --cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.