All of
 help / color / mirror / Atom feed
From: Jeff King <>
To: Junio C Hamano <>
Cc:, Alex Riesen <>,
	Christian Couder <>,
	Jonathan Nieder <>
Subject: Re: "git -c web.browser=w3m help -w help" still kicks firefox
Date: Mon, 23 Aug 2010 14:38:58 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Aug 23, 2010 at 11:05:04AM -0700, Junio C Hamano wrote:

> A "trivial fix" would be to pass this info through the execv_git_cmd()
> interface by either exporting it via an environment variable or by
> modifying the command line options, but I am not sure about the possible
> fallouts from such a change.  For example, does "git -c var=value config ..."
> work sensibly when what "config" is told to do (say, remove a section)
> contradicts with having the named var with a given value?
> I am wondering if this is worth fixing it in the first place.

IMHO, it needs to be fixed. This bug means "git -c foo=bar X" silently
ignores the new value of "foo" if "X" is an external or a shell script.
For something like "help" it is a minor inconvenience, but I can
certainly see this causing data loss. Just in 30 seconds of grepping, I
see that "git -c mergetool.keepbackup=true mergetool" would be silently
ignored. Oops.

The environment is the only sensible way to pass this down, because we
need to hit not just externals, but things like "git config" invocations
from shell scripts. IOW, "git -c" really is about executing in a
sub-environment that pretends that config is set. Obviously we would
need to quote and unquote when using the environment as a transport (or
do something horrible like making a temporary config file and pointing
at it through the environment).

As for "git config", I would assume that "-c" parameters impact how
config itself behaves, but have no bearing at all on actual
configuration that it writes. I don't know if that is the case now,


  reply	other threads:[~2010-08-23 18:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 18:05 Junio C Hamano
2010-08-23 18:38 ` Jeff King [this message]
2010-08-23 19:16   ` Jeff King
2010-08-24  6:41     ` [PATCH 2/1] do not pass "git -c foo=bar" params to transport helpers Jonathan Nieder
2010-08-24 14:14       ` Jeff King
2010-08-24 19:07       ` [PATCH 2/1] do not pass &quot;git -c foo=bar&quot; " Eric Raible
2010-08-23 19:02 ` "git -c web.browser=w3m help -w help" still kicks firefox Alex Riesen
2010-08-23 20:33   ` Jeff King
2010-08-24  5:01     ` Jonathan Nieder
2010-08-24 14:12       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: "git -c web.browser=w3m help -w help" still kicks firefox' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.