* [patch] plip: remove superflous return
@ 2010-08-24 12:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-08-24 12:01 UTC (permalink / raw)
To: netdev; +Cc: Joe Perches, David S. Miller, kernel-janitors
This return isn't reachable and it obscures the goto on the line before.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/plip.c b/drivers/net/plip.c
index ec0349e..7e82a82 100644
--- a/drivers/net/plip.c
+++ b/drivers/net/plip.c
@@ -1279,7 +1279,6 @@ static void plip_attach (struct parport *port)
if (!nl->pardev) {
printk(KERN_ERR "%s: parport_register failed\n", name);
goto err_free_dev;
- return;
}
plip_init_netdev(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] plip: remove superflous return
@ 2010-08-24 12:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-08-24 12:01 UTC (permalink / raw)
To: netdev; +Cc: Joe Perches, David S. Miller, kernel-janitors
This return isn't reachable and it obscures the goto on the line before.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/plip.c b/drivers/net/plip.c
index ec0349e..7e82a82 100644
--- a/drivers/net/plip.c
+++ b/drivers/net/plip.c
@@ -1279,7 +1279,6 @@ static void plip_attach (struct parport *port)
if (!nl->pardev) {
printk(KERN_ERR "%s: parport_register failed\n", name);
goto err_free_dev;
- return;
}
plip_init_netdev(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] plip: remove superflous return
2010-08-24 12:01 ` Dan Carpenter
@ 2010-08-25 23:37 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-25 23:37 UTC (permalink / raw)
To: error27; +Cc: netdev, joe, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 24 Aug 2010 14:01:05 +0200
> This return isn't reachable and it obscures the goto on the line before.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] plip: remove superflous return
@ 2010-08-25 23:37 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-25 23:37 UTC (permalink / raw)
To: error27; +Cc: netdev, joe, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 24 Aug 2010 14:01:05 +0200
> This return isn't reachable and it obscures the goto on the line before.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-25 23:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-24 12:01 [patch] plip: remove superflous return Dan Carpenter
2010-08-24 12:01 ` Dan Carpenter
2010-08-25 23:37 ` David Miller
2010-08-25 23:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.