All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
@ 2010-08-26 21:06 tmarri at apm.com
  2010-08-27  9:35 ` Stefan Roese
  2010-08-29  8:56 ` Wolfgang Denk
  0 siblings, 2 replies; 8+ messages in thread
From: tmarri at apm.com @ 2010-08-26 21:06 UTC (permalink / raw)
  To: u-boot

From: Tirumala Marri <tmarri@apm.com>

Add bluestone board name  to the board.cfg.
Change Makefile to include bluestone board support.
Modified MAINTAINERS file to include board maintainers name.
Modified to include blouestone entry in the MAKEALL file.

Signed-off-by: Tirumala R Marri <tmarri@apm.com>
---
 MAINTAINERS |    3 +++
 MAKEALL     |    1 +
 Makefile    |    7 +++++++
 boards.cfg  |    1 +
 4 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4b91b0f..263c00b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -253,6 +253,9 @@ Feng Kan <fkan@amcc.com>
 
 	redwood			PPC4xx
 
+Tirumala Marri<tmarri@apm.com>
+	bluestone	APM82XXX
+
 Brad Kemp <Brad.Kemp@seranoa.com>
 
 	ppmc8260	MPC8260
diff --git a/MAKEALL b/MAKEALL
index b34ae33..02d5c17 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -191,6 +191,7 @@ LIST_4xx="		\
 	ASH405		\
 	bamboo		\
 	bamboo_nand	\
+	bluestone	\
 	bubinga		\
 	CANBT		\
 	canyonlands	\
diff --git a/Makefile b/Makefile
index 4f1cb1b..8cd5bd3 100644
--- a/Makefile
+++ b/Makefile
@@ -926,6 +926,13 @@ bamboo_nand_config:	unconfig
 	@echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk
 	@$(MKCONFIG) -n $@ -a bamboo powerpc ppc4xx bamboo amcc
 
+# Maui Bluestone board images
+bluestone_config:   unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$$(echo $(subst ,,$(@:_config=)) | \
+		tr '[:lower:]' '[:upper:]')" >$(obj)include/config.h
+	@$(MKCONFIG) -n $@ -a bluestone powerpc ppc4xx bluestone amcc
+
 # Arches, Canyonlands & Glacier use different U-Boot images
 arches_config \
 canyonlands_config \
diff --git a/boards.cfg b/boards.cfg
index 69c6897..48001d3 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -196,6 +196,7 @@ redwood		powerpc	ppc4xx		-		amcc
 taihu		powerpc	ppc4xx		-		amcc
 taishan		powerpc	ppc4xx		-		amcc
 yucca		powerpc	ppc4xx		-		amcc
+bluestone 	powerpc ppc4xx		-		amcc
 AP1000		powerpc	ppc4xx		ap1000		amirix
 CRAYL1		powerpc	ppc4xx		L1		cray
 ADCIOP		powerpc	ppc4xx		adciop		esd
-- 
1.6.1.rc3

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-26 21:06 [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes tmarri at apm.com
@ 2010-08-27  9:35 ` Stefan Roese
  2010-08-30 17:41   ` Tirumala Marri
  2010-08-31 22:35   ` Tirumala Marri
  2010-08-29  8:56 ` Wolfgang Denk
  1 sibling, 2 replies; 8+ messages in thread
From: Stefan Roese @ 2010-08-27  9:35 UTC (permalink / raw)
  To: u-boot

Hi Marri,

On Thursday 26 August 2010 23:06:20 tmarri at apm.com wrote:
> From: Tirumala Marri <tmarri@apm.com>
> 
> Add bluestone board name  to the board.cfg.
> Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

Compiling bluestone results in this warning:

[stefan at stefan-desktop u-boot (apm82xxx)]$ ./MAKEALL bluestone
Configuring for bluestone board...
cpu_init.c: In function 'cpu_init_f':
cpu_init.c:226: warning: unused variable 'val'

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-26 21:06 [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes tmarri at apm.com
  2010-08-27  9:35 ` Stefan Roese
@ 2010-08-29  8:56 ` Wolfgang Denk
  2010-08-30 18:47   ` Tirumala Marri
  1 sibling, 1 reply; 8+ messages in thread
From: Wolfgang Denk @ 2010-08-29  8:56 UTC (permalink / raw)
  To: u-boot

Dear tmarri at apm.com,

In message <1282856780-24660-1-git-send-email-tmarri@apm.com> you wrote:
> From: Tirumala Marri <tmarri@apm.com>
> 
> Add bluestone board name  to the board.cfg.

NAK.  This must not ne a separate commit.


> Change Makefile to include bluestone board support.

NAK. This is not needed and not allowed any more.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Prof:        So the American government went to IBM to come up with a
             data encryption standard and they came up with ...
Student:     EBCDIC!

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-27  9:35 ` Stefan Roese
@ 2010-08-30 17:41   ` Tirumala Marri
  2010-08-31 22:35   ` Tirumala Marri
  1 sibling, 0 replies; 8+ messages in thread
From: Tirumala Marri @ 2010-08-30 17:41 UTC (permalink / raw)
  To: u-boot

>
> On Thursday 26 August 2010 23:06:20 tmarri at apm.com wrote:
> > From: Tirumala Marri <tmarri@apm.com>
> >
> > Add bluestone board name  to the board.cfg.
> > Change Makefile to include bluestone board support.
>
> Not needed with board.cfg now. Please remove your changes to Makefile.
>
> Compiling bluestone results in this warning:
[Marri] Sure will fix it.
>
> [stefan at stefan-desktop u-boot (apm82xxx)]$ ./MAKEALL bluestone
> Configuring for bluestone board...
> cpu_init.c: In function 'cpu_init_f':
> cpu_init.c:226: warning: unused variable 'val'
>
> Please fix and resubmit. Thanks.
>
> Cheers,
> Stefan
Regards,
Marri

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-29  8:56 ` Wolfgang Denk
@ 2010-08-30 18:47   ` Tirumala Marri
  0 siblings, 0 replies; 8+ messages in thread
From: Tirumala Marri @ 2010-08-30 18:47 UTC (permalink / raw)
  To: u-boot

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Sunday, August 29, 2010 1:57 AM
> To: tmarri at apm.com
> Cc: u-boot at lists.denx.de; open-source-review at apm.com
> Subject: Re: [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file
> changes
>
> Dear tmarri at apm.com,
>
> In message <1282856780-24660-1-git-send-email-tmarri@apm.com> you
> wrote:
> > From: Tirumala Marri <tmarri@apm.com>
> >
> > Add bluestone board name  to the board.cfg.
>
> NAK.  This must not ne a separate commit.
>
>
> > Change Makefile to include bluestone board support.
>
> NAK. This is not needed and not allowed any more.
>
>
> Best regards,
>
> Wolfgang Denk
>

 Mr Wolfgang,
  Sure I will fix it.
Regards,
Marri

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-27  9:35 ` Stefan Roese
  2010-08-30 17:41   ` Tirumala Marri
@ 2010-08-31 22:35   ` Tirumala Marri
  2010-09-01  4:08     ` Stefan Roese
  2010-09-01  7:00     ` Rogan Dawes
  1 sibling, 2 replies; 8+ messages in thread
From: Tirumala Marri @ 2010-08-31 22:35 UTC (permalink / raw)
  To: u-boot

Hi Stefan,
> > Add bluestone board name  to the board.cfg.
> > Change Makefile to include bluestone board support.
>
> Not needed with board.cfg now. Please remove your changes to Makefile.
>
[Marri] You mean we only need board.cfg change and we don't need Makefile
entry ?

Regards,
Marri

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-31 22:35   ` Tirumala Marri
@ 2010-09-01  4:08     ` Stefan Roese
  2010-09-01  7:00     ` Rogan Dawes
  1 sibling, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2010-09-01  4:08 UTC (permalink / raw)
  To: u-boot

Hi Marri,

On Wednesday 01 September 2010 00:35:32 Tirumala Marri wrote:
> > > Add bluestone board name  to the board.cfg.
> > > Change Makefile to include bluestone board support.
> > 
> > Not needed with board.cfg now. Please remove your changes to Makefile.
> 
> [Marri] You mean we only need board.cfg change and we don't need Makefile
> entry ?

Yes.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
  2010-08-31 22:35   ` Tirumala Marri
  2010-09-01  4:08     ` Stefan Roese
@ 2010-09-01  7:00     ` Rogan Dawes
  1 sibling, 0 replies; 8+ messages in thread
From: Rogan Dawes @ 2010-09-01  7:00 UTC (permalink / raw)
  To: u-boot

On 2010/09/01 12:35 AM, Tirumala Marri wrote:
> Hi Stefan,
>>> Add bluestone board name  to the board.cfg.
>>> Change Makefile to include bluestone board support.
>>
>> Not needed with board.cfg now. Please remove your changes to Makefile.
>>
> [Marri] You mean we only need board.cfg change and we don't need Makefile
> entry ?

Yes, exactly.

Rogan

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-09-01  7:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-26 21:06 [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes tmarri at apm.com
2010-08-27  9:35 ` Stefan Roese
2010-08-30 17:41   ` Tirumala Marri
2010-08-31 22:35   ` Tirumala Marri
2010-09-01  4:08     ` Stefan Roese
2010-09-01  7:00     ` Rogan Dawes
2010-08-29  8:56 ` Wolfgang Denk
2010-08-30 18:47   ` Tirumala Marri

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.