All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tino Keitel <tino.keitel+xorg@tikei.de>
To: Maciej Rutecki <maciej.rutecki@gmail.com>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: 2.6.36-rc2 regression: Wrong screen resolution (1024x768 instead of 1680x1050)
Date: Mon, 30 Aug 2010 19:37:02 +0200	[thread overview]
Message-ID: <20100830173702.GA5006@mac.home> (raw)
In-Reply-To: <201008291519.20734.maciej.rutecki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Sun, Aug 29, 2010 at 15:19:20 +0200, Maciej Rutecki wrote:
> > TV1 connected 1024x768+0+0 (normal left inverted right x axis y axis)
> > 0mm x 0mm
> >    848x480        30.0 +
> >    640x480        30.0 +
> >    1024x768       30.0*
> >    800x600        30.0
> > 
> > This is a Mac mini Core 2 Duo with Intel i945 graphics.
> > 
> 
> Seems be similar to:
> https://bugzilla.kernel.org/show_bug.cgi?id=17301

Maybe. I don't know if this is connected, but after disabling TV out
using the attached patch, the screen has no signal after suspend to
RAM. However, the patch helped to get back the native LCD resolution
after boot.

Regards,
Tino

[-- Attachment #2: disable_tv_out.diff --]
[-- Type: text/x-diff, Size: 1185 bytes --]

diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
index 4f00390..1d306a4 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -25,6 +25,8 @@
  *
  * Derived from Xorg ddx, xf86-video-intel, src/i830_video.c
  */
+
+#include <linux/seq_file.h>
 #include "drmP.h"
 #include "drm.h"
 #include "i915_drm.h"
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index d2029ef..f71e488 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1279,6 +1279,8 @@ intel_tv_detect_type (struct intel_tv *intel_tv)
 	 *  1 0 X svideo
 	 *  0 0 0 Component
 	 */
+	type = -1;
+	goto out;
 	if ((tv_dac & TVDAC_SENSE_MASK) == (TVDAC_B_SENSE | TVDAC_C_SENSE)) {
 		DRM_DEBUG_KMS("Detected Composite TV connection\n");
 		type = DRM_MODE_CONNECTOR_Composite;
@@ -1292,7 +1294,7 @@ intel_tv_detect_type (struct intel_tv *intel_tv)
 		DRM_DEBUG_KMS("No TV connection detected\n");
 		type = -1;
 	}
-
+out:
 	/* Restore interrupt config */
 	spin_lock_irqsave(&dev_priv->user_irq_lock, irqflags);
 	i915_enable_pipestat(dev_priv, 0, PIPE_HOTPLUG_INTERRUPT_ENABLE |

WARNING: multiple messages have this Message-ID (diff)
From: Tino Keitel <tino.keitel+xorg@tikei.de>
To: Maciej Rutecki <maciej.rutecki@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.36-rc2 regression: Wrong screen resolution (1024x768 instead of 1680x1050)
Date: Mon, 30 Aug 2010 19:37:02 +0200	[thread overview]
Message-ID: <20100830173702.GA5006@mac.home> (raw)
In-Reply-To: <201008291519.20734.maciej.rutecki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Sun, Aug 29, 2010 at 15:19:20 +0200, Maciej Rutecki wrote:
> > TV1 connected 1024x768+0+0 (normal left inverted right x axis y axis)
> > 0mm x 0mm
> >    848x480        30.0 +
> >    640x480        30.0 +
> >    1024x768       30.0*
> >    800x600        30.0
> > 
> > This is a Mac mini Core 2 Duo with Intel i945 graphics.
> > 
> 
> Seems be similar to:
> https://bugzilla.kernel.org/show_bug.cgi?id=17301

Maybe. I don't know if this is connected, but after disabling TV out
using the attached patch, the screen has no signal after suspend to
RAM. However, the patch helped to get back the native LCD resolution
after boot.

Regards,
Tino

[-- Attachment #2: disable_tv_out.diff --]
[-- Type: text/x-diff, Size: 1185 bytes --]

diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
index 4f00390..1d306a4 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -25,6 +25,8 @@
  *
  * Derived from Xorg ddx, xf86-video-intel, src/i830_video.c
  */
+
+#include <linux/seq_file.h>
 #include "drmP.h"
 #include "drm.h"
 #include "i915_drm.h"
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index d2029ef..f71e488 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1279,6 +1279,8 @@ intel_tv_detect_type (struct intel_tv *intel_tv)
 	 *  1 0 X svideo
 	 *  0 0 0 Component
 	 */
+	type = -1;
+	goto out;
 	if ((tv_dac & TVDAC_SENSE_MASK) == (TVDAC_B_SENSE | TVDAC_C_SENSE)) {
 		DRM_DEBUG_KMS("Detected Composite TV connection\n");
 		type = DRM_MODE_CONNECTOR_Composite;
@@ -1292,7 +1294,7 @@ intel_tv_detect_type (struct intel_tv *intel_tv)
 		DRM_DEBUG_KMS("No TV connection detected\n");
 		type = -1;
 	}
-
+out:
 	/* Restore interrupt config */
 	spin_lock_irqsave(&dev_priv->user_irq_lock, irqflags);
 	i915_enable_pipestat(dev_priv, 0, PIPE_HOTPLUG_INTERRUPT_ENABLE |

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2010-08-30 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  7:30 2.6.36-rc2 regression: Wrong screen resolution (1024x768 instead of 1680x1050) Tino Keitel
2010-08-26  7:55 ` Tino Keitel
2010-08-26  7:55   ` Tino Keitel
2010-08-27 13:42 ` Tino Keitel
2010-08-27 13:42   ` Tino Keitel
2010-08-29 13:19 ` Maciej Rutecki
2010-08-30 17:37   ` Tino Keitel [this message]
2010-08-30 17:37     ` Tino Keitel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830173702.GA5006@mac.home \
    --to=tino.keitel+xorg@tikei.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.