All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pxa168_eth: fix a mdiobus leak
@ 2010-08-30  7:21 Denis Kirjanov
  2010-08-30  8:47 ` Dan Carpenter
  2010-09-01 21:30 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Denis Kirjanov @ 2010-08-30  7:21 UTC (permalink / raw)
  To: davem; +Cc: error27, ssanap, netdev

mdiobus resources must be released on exit
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
---
 drivers/net/pxa168_eth.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
index 410ea0a..85eddda 100644
--- a/drivers/net/pxa168_eth.c
+++ b/drivers/net/pxa168_eth.c
@@ -1606,6 +1606,8 @@ static int pxa168_eth_remove(struct platform_device *pdev)
 
 	iounmap(pep->base);
 	pep->base = NULL;
+	mdiobus_unregister(pep->smi_bus);
+	mdiobus_free(pep->smi_bus);
 	unregister_netdev(dev);
 	flush_scheduled_work();
 	free_netdev(dev);
-- 
1.6.4.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pxa168_eth: fix a mdiobus leak
  2010-08-30  7:21 [PATCH] pxa168_eth: fix a mdiobus leak Denis Kirjanov
@ 2010-08-30  8:47 ` Dan Carpenter
  2010-09-01 21:30 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-08-30  8:47 UTC (permalink / raw)
  To: Denis Kirjanov; +Cc: davem, ssanap, netdev

On Mon, Aug 30, 2010 at 07:21:38AM +0000, Denis Kirjanov wrote:
> mdiobus resources must be released on exit
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

Acked-by: Dan Carpenter <error27@gmail.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pxa168_eth: fix a mdiobus leak
  2010-08-30  7:21 [PATCH] pxa168_eth: fix a mdiobus leak Denis Kirjanov
  2010-08-30  8:47 ` Dan Carpenter
@ 2010-09-01 21:30 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-09-01 21:30 UTC (permalink / raw)
  To: dkirjanov; +Cc: error27, ssanap, netdev

From: Denis Kirjanov <dkirjanov@kernel.org>
Date: Mon, 30 Aug 2010 07:21:38 +0000

> mdiobus resources must be released on exit
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-09-01 21:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-30  7:21 [PATCH] pxa168_eth: fix a mdiobus leak Denis Kirjanov
2010-08-30  8:47 ` Dan Carpenter
2010-09-01 21:30 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.