All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	linux-samsung-soc@vger.kernel.org,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	myungjoo.ham@gmail.com, linux-arm-kernel@lists.infradead.org,
	Changhwan Youn <chaos.youn@samsung.com>
Subject: Re: [PATCH v2] MAX8952 PMIC Driver Initial Release
Date: Wed, 1 Sep 2010 12:16:02 +0100	[thread overview]
Message-ID: <20100901111602.GF17548@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTi=akjQ2wUp7h4gJfsn52BozMprVn9oKygec-0DU@mail.gmail.com>

On Wed, Sep 01, 2010 at 07:36:40PM +0900, Kyungmin Park wrote:

> As your word, first check the ID1 to detect the 8649 and 8952 and read
> ID2 again to distinguish it. But actually we pass the max8952 as
> platform device, so don't need to read ID2.

If you can read the ID from the chip it's always good to do so in order
to verify that the user has supplied accurate information.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] MAX8952 PMIC Driver Initial Release
Date: Wed, 1 Sep 2010 12:16:02 +0100	[thread overview]
Message-ID: <20100901111602.GF17548@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTi=akjQ2wUp7h4gJfsn52BozMprVn9oKygec-0DU@mail.gmail.com>

On Wed, Sep 01, 2010 at 07:36:40PM +0900, Kyungmin Park wrote:

> As your word, first check the ID1 to detect the 8649 and 8952 and read
> ID2 again to distinguish it. But actually we pass the max8952 as
> platform device, so don't need to read ID2.

If you can read the ID from the chip it's always good to do so in order
to verify that the user has supplied accurate information.

  reply	other threads:[~2010-09-01 11:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20  5:43 [PATCH v2] MAX8952 PMIC Driver Initial Release MyungJoo Ham
2010-08-20  5:43 ` MyungJoo Ham
2010-08-20  9:53 ` Mark Brown
2010-08-20  9:53   ` Mark Brown
2010-08-20 10:47   ` Liam Girdwood
2010-08-20 10:47     ` Liam Girdwood
2010-09-01  0:15     ` Kukjin Kim
2010-09-01  0:15       ` Kukjin Kim
2010-09-01  9:15       ` Mark Brown
2010-09-01  9:15         ` Mark Brown
2010-09-01  9:44         ` Kukjin Kim
2010-09-01  9:44           ` Kukjin Kim
2010-09-01  9:48           ` Mark Brown
2010-09-01  9:48             ` Mark Brown
2010-09-01 10:05             ` Kukjin Kim
2010-09-01 10:05               ` Kukjin Kim
2010-09-01 10:12           ` Kyungmin Park
2010-09-01 10:12             ` Kyungmin Park
2010-09-01 10:27             ` Kukjin Kim
2010-09-01 10:27               ` Kukjin Kim
2010-09-01 10:36               ` Kyungmin Park
2010-09-01 10:36                 ` Kyungmin Park
2010-09-01 11:16                 ` Mark Brown [this message]
2010-09-01 11:16                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901111602.GF17548@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=chaos.youn@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=myungjoo.ham@gmail.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.