All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	andi@firstfloor.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped
Date: Thu, 2 Sep 2010 08:57:31 +0200	[thread overview]
Message-ID: <20100902065731.GB29972@elte.hu> (raw)
In-Reply-To: <20100901213318.19353.54619.stgit@localhost.localdomain>


* Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> wrote:

> On certain BIOSes, SRAT enumeration isn't exported correctly. This 
> leads to NUMA node enumeration failure, and causes the kernel to fall 
> back onto a single node treated as flat memory.  This can happen on 
> large, multi-socket systems (4 or more sockets), and becomes 
> problematic for performance.
> 
> This patch adds a boot parameter to allow a kernel to be booted with 
> the option to skip the SRAT check.  There are BIOSes in production 
> that have these failures, so this will allow people in the field to 
> work around these BIOS issues.

> + 	sratbypassbios
> +		If specified, will skip an SRAT check for PXM coverage
> +		from BIOS enumeration.  Only to be used on systems with
> +		buggy BIOSes that munge the SRAT enumeration.

This isnt a particularly useful solution to users of said systems - they 
have to figure out that this option exists, and then they have to enter 
this option on the boot line.

A better solution would be to match these systems using DMI filters - 
_and_ to also have the boot time option to cover the case where a new 
system comes out with such a breakage. (or there's some system not yet 
mapped)


	Ingo

  parent reply	other threads:[~2010-09-02  6:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 21:33 [PATCH] [arch-x86] Allow SRAT integrity check to be skipped Peter P Waskiewicz Jr
2010-09-01 21:33 ` Andi Kleen
2010-09-01 22:04 ` rdunlap
2010-09-01 22:11   ` Peter P Waskiewicz Jr
2010-09-08 19:09     ` H. Peter Anvin
2010-09-03 10:04   ` Andi Kleen
2010-09-02  6:57 ` Ingo Molnar [this message]
2010-09-02 10:03   ` Andi Kleen
2010-09-03  6:39     ` Ingo Molnar
2010-09-07 19:38       ` Peter P Waskiewicz Jr
2010-09-07 19:56         ` Ingo Molnar
2010-09-07 20:03         ` H. Peter Anvin
2010-09-07 20:16           ` Peter P Waskiewicz Jr
2010-09-07 20:48             ` H. Peter Anvin
2010-09-08  6:55           ` Andi Kleen
2010-09-08 18:03             ` H. Peter Anvin
2010-09-08 18:51               ` Peter P Waskiewicz Jr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100902065731.GB29972@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.