From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: "rdunlap@xenotime.net" <rdunlap@xenotime.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped
Date: Wed, 08 Sep 2010 12:09:16 -0700 [thread overview]
Message-ID: <4C87DF5C.70801@zytor.com> (raw)
In-Reply-To: <1283379098.28591.20.camel@pjaxe>
On 09/01/2010 03:11 PM, Peter P Waskiewicz Jr wrote:
> On Wed, 2010-09-01 at 15:04 -0700, rdunlap@xenotime.net wrote:
>> On Wed, September 1, 2010 2:33 pm, Peter P Waskiewicz Jr wrote:
>>> Documentation/x86/x86_64/boot-options.txt | 4 ++++
>>> arch/x86/mm/srat_64.c | 20 +++++++++++++++++--- 2
>>> files changed, 21 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c index
>>> f9897f7..8719472 100644 --- a/arch/x86/mm/srat_64.c
>>> +++ b/arch/x86/mm/srat_64.c
>>> @@ -351,6 +351,15 @@ int __init acpi_get_nodes(struct bootnode *physnodes)
>>> return ret; }
>>>
>>>
>>> +int srat_bypass_bios = 0;
>>
>> static int srat_bypass_bios;
>>
>> Don't need to init to 0.
>
> I'll fix and send a second version. Thanks Randy.
>
Should be static *bool* srat_bypass_bios;
Please use bool for actual booleans; it prevents someone from being
"smart" and using values like 2 or -1 for "special cases".
-hpa
next prev parent reply other threads:[~2010-09-08 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 21:33 [PATCH] [arch-x86] Allow SRAT integrity check to be skipped Peter P Waskiewicz Jr
2010-09-01 21:33 ` Andi Kleen
2010-09-01 22:04 ` rdunlap
2010-09-01 22:11 ` Peter P Waskiewicz Jr
2010-09-08 19:09 ` H. Peter Anvin [this message]
2010-09-03 10:04 ` Andi Kleen
2010-09-02 6:57 ` Ingo Molnar
2010-09-02 10:03 ` Andi Kleen
2010-09-03 6:39 ` Ingo Molnar
2010-09-07 19:38 ` Peter P Waskiewicz Jr
2010-09-07 19:56 ` Ingo Molnar
2010-09-07 20:03 ` H. Peter Anvin
2010-09-07 20:16 ` Peter P Waskiewicz Jr
2010-09-07 20:48 ` H. Peter Anvin
2010-09-08 6:55 ` Andi Kleen
2010-09-08 18:03 ` H. Peter Anvin
2010-09-08 18:51 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C87DF5C.70801@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.