Re: [PATCH 14/14] kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: Dipankar Sarma <dipankar@in.ibm.com>, Ingo Molnar <mingo@elte.hu>,
	Josh Triplett <josh@joshtriplett.org>, Tejun Heo <tj@kernel.org>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org,
	vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 14/14] kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC
Date: Mon, 6 Sep 2010 09:13:55 -0700	[thread overview]
Message-ID: <20100906161355.GE2463@linux.vnet.ibm.com> (raw)
In-Reply-To: <dc92672f508081ee95b603244e992d2f3119c451.1283782701.git.qy03fugy@stud.informatik.uni-erlangen.de>

On Mon, Sep 06, 2010 at 04:37:12PM +0200, Christian Dietrich wrote:
> The CONFIG_DEBUG_LOCK_ALLOC ifdef isn't necessary at this point, because it is
> checked in an outer ifdef level already and has no effect here.

Good catch, queued!

							Thanx, Paul

> Signed-off-by: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
> ---
>  kernel/srcu.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/srcu.c b/kernel/srcu.c
> index 2980da3..c71e075 100644
> --- a/kernel/srcu.c
> +++ b/kernel/srcu.c
> @@ -46,11 +46,9 @@ static int init_srcu_struct_fields(struct srcu_struct *sp)
>  int __init_srcu_struct(struct srcu_struct *sp, const char *name,
>  		       struct lock_class_key *key)
>  {
> -#ifdef CONFIG_DEBUG_LOCK_ALLOC
>  	/* Don't re-initialize a lock while it is held. */
>  	debug_check_no_locks_freed((void *)sp, sizeof(*sp));
>  	lockdep_init_map(&sp->dep_map, name, key, 0);
> -#endif /* #ifdef CONFIG_DEBUG_LOCK_ALLOC */
>  	return init_srcu_struct_fields(sp);
>  }
>  EXPORT_SYMBOL_GPL(__init_srcu_struct);
> -- 
> 1.7.0.4
> 