From: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de> To: Lennert Buytenhek <kernel@wantstofly.org>, Russell King <linux@arm.linux.org.uk>, Yoshinori Sato <ysato@users.sourceforge.jp>, Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>, "James E.J. Bottomley" <jejb@parisc-linux.org>, Akinobu Mita <akinobu.mita@gmail.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Alexander Graf <agraf@suse.de>, "K.Prasad" <prasad@linux.vnet.ibm.com>, Dave Kleikamp <shaggy@linux.vnet.ibm.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, linux390@de.ibm.com, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Borislav Petkov <borislav.petkov@amd.com>, "David S. Miller" <davem@davemloft.net>, Roland Dreier <rolandd@cisco.com>, Alexey Dobriyan <adobriyan@gmail.com>, Joe Perches <joe@perches.com>, "Juergen E. Fischer" <fischer@norbit.de>, Tejun Heo <tj@kernel.org>, Krzysztof Helt <krzysztof.h1@wp.pl>, Andrew Morton <akpm@linux-foundation.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Petr Vandrovec <vandrove@vc.cvut.cz>, Jean Delvare <khali@linux-fr.org>, Arnaldo Carvalho de Melo <acme@redhat.com>, "Eric W. Biederman" <ebiederm@xmission.com>, Ben Hutchings <ben@decadent.org.uk>, Cyrill Gorcunov <gorcunov@openvz.org>, Peter Zijlstra <peterz@infradead.org>, Mike Galbraith <efault@gmx.de>, Dipankar Sarma <dipankar@in.ibm.com>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Lai Jiangshan <laijs@cn.fujitsu.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: vamos-dev@i4.informatik.uni-erlangen.de Subject: [PATCH 00/14] Removing dead code Date: Mon, 6 Sep 2010 16:35:49 +0200 [thread overview] Message-ID: <cover.1283782698.git.qy03fugy@stud.informatik.uni-erlangen.de> (raw) Hi all! As part of the VAMOS[0] research project at the University of Erlangen we are looking at multiple integrity errors in linux' configuration system. I've been running a check on the whole sourcetree for code block which are undead. This means they can't be deselected and are always in the kernel if the enviroment of the block is selected. They have often the form of #ifdef ABC .... #ifdef ABC fooooo #endif #endif Here the ifdefs of the inner block can be removed without any harm. At this point we just checked the source code (for the undead), but we want to do a crosscheck with the Kconfig for undead code blocks in the future. I build the patches against a vanilla kernel (v2.6.36-rc3) in order to try if the kernel compiles with this patches. Please keep me informed of this patch getting confirmed / merged so we can keep track of it. Regards Christian Dietrich [0] http://vamos1.informatik.uni-erlangen.de/ Christian Dietrich (14): arch/arm: Removing undead ifdef __ASSEMBLY__ arch/h8300: Removing dead ifdef __H8300_TLB_H__ arch/parisc: Removing undead ifdef CONFIG_PA20 arch/{s390,powerpc}: Removing undead ifdef __KERNEL__ arch/x86: Removing undead ifdef ACPI/X86_IO_ACPI drivers/net: Removing undead ifdef CHELSIO_T1_1G drivers/scsi: Removing undead ifdef __ISAPNP__ drivers/scsi: Removing undead ifdef CONFIG_PCI drivers/scsi: Removing undead ifdef REAL_DMA drivers/video: Removing undead ifdef ATAFB_FALCON drivers/video: Removing undead ifdef CONFIG_FB_MATROX_G include/linux: Removing undead ifdef __KERNEL__ kernel/: Removing undead ifdef CONFIG_SMP kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC arch/arm/mach-ixp23xx/include/mach/platform.h | 3 --- arch/h8300/include/asm/tlb.h | 13 ------------- arch/parisc/kernel/unaligned.c | 3 --- arch/powerpc/include/asm/processor.h | 2 -- arch/powerpc/include/asm/vdso_datapage.h | 2 -- arch/s390/include/asm/processor.h | 4 ---- arch/x86/kernel/early-quirks.c | 2 -- drivers/net/chelsio/subr.c | 2 -- drivers/scsi/aha152x.c | 2 -- drivers/scsi/aic7xxx_old.c | 2 -- drivers/scsi/atari_NCR5380.c | 6 ------ drivers/video/atafb.c | 2 -- drivers/video/matrox/matroxfb_DAC1064.c | 5 +---- include/linux/socket.h | 6 +----- kernel/sched.c | 4 +--- kernel/srcu.c | 2 -- 16 files changed, 3 insertions(+), 57 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: qy03fugy@stud.informatik.uni-erlangen.de (Christian Dietrich) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 00/14] Removing dead code Date: Mon, 6 Sep 2010 16:35:49 +0200 [thread overview] Message-ID: <cover.1283782698.git.qy03fugy@stud.informatik.uni-erlangen.de> (raw) Hi all! As part of the VAMOS[0] research project at the University of Erlangen we are looking at multiple integrity errors in linux' configuration system. I've been running a check on the whole sourcetree for code block which are undead. This means they can't be deselected and are always in the kernel if the enviroment of the block is selected. They have often the form of #ifdef ABC .... #ifdef ABC fooooo #endif #endif Here the ifdefs of the inner block can be removed without any harm. At this point we just checked the source code (for the undead), but we want to do a crosscheck with the Kconfig for undead code blocks in the future. I build the patches against a vanilla kernel (v2.6.36-rc3) in order to try if the kernel compiles with this patches. Please keep me informed of this patch getting confirmed / merged so we can keep track of it. Regards Christian Dietrich [0] http://vamos1.informatik.uni-erlangen.de/ Christian Dietrich (14): arch/arm: Removing undead ifdef __ASSEMBLY__ arch/h8300: Removing dead ifdef __H8300_TLB_H__ arch/parisc: Removing undead ifdef CONFIG_PA20 arch/{s390,powerpc}: Removing undead ifdef __KERNEL__ arch/x86: Removing undead ifdef ACPI/X86_IO_ACPI drivers/net: Removing undead ifdef CHELSIO_T1_1G drivers/scsi: Removing undead ifdef __ISAPNP__ drivers/scsi: Removing undead ifdef CONFIG_PCI drivers/scsi: Removing undead ifdef REAL_DMA drivers/video: Removing undead ifdef ATAFB_FALCON drivers/video: Removing undead ifdef CONFIG_FB_MATROX_G include/linux: Removing undead ifdef __KERNEL__ kernel/: Removing undead ifdef CONFIG_SMP kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC arch/arm/mach-ixp23xx/include/mach/platform.h | 3 --- arch/h8300/include/asm/tlb.h | 13 ------------- arch/parisc/kernel/unaligned.c | 3 --- arch/powerpc/include/asm/processor.h | 2 -- arch/powerpc/include/asm/vdso_datapage.h | 2 -- arch/s390/include/asm/processor.h | 4 ---- arch/x86/kernel/early-quirks.c | 2 -- drivers/net/chelsio/subr.c | 2 -- drivers/scsi/aha152x.c | 2 -- drivers/scsi/aic7xxx_old.c | 2 -- drivers/scsi/atari_NCR5380.c | 6 ------ drivers/video/atafb.c | 2 -- drivers/video/matrox/matroxfb_DAC1064.c | 5 +---- include/linux/socket.h | 6 +----- kernel/sched.c | 4 +--- kernel/srcu.c | 2 -- 16 files changed, 3 insertions(+), 57 deletions(-)
next reply other threads:[~2010-09-06 14:35 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-06 14:35 Christian Dietrich [this message] 2010-09-06 14:35 ` [PATCH 00/14] Removing dead code Christian Dietrich 2010-09-06 14:35 ` [PATCH 01/14] arch/arm: Removing undead ifdef __ASSEMBLY__ Christian Dietrich 2010-09-06 14:35 ` Christian Dietrich 2010-09-06 14:36 ` [PATCH 02/14] arch/h8300: Removing dead ifdef __H8300_TLB_H__ Christian Dietrich 2010-09-06 18:32 ` Andreas Schwab 2010-09-06 14:36 ` [PATCH 03/14] arch/parisc: Removing undead ifdef CONFIG_PA20 Christian Dietrich 2010-09-06 14:36 ` Christian Dietrich 2010-09-08 21:18 ` Kyle McMartin 2010-09-06 14:36 ` [PATCH 04/14] arch/{s390,powerpc}: Removing undead ifdef __KERNEL__ Christian Dietrich 2010-09-06 14:36 ` [PATCH 05/14] arch/x86: Removing undead ifdef ACPI/X86_IO_ACPI Christian Dietrich 2010-09-06 14:57 ` Borislav Petkov 2010-09-08 8:35 ` [tip:x86/cleanups] x86: Remove unnecessary #ifdef ACPI/X86_IO_ACPI tip-bot for Christian Dietrich 2010-09-06 14:36 ` [PATCH 06/14] drivers/net: Removing undead ifdef CHELSIO_T1_1G Christian Dietrich 2010-09-06 14:36 ` Christian Dietrich 2010-09-07 1:39 ` David Miller 2010-09-06 14:36 ` [PATCH 07/14] drivers/scsi: Removing undead ifdef __ISAPNP__ Christian Dietrich 2010-09-06 14:36 ` [PATCH 08/14] drivers/scsi: Removing undead ifdef CONFIG_PCI Christian Dietrich 2010-09-06 14:36 ` [PATCH 09/14] drivers/scsi: Removing undead ifdef REAL_DMA Christian Dietrich 2010-09-06 14:36 ` [PATCH 10/14] drivers/video: Removing undead ifdef ATAFB_FALCON Christian Dietrich 2010-09-10 17:50 ` Krzysztof Helt 2010-10-03 8:15 ` Geert Uytterhoeven 2010-09-06 14:36 ` [PATCH 11/14] drivers/video: Removing undead ifdef CONFIG_FB_MATROX_G Christian Dietrich 2010-09-06 14:36 ` [PATCH 11/14] drivers/video: Removing undead ifdef Christian Dietrich 2010-09-07 13:02 ` [PATCH 11/14] drivers/video: Removing undead ifdef CONFIG_FB_MATROX_G Jean Delvare 2010-09-07 13:02 ` [PATCH 11/14] drivers/video: Removing undead ifdef Jean Delvare 2010-09-06 14:36 ` [PATCH 12/14] include/linux: Removing undead ifdef __KERNEL__ Christian Dietrich 2010-09-06 16:16 ` Cyrill Gorcunov 2010-09-06 14:37 ` [PATCH 13/14] kernel/: Removing undead ifdef CONFIG_SMP Christian Dietrich 2010-09-08 8:36 ` [tip:sched/core] sched: Remove unnecessary #ifdef CONFIG_SMP tip-bot for Christian Dietrich 2010-09-06 14:37 ` [PATCH 14/14] kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC Christian Dietrich 2010-09-06 16:13 ` Paul E. McKenney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1283782698.git.qy03fugy@stud.informatik.uni-erlangen.de \ --to=qy03fugy@stud.informatik.uni-erlangen.de \ --cc=acme@redhat.com \ --cc=adobriyan@gmail.com \ --cc=agraf@suse.de \ --cc=akinobu.mita@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=ben@decadent.org.uk \ --cc=benh@kernel.crashing.org \ --cc=borislav.petkov@amd.com \ --cc=davem@davemloft.net \ --cc=deller@gmx.de \ --cc=dipankar@in.ibm.com \ --cc=ebiederm@xmission.com \ --cc=efault@gmx.de \ --cc=fischer@norbit.de \ --cc=geert@linux-m68k.org \ --cc=gorcunov@openvz.org \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=jejb@parisc-linux.org \ --cc=joe@perches.com \ --cc=josh@joshtriplett.org \ --cc=kernel@wantstofly.org \ --cc=khali@linux-fr.org \ --cc=krzysztof.h1@wp.pl \ --cc=kyle@mcmartin.ca \ --cc=laijs@cn.fujitsu.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux390@de.ibm.com \ --cc=linux@arm.linux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=paulmck@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=prasad@linux.vnet.ibm.com \ --cc=rolandd@cisco.com \ --cc=schwidefsky@de.ibm.com \ --cc=shaggy@linux.vnet.ibm.com \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=vamos-dev@i4.informatik.uni-erlangen.de \ --cc=vandrove@vc.cvut.cz \ --cc=x86@kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.