* [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
@ 2010-09-07 5:49 Greg Ungerer
2010-09-07 7:32 ` Andreas Schwab
2010-09-07 20:42 ` Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Greg Ungerer @ 2010-09-07 5:49 UTC (permalink / raw)
To: linux-m68k; +Cc: gerg
m68k/m68knommu: merge MMU and non-MMU atomic.h
The only difference between the MMU and non-MMU versions of atomic.h
is in the extra support ColdFire family processors. So merge this into
the MMU version of atomic.h.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
arch/m68k/include/asm/{atomic_mm.h => atomic.h} | 16 ++-
arch/m68k/include/asm/atomic_no.h | 155 -----------------------
2 files changed, 13 insertions(+), 158 deletions(-)
rename arch/m68k/include/asm/{atomic_mm.h => atomic.h} (92%)
delete mode 100644 arch/m68k/include/asm/atomic_no.h
diff --git a/arch/m68k/include/asm/atomic_mm.h b/arch/m68k/include/asm/atomic.h
similarity index 92%
rename from arch/m68k/include/asm/atomic_mm.h
rename to arch/m68k/include/asm/atomic.h
index 6a223b3..3db3c93 100644
--- a/arch/m68k/include/asm/atomic_mm.h
+++ b/arch/m68k/include/asm/atomic.h
@@ -18,14 +18,24 @@
#define atomic_read(v) (*(volatile int *)&(v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
+/*
+ * The ColdFire parts cannot do some immediate to memory operations,
+ * so for them we do not specify the "i" asm constraint.
+ */
+#ifdef CONFIG_COLDFIRE
+#define DI "d"
+#else
+#define DI "di"
+#endif
+
static inline void atomic_add(int i, atomic_t *v)
{
- __asm__ __volatile__("addl %1,%0" : "+m" (*v) : "id" (i));
+ __asm__ __volatile__("addl %1,%0" : "+m" (*v) : DI (i));
}
static inline void atomic_sub(int i, atomic_t *v)
{
- __asm__ __volatile__("subl %1,%0" : "+m" (*v) : "id" (i));
+ __asm__ __volatile__("subl %1,%0" : "+m" (*v) : DI (i));
}
static inline void atomic_inc(atomic_t *v)
@@ -150,7 +160,7 @@ static inline int atomic_sub_and_test(int i, atomic_t *v)
char c;
__asm__ __volatile__("subl %2,%1; seq %0"
: "=d" (c), "+m" (*v)
- : "id" (i));
+ : DI (i));
return c != 0;
}
diff --git a/arch/m68k/include/asm/atomic_no.h b/arch/m68k/include/asm/atomic_no.h
deleted file mode 100644
index 289310c..0000000
--- a/arch/m68k/include/asm/atomic_no.h
+++ /dev/null
@@ -1,155 +0,0 @@
-#ifndef __ARCH_M68KNOMMU_ATOMIC__
-#define __ARCH_M68KNOMMU_ATOMIC__
-
-#include <linux/types.h>
-#include <asm/system.h>
-
-/*
- * Atomic operations that C can't guarantee us. Useful for
- * resource counting etc..
- */
-
-/*
- * We do not have SMP m68k systems, so we don't have to deal with that.
- */
-
-#define ATOMIC_INIT(i) { (i) }
-
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic_set(v, i) (((v)->counter) = i)
-
-static __inline__ void atomic_add(int i, atomic_t *v)
-{
-#ifdef CONFIG_COLDFIRE
- __asm__ __volatile__("addl %1,%0" : "+m" (*v) : "d" (i));
-#else
- __asm__ __volatile__("addl %1,%0" : "+m" (*v) : "di" (i));
-#endif
-}
-
-static __inline__ void atomic_sub(int i, atomic_t *v)
-{
-#ifdef CONFIG_COLDFIRE
- __asm__ __volatile__("subl %1,%0" : "+m" (*v) : "d" (i));
-#else
- __asm__ __volatile__("subl %1,%0" : "+m" (*v) : "di" (i));
-#endif
-}
-
-static __inline__ int atomic_sub_and_test(int i, atomic_t * v)
-{
- char c;
-#ifdef CONFIG_COLDFIRE
- __asm__ __volatile__("subl %2,%1; seq %0"
- : "=d" (c), "+m" (*v)
- : "d" (i));
-#else
- __asm__ __volatile__("subl %2,%1; seq %0"
- : "=d" (c), "+m" (*v)
- : "di" (i));
-#endif
- return c != 0;
-}
-
-static __inline__ void atomic_inc(volatile atomic_t *v)
-{
- __asm__ __volatile__("addql #1,%0" : "+m" (*v));
-}
-
-/*
- * atomic_inc_and_test - increment and test
- * @v: pointer of type atomic_t
- *
- * Atomically increments @v by 1
- * and returns true if the result is zero, or false for all
- * other cases.
- */
-
-static __inline__ int atomic_inc_and_test(volatile atomic_t *v)
-{
- char c;
- __asm__ __volatile__("addql #1,%1; seq %0" : "=d" (c), "+m" (*v));
- return c != 0;
-}
-
-static __inline__ void atomic_dec(volatile atomic_t *v)
-{
- __asm__ __volatile__("subql #1,%0" : "+m" (*v));
-}
-
-static __inline__ int atomic_dec_and_test(volatile atomic_t *v)
-{
- char c;
- __asm__ __volatile__("subql #1,%1; seq %0" : "=d" (c), "+m" (*v));
- return c != 0;
-}
-
-static __inline__ void atomic_clear_mask(unsigned long mask, unsigned long *v)
-{
- __asm__ __volatile__("andl %1,%0" : "+m" (*v) : "id" (~(mask)));
-}
-
-static __inline__ void atomic_set_mask(unsigned long mask, unsigned long *v)
-{
- __asm__ __volatile__("orl %1,%0" : "+m" (*v) : "id" (mask));
-}
-
-/* Atomic operations are already serializing */
-#define smp_mb__before_atomic_dec() barrier()
-#define smp_mb__after_atomic_dec() barrier()
-#define smp_mb__before_atomic_inc() barrier()
-#define smp_mb__after_atomic_inc() barrier()
-
-static inline int atomic_add_return(int i, atomic_t * v)
-{
- unsigned long temp, flags;
-
- local_irq_save(flags);
- temp = *(long *)v;
- temp += i;
- *(long *)v = temp;
- local_irq_restore(flags);
-
- return temp;
-}
-
-#define atomic_add_negative(a, v) (atomic_add_return((a), (v)) < 0)
-
-static inline int atomic_sub_return(int i, atomic_t * v)
-{
- unsigned long temp, flags;
-
- local_irq_save(flags);
- temp = *(long *)v;
- temp -= i;
- *(long *)v = temp;
- local_irq_restore(flags);
-
- return temp;
-}
-
-#define atomic_cmpxchg(v, o, n) ((int)cmpxchg(&((v)->counter), (o), (n)))
-#define atomic_xchg(v, new) (xchg(&((v)->counter), new))
-
-static __inline__ int atomic_add_unless(atomic_t *v, int a, int u)
-{
- int c, old;
- c = atomic_read(v);
- for (;;) {
- if (unlikely(c == (u)))
- break;
- old = atomic_cmpxchg((v), c, c + (a));
- if (likely(old == c))
- break;
- c = old;
- }
- return c != (u);
-}
-
-#define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
-
-#define atomic_dec_return(v) atomic_sub_return(1,(v))
-#define atomic_inc_return(v) atomic_add_return(1,(v))
-
-#include <asm-generic/atomic-long.h>
-#endif /* __ARCH_M68KNOMMU_ATOMIC __ */
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
2010-09-07 5:49 [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h Greg Ungerer
@ 2010-09-07 7:32 ` Andreas Schwab
2010-09-07 9:53 ` Greg Ungerer
2010-09-07 20:42 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2010-09-07 7:32 UTC (permalink / raw)
To: Greg Ungerer; +Cc: linux-m68k, gerg
Greg Ungerer <gerg@snapgear.com> writes:
> +/*
> + * The ColdFire parts cannot do some immediate to memory operations,
> + * so for them we do not specify the "i" asm constraint.
> + */
> +#ifdef CONFIG_COLDFIRE
> +#define DI "d"
> +#else
> +#define DI "di"
> +#endif
I'd suggest to rename the macro, since DI could easily conflict with a
definition in a driver.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
2010-09-07 7:32 ` Andreas Schwab
@ 2010-09-07 9:53 ` Greg Ungerer
0 siblings, 0 replies; 5+ messages in thread
From: Greg Ungerer @ 2010-09-07 9:53 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-m68k, gerg
On 07/09/10 17:32, Andreas Schwab wrote:
> Greg Ungerer<gerg@snapgear.com> writes:
>
>> +/*
>> + * The ColdFire parts cannot do some immediate to memory operations,
>> + * so for them we do not specify the "i" asm constraint.
>> + */
>> +#ifdef CONFIG_COLDFIRE
>> +#define DI "d"
>> +#else
>> +#define DI "di"
>> +#endif
>
> I'd suggest to rename the macro, since DI could easily conflict with a
> definition in a driver.
Yeah, I agree. I'll make it a little more descriptive and longer.
Thanks
Greg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
2010-09-07 5:49 [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h Greg Ungerer
2010-09-07 7:32 ` Andreas Schwab
@ 2010-09-07 20:42 ` Geert Uytterhoeven
2010-09-08 0:25 ` Greg Ungerer
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2010-09-07 20:42 UTC (permalink / raw)
To: Greg Ungerer; +Cc: linux-m68k, gerg
On Tue, Sep 7, 2010 at 07:49, Greg Ungerer <gerg@snapgear.com> wrote:
> m68k/m68knommu: merge MMU and non-MMU atomic.h
>
> The only difference between the MMU and non-MMU versions of atomic.h
> is in the extra support ColdFire family processors. So merge this into
> the MMU version of atomic.h.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
> arch/m68k/include/asm/{atomic_mm.h => atomic.h} | 16 ++-
> arch/m68k/include/asm/atomic_no.h | 155 -----------------------
> 2 files changed, 13 insertions(+), 158 deletions(-)
> rename arch/m68k/include/asm/{atomic_mm.h => atomic.h} (92%)
> delete mode 100644 arch/m68k/include/asm/atomic_no.h
>
> diff --git a/arch/m68k/include/asm/atomic_mm.h b/arch/m68k/include/asm/atomic.h
> similarity index 92%
> rename from arch/m68k/include/asm/atomic_mm.h
> rename to arch/m68k/include/asm/atomic.h
> index 6a223b3..3db3c93 100644
> --- a/arch/m68k/include/asm/atomic_mm.h
> +++ b/arch/m68k/include/asm/atomic.h
arch/m68k/include/asm/atomic.h had a line
| #include <asm-generic/atomic64.h>
before, which is now gone? This break lib/atomic64.c.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
2010-09-07 20:42 ` Geert Uytterhoeven
@ 2010-09-08 0:25 ` Greg Ungerer
0 siblings, 0 replies; 5+ messages in thread
From: Greg Ungerer @ 2010-09-08 0:25 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, gerg
Geert Uytterhoeven wrote:
> On Tue, Sep 7, 2010 at 07:49, Greg Ungerer <gerg@snapgear.com> wrote:
>> m68k/m68knommu: merge MMU and non-MMU atomic.h
>>
>> The only difference between the MMU and non-MMU versions of atomic.h
>> is in the extra support ColdFire family processors. So merge this into
>> the MMU version of atomic.h.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>> ---
>> arch/m68k/include/asm/{atomic_mm.h => atomic.h} | 16 ++-
>> arch/m68k/include/asm/atomic_no.h | 155 -----------------------
>> 2 files changed, 13 insertions(+), 158 deletions(-)
>> rename arch/m68k/include/asm/{atomic_mm.h => atomic.h} (92%)
>> delete mode 100644 arch/m68k/include/asm/atomic_no.h
>>
>> diff --git a/arch/m68k/include/asm/atomic_mm.h b/arch/m68k/include/asm/atomic.h
>> similarity index 92%
>> rename from arch/m68k/include/asm/atomic_mm.h
>> rename to arch/m68k/include/asm/atomic.h
>> index 6a223b3..3db3c93 100644
>> --- a/arch/m68k/include/asm/atomic_mm.h
>> +++ b/arch/m68k/include/asm/atomic.h
>
> arch/m68k/include/asm/atomic.h had a line
>
> | #include <asm-generic/atomic64.h>
>
> before, which is now gone? This break lib/atomic64.c.
Oops. Missed that when I copied over atomic_mm.h. I'll fix this,
and rename DI and send an updated patch.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-08 0:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-07 5:49 [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h Greg Ungerer
2010-09-07 7:32 ` Andreas Schwab
2010-09-07 9:53 ` Greg Ungerer
2010-09-07 20:42 ` Geert Uytterhoeven
2010-09-08 0:25 ` Greg Ungerer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.