All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/5] rc-core: ir-core to rc-core conversion (v2)
@ 2010-09-07 21:51 David Härdeman
  2010-09-07 21:51 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: David Härdeman @ 2010-09-07 21:51 UTC (permalink / raw)
  To: mchehab; +Cc: linux-media, jarod

This is my current patch queue, the main change is to make struct rc_dev
the primary interface for rc drivers and to abstract away the fact that
there's an input device lurking in there somewhere. The first three
patches in the set are preparations for the change.

I've also converted winbond-cir over to rc-core.

Given the changes, these patches touch every single driver. Obviously I
haven't tested them all due to a lack of hardware (I have made sure that
all drivers compile without any warnings and I have tested the end result
on mceusb and winbond-cir hardware).

v2: rebased to take recent streamzap driver changes into account

---

David Härdeman (5):
      rc-code: merge and rename ir-core
      rc-core: remove remaining users of the ir-functions keyhandlers
      imon: split mouse events to a separate input dev
      rc-core: make struct rc_dev the primary interface for rc drivers
      rc-core: convert winbond-cir


 drivers/input/misc/Kconfig                  |   18 
 drivers/input/misc/Makefile                 |    1 
 drivers/input/misc/winbond-cir.c            | 1608 ---------------------------
 drivers/media/IR/Kconfig                    |   17 
 drivers/media/IR/Makefile                   |    4 
 drivers/media/IR/ene_ir.c                   |  121 +-
 drivers/media/IR/ene_ir.h                   |    3 
 drivers/media/IR/imon.c                     |  267 +++-
 drivers/media/IR/ir-core-priv.h             |   26 
 drivers/media/IR/ir-functions.c             |   98 --
 drivers/media/IR/ir-jvc-decoder.c           |   13 
 drivers/media/IR/ir-keytable.c              |  565 ---------
 drivers/media/IR/ir-lirc-codec.c            |  111 +-
 drivers/media/IR/ir-nec-decoder.c           |   15 
 drivers/media/IR/ir-raw-event.c             |  379 ------
 drivers/media/IR/ir-rc5-decoder.c           |   13 
 drivers/media/IR/ir-rc5-sz-decoder.c        |   13 
 drivers/media/IR/ir-rc6-decoder.c           |   17 
 drivers/media/IR/ir-sony-decoder.c          |   11 
 drivers/media/IR/ir-sysfs.c                 |  341 ------
 drivers/media/IR/mceusb.c                   |   93 +-
 drivers/media/IR/rc-core.c                  | 1317 ++++++++++++++++++++++
 drivers/media/IR/rc-map.c                   |  107 --
 drivers/media/IR/streamzap.c                |   68 -
 drivers/media/IR/winbond-cir.c              |  934 ++++++++++++++++
 drivers/media/dvb/dm1105/dm1105.c           |   40 -
 drivers/media/dvb/dvb-usb/dib0700.h         |    2 
 drivers/media/dvb/dvb-usb/dib0700_core.c    |   11 
 drivers/media/dvb/dvb-usb/dib0700_devices.c |  116 +-
 drivers/media/dvb/dvb-usb/dvb-usb-remote.c  |   78 +
 drivers/media/dvb/dvb-usb/dvb-usb.h         |   12 
 drivers/media/dvb/mantis/mantis_common.h    |    4 
 drivers/media/dvb/mantis/mantis_input.c     |   74 +
 drivers/media/dvb/siano/smscoreapi.c        |    2 
 drivers/media/dvb/siano/smsir.c             |   52 -
 drivers/media/dvb/siano/smsir.h             |    3 
 drivers/media/dvb/ttpci/budget-ci.c         |   49 -
 drivers/media/video/bt8xx/bttv-input.c      |   68 -
 drivers/media/video/bt8xx/bttvp.h           |    1 
 drivers/media/video/cx18/cx18-i2c.c         |    1 
 drivers/media/video/cx23885/cx23885-input.c |   64 +
 drivers/media/video/cx23885/cx23885.h       |    3 
 drivers/media/video/cx88/cx88-input.c       |   86 +
 drivers/media/video/em28xx/em28xx-input.c   |   72 +
 drivers/media/video/ir-kbd-i2c.c            |   39 -
 drivers/media/video/ivtv/ivtv-i2c.c         |    3 
 drivers/media/video/saa7134/saa7134-input.c |  122 +-
 drivers/staging/tm6000/tm6000-input.c       |   97 +-
 include/media/ir-common.h                   |   33 -
 include/media/ir-core.h                     |  193 +--
 include/media/ir-kbd-i2c.h                  |    6 
 51 files changed, 3175 insertions(+), 4216 deletions(-)
 delete mode 100644 drivers/input/misc/winbond-cir.c
 delete mode 100644 drivers/media/IR/ir-keytable.c
 delete mode 100644 drivers/media/IR/ir-raw-event.c
 delete mode 100644 drivers/media/IR/ir-sysfs.c
 create mode 100644 drivers/media/IR/rc-core.c
 delete mode 100644 drivers/media/IR/rc-map.c
 create mode 100644 drivers/media/IR/winbond-cir.c

-- 
David Härdeman

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/5] rc-code: merge and rename ir-core
@ 2010-09-08 15:10 Andy Walls
  2010-09-08 21:12 ` David Härdeman
  0 siblings, 1 reply; 16+ messages in thread
From: Andy Walls @ 2010-09-08 15:10 UTC (permalink / raw)
  To: Jarod Wilson, Mauro Carvalho Chehab; +Cc: David Härdeman, linux-media

Tag files and a decent editor are all one needs for full code navigation.  The kernel makefile already has a tags target to make the tags file.  

Smaller files make for better logical isolation of functions, limiting visibilty/scope, and faster compilation of a file (but maybe at the expense of link time).  That sort of isolation of functionality into smaller files also makes the code more digestable for someone new looking at it, IMO. 

Large files are good for a pile of stuff no one ever needs to look at again: well tested code that has an expected low rate of change in the future.

Regards,
Andy


Jarod Wilson <jarod@redhat.com> wrote:

>On Wed, Sep 08, 2010 at 10:42:10AM -0300, Mauro Carvalho Chehab wrote:
>> Em 07-09-2010 18:51, David Härdeman escreveu:
>> > This patch merges the files which makes up ir-core and renames the
>> > resulting module to rc-core. IMHO this makes it much easier to hack
>> > on the core module since all code is in one file.
>> > 
>> > This also allows some simplification of ir-core-priv.h as fewer internal
>> > functions need to be exposed.
>> 
>> I'm not sure about this patch. Big files tend to be harder to maintain,
>> as it takes more time to find the right functions inside it. Also, IMO, 
>> it makes sense to keep the raw-event code on a separate file.
>
>There's definitely a balance to be struck between file size and file
>count. Having all the relevant code in one file definitely has its
>advantage in that its easier to jump around from function to function and
>trace code paths taken, but I can see the argument for isolating the raw
>event handling code a bit too, especially if its going to be further
>expanded, which I believe is likely the case. So I guess I'm on the
>fence here. :)
>
>> Anyway, if we apply this patch right now, it will cause merge conflicts with
>> the input tree, due to the get/setkeycodebig patches, and with some other
>> patches that are pending merge/review. The better is to apply such patch
>> just after the release of 2.6.37-rc1, after having all those conflicts
>> solved.
>
>The imon patch that moves mouse/panel/knob input to its own input device
>should be possible to take in advance of everything else, more or less,
>though I need to finish actually testing it out (and should probably make
>some further imon fixes for issues listed in a kernel.org bugzilla, the
>number of which escapes me at the moment).
>
>-- 
>Jarod Wilson
>jarod@redhat.com
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 0/5] rc-core: ir-core to rc-core conversion
@ 2010-09-02 20:29 David Härdeman
  2010-09-02 20:29 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman
  0 siblings, 1 reply; 16+ messages in thread
From: David Härdeman @ 2010-09-02 20:29 UTC (permalink / raw)
  To: mchehab; +Cc: linux-media, jarod

This is my current patch queue, the main change is to make struct rc_dev
the primary interface for rc drivers and to abstract away the fact that
there's an input device lurking in there somewhere. The first three
patches in the set are preparations for the change.

I've also converted winbond-cir over to rc-core.

Given the changes, these patches touch every single driver. Obviously I
haven't tested them all due to a lack of hardware (I have made sure that
all drivers compile without any warnings and I have tested the end result
on mceusb and winbond-cir hardware).

---

David Härdeman (5):
      rc-code: merge and rename ir-core
      rc-core: remove remaining users of the ir-functions keyhandlers
      imon: split mouse events to a separate input dev
      rc-core: make struct rc_dev the primary interface for rc drivers
      rc-core: convert winbond-cir


 drivers/input/misc/Kconfig                  |   18 
 drivers/input/misc/Makefile                 |    1 
 drivers/input/misc/winbond-cir.c            | 1608 ---------------------------
 drivers/media/IR/Kconfig                    |   17 
 drivers/media/IR/Makefile                   |    4 
 drivers/media/IR/ene_ir.c                   |  121 +-
 drivers/media/IR/ene_ir.h                   |    3 
 drivers/media/IR/imon.c                     |  267 +++-
 drivers/media/IR/ir-core-priv.h             |   26 
 drivers/media/IR/ir-functions.c             |   98 --
 drivers/media/IR/ir-jvc-decoder.c           |   13 
 drivers/media/IR/ir-keytable.c              |  565 ---------
 drivers/media/IR/ir-lirc-codec.c            |  111 +-
 drivers/media/IR/ir-nec-decoder.c           |   15 
 drivers/media/IR/ir-raw-event.c             |  379 ------
 drivers/media/IR/ir-rc5-decoder.c           |   13 
 drivers/media/IR/ir-rc6-decoder.c           |   17 
 drivers/media/IR/ir-sony-decoder.c          |   11 
 drivers/media/IR/ir-sysfs.c                 |  340 ------
 drivers/media/IR/mceusb.c                   |   93 +-
 drivers/media/IR/rc-core.c                  | 1316 ++++++++++++++++++++++
 drivers/media/IR/rc-map.c                   |  107 --
 drivers/media/IR/streamzap.c                |   75 +
 drivers/media/IR/winbond-cir.c              |  934 ++++++++++++++++
 drivers/media/dvb/dm1105/dm1105.c           |   40 -
 drivers/media/dvb/dvb-usb/dib0700.h         |    2 
 drivers/media/dvb/dvb-usb/dib0700_core.c    |   11 
 drivers/media/dvb/dvb-usb/dib0700_devices.c |  116 +-
 drivers/media/dvb/dvb-usb/dvb-usb-remote.c  |   78 +
 drivers/media/dvb/dvb-usb/dvb-usb.h         |   12 
 drivers/media/dvb/mantis/mantis_common.h    |    4 
 drivers/media/dvb/mantis/mantis_input.c     |   74 +
 drivers/media/dvb/siano/smscoreapi.c        |    2 
 drivers/media/dvb/siano/smsir.c             |   52 -
 drivers/media/dvb/siano/smsir.h             |    3 
 drivers/media/dvb/ttpci/budget-ci.c         |   49 -
 drivers/media/video/bt8xx/bttv-input.c      |   68 -
 drivers/media/video/bt8xx/bttvp.h           |    1 
 drivers/media/video/cx18/cx18-i2c.c         |    1 
 drivers/media/video/cx23885/cx23885-input.c |   64 +
 drivers/media/video/cx23885/cx23885.h       |    3 
 drivers/media/video/cx88/cx88-input.c       |   86 +
 drivers/media/video/em28xx/em28xx-input.c   |   72 +
 drivers/media/video/ir-kbd-i2c.c            |   39 -
 drivers/media/video/ivtv/ivtv-i2c.c         |    3 
 drivers/media/video/saa7134/saa7134-input.c |  122 +-
 drivers/staging/tm6000/tm6000-input.c       |   97 +-
 include/media/ir-common.h                   |   33 -
 include/media/ir-core.h                     |  193 +--
 include/media/ir-kbd-i2c.h                  |    6 
 50 files changed, 3171 insertions(+), 4212 deletions(-)
 delete mode 100644 drivers/input/misc/winbond-cir.c
 delete mode 100644 drivers/media/IR/ir-keytable.c
 delete mode 100644 drivers/media/IR/ir-raw-event.c
 delete mode 100644 drivers/media/IR/ir-sysfs.c
 create mode 100644 drivers/media/IR/rc-core.c
 delete mode 100644 drivers/media/IR/rc-map.c
 create mode 100644 drivers/media/IR/winbond-cir.c

-- 
David Härdeman

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2010-09-09  8:20 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-07 21:51 [PATCH 0/5] rc-core: ir-core to rc-core conversion (v2) David Härdeman
2010-09-07 21:51 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman
2010-09-08 13:42   ` Mauro Carvalho Chehab
2010-09-08 14:10     ` Jarod Wilson
2010-09-08 21:42     ` David Härdeman
2010-09-09  4:44       ` Jarod Wilson
2010-09-07 21:51 ` [PATCH 2/5] rc-core: remove remaining users of the ir-functions keyhandlers David Härdeman
2010-09-09  5:00   ` Jarod Wilson
2010-09-07 21:51 ` [PATCH 3/5] imon: split mouse events to a separate input dev David Härdeman
2010-09-07 21:51 ` [PATCH 4/5] rc-core: make struct rc_dev the primary interface for rc drivers David Härdeman
2010-09-09  4:41   ` Jarod Wilson
2010-09-07 21:52 ` [PATCH 5/5] rc-core: convert winbond-cir David Härdeman
  -- strict thread matches above, loose matches on Subject: below --
2010-09-08 15:10 [PATCH 1/5] rc-code: merge and rename ir-core Andy Walls
2010-09-08 21:12 ` David Härdeman
2010-09-09  8:20   ` Maxim Levitsky
2010-09-02 20:29 [PATCH 0/5] rc-core: ir-core to rc-core conversion David Härdeman
2010-09-02 20:29 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.