* [PATCH linux-next.git] irq: irq and pci_ids patch for additional Intel Cougar Point DeviceIDs
@ 2010-03-25 23:11 Seth Heasley
2010-09-10 23:36 ` [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs Seth Heasley
0 siblings, 1 reply; 5+ messages in thread
From: Seth Heasley @ 2010-03-25 23:11 UTC (permalink / raw)
To: linux-kernel, linux-pci, jbarnes, khali; +Cc: seth.heasley
This patch adds additional LPC Controller DeviceIDs for the Intel Cougar Point PCH.
The DeviceIDs are defined and referenced as a range of values, the same way Ibex Peak was implemented.
This patch was built against the linux-next.git tree.
Signed-off-by: Seth Heasley <seth.heasley@intel.com>
--- include/linux/pci_ids.h.orig 2010-03-25 15:42:47.000000000 -0700
+++ include/linux/pci_ids.h 2010-03-25 16:00:31.000000000 -0700
@@ -2419,8 +2419,8 @@
#define PCI_DEVICE_ID_INTEL_82845_HB 0x1a30
#define PCI_DEVICE_ID_INTEL_IOAT 0x1a38
#define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
-#define PCI_DEVICE_ID_INTEL_CPT_LPC1 0x1c42
-#define PCI_DEVICE_ID_INTEL_CPT_LPC2 0x1c43
+#define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
+#define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
#define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
#define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
#define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
--- arch/x86/pci/irq.c.orig 2010-03-25 15:42:36.000000000 -0700
+++ arch/x86/pci/irq.c 2010-03-25 16:00:31.000000000 -0700
@@ -590,8 +590,6 @@
case PCI_DEVICE_ID_INTEL_ICH10_1:
case PCI_DEVICE_ID_INTEL_ICH10_2:
case PCI_DEVICE_ID_INTEL_ICH10_3:
- case PCI_DEVICE_ID_INTEL_CPT_LPC1:
- case PCI_DEVICE_ID_INTEL_CPT_LPC2:
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
@@ -606,6 +604,13 @@
return 1;
}
+ if ((device >= PCI_DEVICE_ID_INTEL_CPT_LPC_MIN) &&
+ (device <= PCI_DEVICE_ID_INTEL_CPT_LPC_MAX)) {
+ r->name = "PIIX/ICH";
+ r->get = pirq_piix_get;
+ r->set = pirq_piix_set;
+ return 1;
+ }
return 0;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs
2010-03-25 23:11 [PATCH linux-next.git] irq: irq and pci_ids patch for additional Intel Cougar Point DeviceIDs Seth Heasley
@ 2010-09-10 23:36 ` Seth Heasley
2010-09-11 8:57 ` Jean Delvare
2010-09-24 18:03 ` Jesse Barnes
0 siblings, 2 replies; 5+ messages in thread
From: Seth Heasley @ 2010-09-10 23:36 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-pci, jbarnes, khali, seth.heasley
This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH.
Signed-off-by: Seth Heasley <seth.heasley@intel.com>
--- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700
+++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700
@@ -2423,6 +2423,7 @@
#define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
#define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
#define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
+#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40
#define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
#define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
#define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
--- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700
+++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700
@@ -589,6 +589,7 @@
case PCI_DEVICE_ID_INTEL_ICH10_1:
case PCI_DEVICE_ID_INTEL_ICH10_2:
case PCI_DEVICE_ID_INTEL_ICH10_3:
+ case PCI_DEVICE_ID_INTEL_PBG_LPC:
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs
2010-09-10 23:36 ` [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs Seth Heasley
@ 2010-09-11 8:57 ` Jean Delvare
2010-09-24 17:21 ` Jesse Barnes
2010-09-24 18:03 ` Jesse Barnes
1 sibling, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2010-09-11 8:57 UTC (permalink / raw)
To: Seth Heasley; +Cc: linux-kernel, linux-pci, jbarnes
Hi Seth,
On Fri, 10 Sep 2010 16:36:39 -0700, Seth Heasley wrote:
> This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH.
>
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>
> --- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700
> @@ -2423,6 +2423,7 @@
> #define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
> +#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40
> #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
> #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
> #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
> --- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700
> @@ -589,6 +589,7 @@
> case PCI_DEVICE_ID_INTEL_ICH10_1:
> case PCI_DEVICE_ID_INTEL_ICH10_2:
> case PCI_DEVICE_ID_INTEL_ICH10_3:
> + case PCI_DEVICE_ID_INTEL_PBG_LPC:
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
Could Intel please stop using abbreviations for their chip names? If
the chip is named Patsburg then please use PATSBURG in the symbol names
too. MRST, PGB, etc. make me sick.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs
2010-09-11 8:57 ` Jean Delvare
@ 2010-09-24 17:21 ` Jesse Barnes
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Barnes @ 2010-09-24 17:21 UTC (permalink / raw)
To: Jean Delvare; +Cc: Seth Heasley, linux-kernel, linux-pci
On Sat, 11 Sep 2010 10:57:06 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> Hi Seth,
>
> On Fri, 10 Sep 2010 16:36:39 -0700, Seth Heasley wrote:
> > This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH.
> >
> > Signed-off-by: Seth Heasley <seth.heasley@intel.com>
> >
> > --- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700
> > +++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700
> > @@ -2423,6 +2423,7 @@
> > #define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
> > #define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
> > #define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
> > +#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40
> > #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
> > #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
> > #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
> > --- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700
> > +++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700
> > @@ -589,6 +589,7 @@
> > case PCI_DEVICE_ID_INTEL_ICH10_1:
> > case PCI_DEVICE_ID_INTEL_ICH10_2:
> > case PCI_DEVICE_ID_INTEL_ICH10_3:
> > + case PCI_DEVICE_ID_INTEL_PBG_LPC:
> > r->name = "PIIX/ICH";
> > r->get = pirq_piix_get;
> > r->set = pirq_piix_set;
>
> Could Intel please stop using abbreviations for their chip names? If
> the chip is named Patsburg then please use PATSBURG in the symbol names
> too. MRST, PGB, etc. make me sick.
Agreed. Do you want to submit a rename patch for the existing stuff?
You can do it on top of this one if you like, I'll put it into
linux-next.
I guess this means more typing for you in future patches, Seth. :)
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs
2010-09-10 23:36 ` [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs Seth Heasley
2010-09-11 8:57 ` Jean Delvare
@ 2010-09-24 18:03 ` Jesse Barnes
1 sibling, 0 replies; 5+ messages in thread
From: Jesse Barnes @ 2010-09-24 18:03 UTC (permalink / raw)
To: Seth Heasley; +Cc: linux-kernel, linux-pci, khali
On Fri, 10 Sep 2010 16:36:39 -0700
Seth Heasley <seth.heasley@intel.com> wrote:
> This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH.
>
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>
> --- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700
> @@ -2423,6 +2423,7 @@
> #define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
> +#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40
> #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
> #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
> #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
> --- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700
> @@ -589,6 +589,7 @@
> case PCI_DEVICE_ID_INTEL_ICH10_1:
> case PCI_DEVICE_ID_INTEL_ICH10_2:
> case PCI_DEVICE_ID_INTEL_ICH10_3:
> + case PCI_DEVICE_ID_INTEL_PBG_LPC:
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
>
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-24 18:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-25 23:11 [PATCH linux-next.git] irq: irq and pci_ids patch for additional Intel Cougar Point DeviceIDs Seth Heasley
2010-09-10 23:36 ` [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs Seth Heasley
2010-09-11 8:57 ` Jean Delvare
2010-09-24 17:21 ` Jesse Barnes
2010-09-24 18:03 ` Jesse Barnes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.