bna: potential null dereference

bna: potential null dereference

[Jiri Slaby]

Hi,

stanse found a potential null dereference:
bnad_cb_tx_cleanup
  -> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
  -> -- tcb cannot be null now --
  -> if (!tcb || (!tcb->unmap_q))

The thing is I have no idea whether the second parameter of cleanup may
be null (move assignment after the check) or not (remove the check)

Could you fix that?

thanks,
-- 
js

Re: bna: potential null dereference

[David Miller]

From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 04 Sep 2010 14:59:54 +0200

> stanse found a potential null dereference:
> bnad_cb_tx_cleanup
>   -> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
>   -> -- tcb cannot be null now --
>   -> if (!tcb || (!tcb->unmap_q))
> 
> The thing is I have no idea whether the second parameter of cleanup may
> be null (move assignment after the check) or not (remove the check)
> 
> Could you fix that?

Since the Brocade folks can't be bothered to fix this for more than
a week I'll take care of this, thanks Jiri.

Re: bna: potential null dereference

[David Miller]

From: Debashis Dutt <debdut@gmail.com>
Date: Sun, 12 Sep 2010 15:35:41 -0700

> A patch is on the way by tomorrow. BTW, this is just an unnecessary
> check that should be removed and not a NULL de-reference.

I've already made a fix in the net-next-2.6 tree.

You should send me fixes like this when you have them and are
reasonably confident of the change, which for something like
this should have been a day or two at most, not a week later.

RE: bna: potential null dereference

[Debashis Dutt]

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Sunday, September 12, 2010 3:38 PM
To: debdut@gmail.com
Cc: jirislaby@gmail.com; Debashis Dutt; Rasesh Mody; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: bna: potential null dereference

From: Debashis Dutt <debdut@gmail.com>
Date: Sun, 12 Sep 2010 15:35:41 -0700

> A patch is on the way by tomorrow. BTW, this is just an unnecessary
> check that should be removed and not a NULL de-reference.

I've already made a fix in the net-next-2.6 tree.

You should send me fixes like this when you have them and are
reasonably confident of the change, which for something like
this should have been a day or two at most, not a week later.


Sure David. 

Apologize for the delay again. Had too many things on my plate.
Would be more prompt hence forth.

Thanks
--Debashis