All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Tjernlund" <tjernlund@tjernlund.se>
Cc: git@vger.kernel.org
Subject: Re: gitweb: please show tags file history browsing
Date: Sun, 12 Sep 2010 12:19:57 +0200	[thread overview]
Message-ID: <201009121219.58191.jnareb@gmail.com> (raw)
In-Reply-To: <000d01cb525c$c6c2b8b0$54482a10$@se>

On Sun, 12 Sep 2010, Tjernlund wrote:
> > -----Original Message-----
> > From: Jakub Narebski [mailto:jnareb@gmail.com]
> > 
> > "Tjernlund" <tjernlund@tjernlund.se> writes:
> > 
> > > I would really like to see where the tags are when browsing
> > > file or directory history in gitweb. Would that be possible?

> > While it probably be possible to show tags in 'history' view, it would
> > be not easy.  The problem is that 'history' view shows only commits
> > that touch specified file or directory, and tagged commits usually do
> > not touch those files (at least if one is using "bump version number"
> > commits to tag them).
> > 
> > So you would have:
> > 1. Design where to show those tags - they would be between shown
> >    commits.
> > 2. Create code which shows some/all tags that are between commits in
> >    the presence of nonlinear history, without affecting performance
> >    too badly.
> 
> Ah, that is too bad because I think it would really useful.
> Image browsing a drivers history in the linux kernel. Then it would be
> really nice to see what changes/bug fixes went into what release.

First, you can help with the first issue even if you can't help with
the coding itself.

Second, with single 'git name-rev --tags --stdin' or with '--decorate'
or '%d' in format we could (I think) either display at least some tags,
or name-rev decorations, i.e. something like:

  (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers
  (v1.7.3-rc0~44) Merge branch 'maint'
  (v1.7.2.3~15) Typos in code comments, an error message, documentation
  (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'
  (v1.7.3-rc0~92) Merge branch 'maint'
  (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found
  [...]

If we want to display all tags we would have IIUC extend git-log to
generate such information.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-09-12 10:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-11 14:37 gitweb: please show tags file history browsing Tjernlund
2010-09-11 17:40 ` Jakub Narebski
2010-09-12  9:27   ` Tjernlund
2010-09-12 10:19     ` Jakub Narebski [this message]
2010-09-12 13:11       ` Tjernlund
2010-09-12 15:19         ` Jakub Narebski
2010-09-12 16:12           ` Tjernlund
2010-09-12 18:20             ` Jakub Narebski
2010-09-13  5:42               ` Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009121219.58191.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tjernlund@tjernlund.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.